From: Stephen Warren <swarren@wwwdotorg.org>
To: Prashant Gaikwad <pgaikwad@nvidia.com>
Cc: mturquette@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 6/9] clk: tegra: add clock support for tegra20
Date: Fri, 11 Jan 2013 13:54:07 -0700 [thread overview]
Message-ID: <50F07BEF.1080208@wwwdotorg.org> (raw)
In-Reply-To: <1357890387-23245-7-git-send-email-pgaikwad@nvidia.com>
On 01/11/2013 12:46 AM, Prashant Gaikwad wrote:
> Add tegra20 clock support based on common clock framework.
> diff --git a/drivers/clk/tegra/Makefile b/drivers/clk/tegra/Makefile
> +static void tegra20_pll_init(void)
> + /* PLLE */
> + clk = tegra_clk_plle("pll_e", "pll_ref", clk_base, NULL,
> + 0, 1000000000, &pll_e_params,
> + 0, pll_e_freq_table, NULL);
That 1000000000 (1GHz) needs to be 100000000 (100MHz). I can fix that up
when applying this.
With that change, everything I tested with this version of the series
works:-)
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 6/9] clk: tegra: add clock support for tegra20
Date: Fri, 11 Jan 2013 13:54:07 -0700 [thread overview]
Message-ID: <50F07BEF.1080208@wwwdotorg.org> (raw)
In-Reply-To: <1357890387-23245-7-git-send-email-pgaikwad@nvidia.com>
On 01/11/2013 12:46 AM, Prashant Gaikwad wrote:
> Add tegra20 clock support based on common clock framework.
> diff --git a/drivers/clk/tegra/Makefile b/drivers/clk/tegra/Makefile
> +static void tegra20_pll_init(void)
> + /* PLLE */
> + clk = tegra_clk_plle("pll_e", "pll_ref", clk_base, NULL,
> + 0, 1000000000, &pll_e_params,
> + 0, pll_e_freq_table, NULL);
That 1000000000 (1GHz) needs to be 100000000 (100MHz). I can fix that up
when applying this.
With that change, everything I tested with this version of the series
works:-)
next prev parent reply other threads:[~2013-01-11 20:54 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 7:46 [PATCH v4 0/9] Migrate Tegra to common clock framework Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
2013-01-11 7:46 ` [PATCH v4 1/9] ARM: tegra: Add function to read chipid Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
2013-01-11 7:46 ` [PATCH v4 2/9] clk: tegra: Add tegra specific clocks Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
2013-01-14 7:28 ` Sivaram Nair
2013-01-14 7:28 ` Sivaram Nair
[not found] ` <1357890387-23245-3-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-11 11:48 ` Hiroshi Doyu
2013-01-11 11:48 ` Hiroshi Doyu
2013-01-11 11:48 ` Hiroshi Doyu
[not found] ` <20130111.134820.1392079432650652356.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-11 21:35 ` Stephen Warren
2013-01-11 21:35 ` Stephen Warren
2013-01-11 21:35 ` Stephen Warren
[not found] ` <50F085A0.4090100-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-16 8:19 ` Hiroshi Doyu
2013-01-16 8:19 ` Hiroshi Doyu
2013-01-16 8:19 ` Hiroshi Doyu
[not found] ` <20130116.101906.399662310268585658.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-16 18:04 ` Stephen Warren
2013-01-16 18:04 ` Stephen Warren
2013-01-16 18:04 ` Stephen Warren
2013-01-16 12:31 ` Hiroshi Doyu
2013-01-16 12:31 ` Hiroshi Doyu
2013-01-16 12:31 ` Hiroshi Doyu
[not found] ` <20130116.143151.1531468192773974887.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-16 18:44 ` Stephen Warren
2013-01-16 18:44 ` Stephen Warren
2013-01-16 18:44 ` Stephen Warren
2013-01-16 15:12 ` Hiroshi Doyu
2013-01-16 15:12 ` Hiroshi Doyu
2013-01-16 15:12 ` Hiroshi Doyu
[not found] ` <20130116.171242.2189136612266237422.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-16 20:11 ` Stephen Warren
2013-01-16 20:11 ` Stephen Warren
2013-01-16 20:11 ` Stephen Warren
[not found] ` <50F7096C.7020803-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-17 5:03 ` Hiroshi Doyu
2013-01-17 5:03 ` Hiroshi Doyu
2013-01-17 5:03 ` Hiroshi Doyu
[not found] ` <20130117.070327.1625310713330263780.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-17 16:35 ` Stephen Warren
2013-01-17 16:35 ` Stephen Warren
2013-01-17 16:35 ` Stephen Warren
2013-01-11 7:46 ` [PATCH v4 3/9] arm: tegra: Move tegra_cpu_car.h to linux/clk/tegra.h Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
2013-01-11 7:46 ` [PATCH v4 4/9] ARM: tegra: Define Tegra20 CAR binding Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
2013-01-11 7:46 ` [PATCH v4 5/9] ARM: Tegra: Define Tegra30 " Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
[not found] ` <1357890387-23245-6-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-16 11:28 ` Hiroshi Doyu
2013-01-16 11:28 ` Hiroshi Doyu
2013-01-16 11:28 ` Hiroshi Doyu
[not found] ` <20130116132856.2896df94f553f78273c4574c-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-16 17:30 ` Stephen Warren
2013-01-16 17:30 ` Stephen Warren
2013-01-16 17:30 ` Stephen Warren
[not found] ` <1357890387-23245-1-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-11 7:46 ` [PATCH v4 6/9] clk: tegra: add clock support for tegra20 Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
2013-01-11 20:54 ` Stephen Warren [this message]
2013-01-11 20:54 ` Stephen Warren
2013-01-11 7:46 ` [PATCH v4 7/9] clk: tegra: add clock support for tegra30 Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
[not found] ` <1357890387-23245-8-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-11 12:17 ` Hiroshi Doyu
2013-01-11 12:17 ` Hiroshi Doyu
2013-01-11 12:17 ` Hiroshi Doyu
[not found] ` <20130111141725.ce3177ad04fc700186dc694d-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-11 21:40 ` Stephen Warren
2013-01-11 21:40 ` Stephen Warren
2013-01-11 21:40 ` Stephen Warren
[not found] ` <50F086E2.6010806-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-14 5:33 ` Hiroshi Doyu
2013-01-14 5:33 ` Hiroshi Doyu
2013-01-14 5:33 ` Hiroshi Doyu
2013-01-11 7:46 ` [PATCH v4 8/9] arm: tegra: Migrate to new clock code Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
2013-01-11 7:46 ` [PATCH v4 9/9] arm: tegra: Remove legacy " Prashant Gaikwad
2013-01-11 7:48 ` Prashant Gaikwad
2013-01-11 7:46 ` Prashant Gaikwad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F07BEF.1080208@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=pgaikwad@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.