* [RESEND PATCH] ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word
@ 2013-01-11 0:32 Ricardo Neri
2013-01-11 23:59 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Ricardo Neri @ 2013-01-11 0:32 UTC (permalink / raw)
To: broonie, lrg; +Cc: Ricardo Neri, alsa-devel, dzuniga
As the IEC-60958 channel status word is set by ANDing and ORing with
the appropriate definitions, the word bytes need to be initialized
to zero to avoid misconfiguration due to previous hw_params calls.
Signed-off-by: Ricardo Neri <rneri@dextratech.com>
---
| 2 ++
1 file changed, 2 insertions(+)
--git a/sound/soc/omap/omap-hdmi.c b/sound/soc/omap/omap-hdmi.c
index f59c69f..75ad378 100644
--- a/sound/soc/omap/omap-hdmi.c
+++ b/sound/soc/omap/omap-hdmi.c
@@ -110,6 +110,8 @@ static int omap_hdmi_dai_hw_params(struct snd_pcm_substream *substream,
/*
* fill the IEC-60958 channel status word
*/
+ /* initialize the word bytes */
+ memset(iec->status, 0, sizeof(iec->status));
/* specify IEC-60958-3 (commercial use) */
iec->status[0] &= ~IEC958_AES0_PROFESSIONAL;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word
2013-01-11 0:32 [RESEND PATCH] ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word Ricardo Neri
@ 2013-01-11 23:59 ` Mark Brown
2013-01-12 1:45 ` Ricardo Neri
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2013-01-11 23:59 UTC (permalink / raw)
To: Ricardo Neri; +Cc: alsa-devel, lrg, dzuniga
[-- Attachment #1.1: Type: text/plain, Size: 526 bytes --]
On Thu, Jan 10, 2013 at 06:32:13PM -0600, Ricardo Neri wrote:
> As the IEC-60958 channel status word is set by ANDing and ORing with
> the appropriate definitions, the word bytes need to be initialized
> to zero to avoid misconfiguration due to previous hw_params calls.
>
> Signed-off-by: Ricardo Neri <rneri@dextratech.com>
You've dropped my ack from this, you should keep acks on patches you
resubmit to save people time on review.
Anyway, I guess there's no need to merge via the video tree now so
applied.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word
2013-01-11 23:59 ` Mark Brown
@ 2013-01-12 1:45 ` Ricardo Neri
0 siblings, 0 replies; 3+ messages in thread
From: Ricardo Neri @ 2013-01-12 1:45 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, lrg, dzuniga
Hi Mark,
On 01/11/2013 05:59 PM, Mark Brown wrote:
> On Thu, Jan 10, 2013 at 06:32:13PM -0600, Ricardo Neri wrote:
>> As the IEC-60958 channel status word is set by ANDing and ORing with
>> the appropriate definitions, the word bytes need to be initialized
>> to zero to avoid misconfiguration due to previous hw_params calls.
>>
>> Signed-off-by: Ricardo Neri <rneri@dextratech.com>
>
> You've dropped my ack from this, you should keep acks on patches you
> resubmit to save people time on review.
Sorry, I missed that. I just basically went ahead and resubmitted
because you ack'ed it but the patch was not applied. I guess I should
have clarified that this change was independent of the video tree.
>
> Anyway, I guess there's no need to merge via the video tree now so
> applied.
>
Thanks!
Ricardo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-12 1:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-11 0:32 [RESEND PATCH] ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word Ricardo Neri
2013-01-11 23:59 ` Mark Brown
2013-01-12 1:45 ` Ricardo Neri
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.