* [Qemu-devel] [PATCH] hw/pc.c: add ULL suffix in ioport80_read and ioportF0_read return value
@ 2013-01-11 16:41 ` Julien Grall
0 siblings, 0 replies; 6+ messages in thread
From: Julien Grall @ 2013-01-11 16:41 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Julien Grall, aliguori
The commit c02e1eac887b1b0aee7361b1fcf889e7d47fed9d broke the compilation
for i386. ULL need to be specify for uint64_t value.
Signed-off-by: Julien Grall <julien.grall@citrix.com>
---
hw/pc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index dfa3144..ba1f19d 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -105,7 +105,7 @@ static void ioport80_write(void *opaque, hwaddr addr, uint64_t data,
static uint64_t ioport80_read(void *opaque, hwaddr addr, unsigned size)
{
- return 0xffffffffffffffff;
+ return 0xffffffffffffffffULL;
}
/* MSDOS compatibility mode FPU exception support */
@@ -130,7 +130,7 @@ static void ioportF0_write(void *opaque, hwaddr addr, uint64_t data,
static uint64_t ioportF0_read(void *opaque, hwaddr addr, unsigned size)
{
- return 0xffffffffffffffff;
+ return 0xffffffffffffffffULL;
}
/* TSC handling */
--
Julien Grall
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/pc.c: add ULL suffix in ioport80_read and ioportF0_read return value
2013-01-11 16:41 ` [Qemu-devel] " Julien Grall
@ 2013-01-12 6:37 ` Stefan Weil
-1 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2013-01-12 6:37 UTC (permalink / raw)
To: Julien Grall; +Cc: qemu-trivial, aliguori, qemu-devel
Am 11.01.2013 17:41, schrieb Julien Grall:
> The commit c02e1eac887b1b0aee7361b1fcf889e7d47fed9d broke the compilation
> for i386. ULL need to be specify for uint64_t value.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
> ---
> hw/pc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index dfa3144..ba1f19d 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -105,7 +105,7 @@ static void ioport80_write(void *opaque, hwaddr addr, uint64_t data,
>
> static uint64_t ioport80_read(void *opaque, hwaddr addr, unsigned size)
> {
> - return 0xffffffffffffffff;
> + return 0xffffffffffffffffULL;
> }
>
> /* MSDOS compatibility mode FPU exception support */
> @@ -130,7 +130,7 @@ static void ioportF0_write(void *opaque, hwaddr addr, uint64_t data,
>
> static uint64_t ioportF0_read(void *opaque, hwaddr addr, unsigned size)
> {
> - return 0xffffffffffffffff;
> + return 0xffffffffffffffffULL;
> }
>
> /* TSC handling */
Better: use UINT64_MAX. Then reviewers don't have to count 'f's.
As this patch is a build fix, it should be committed directly without
waiting for a qemu-trivial pull request.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] hw/pc.c: add ULL suffix in ioport80_read and ioportF0_read return value
@ 2013-01-12 6:37 ` Stefan Weil
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2013-01-12 6:37 UTC (permalink / raw)
To: Julien Grall; +Cc: qemu-trivial, aliguori, qemu-devel
Am 11.01.2013 17:41, schrieb Julien Grall:
> The commit c02e1eac887b1b0aee7361b1fcf889e7d47fed9d broke the compilation
> for i386. ULL need to be specify for uint64_t value.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
> ---
> hw/pc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index dfa3144..ba1f19d 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -105,7 +105,7 @@ static void ioport80_write(void *opaque, hwaddr addr, uint64_t data,
>
> static uint64_t ioport80_read(void *opaque, hwaddr addr, unsigned size)
> {
> - return 0xffffffffffffffff;
> + return 0xffffffffffffffffULL;
> }
>
> /* MSDOS compatibility mode FPU exception support */
> @@ -130,7 +130,7 @@ static void ioportF0_write(void *opaque, hwaddr addr, uint64_t data,
>
> static uint64_t ioportF0_read(void *opaque, hwaddr addr, unsigned size)
> {
> - return 0xffffffffffffffff;
> + return 0xffffffffffffffffULL;
> }
>
> /* TSC handling */
Better: use UINT64_MAX. Then reviewers don't have to count 'f's.
As this patch is a build fix, it should be committed directly without
waiting for a qemu-trivial pull request.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/pc.c: add ULL suffix in ioport80_read and ioportF0_read return value
2013-01-11 16:41 ` [Qemu-devel] " Julien Grall
@ 2013-01-12 16:11 ` Blue Swirl
-1 siblings, 0 replies; 6+ messages in thread
From: Blue Swirl @ 2013-01-12 16:11 UTC (permalink / raw)
To: Julien Grall; +Cc: qemu-trivial, aliguori, qemu-devel
Thanks, applied.
On Fri, Jan 11, 2013 at 4:41 PM, Julien Grall <julien.grall@citrix.com> wrote:
> The commit c02e1eac887b1b0aee7361b1fcf889e7d47fed9d broke the compilation
> for i386. ULL need to be specify for uint64_t value.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
> ---
> hw/pc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index dfa3144..ba1f19d 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -105,7 +105,7 @@ static void ioport80_write(void *opaque, hwaddr addr, uint64_t data,
>
> static uint64_t ioport80_read(void *opaque, hwaddr addr, unsigned size)
> {
> - return 0xffffffffffffffff;
> + return 0xffffffffffffffffULL;
> }
>
> /* MSDOS compatibility mode FPU exception support */
> @@ -130,7 +130,7 @@ static void ioportF0_write(void *opaque, hwaddr addr, uint64_t data,
>
> static uint64_t ioportF0_read(void *opaque, hwaddr addr, unsigned size)
> {
> - return 0xffffffffffffffff;
> + return 0xffffffffffffffffULL;
> }
>
> /* TSC handling */
> --
> Julien Grall
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] hw/pc.c: add ULL suffix in ioport80_read and ioportF0_read return value
@ 2013-01-12 16:11 ` Blue Swirl
0 siblings, 0 replies; 6+ messages in thread
From: Blue Swirl @ 2013-01-12 16:11 UTC (permalink / raw)
To: Julien Grall; +Cc: qemu-trivial, aliguori, qemu-devel
Thanks, applied.
On Fri, Jan 11, 2013 at 4:41 PM, Julien Grall <julien.grall@citrix.com> wrote:
> The commit c02e1eac887b1b0aee7361b1fcf889e7d47fed9d broke the compilation
> for i386. ULL need to be specify for uint64_t value.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
> ---
> hw/pc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index dfa3144..ba1f19d 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -105,7 +105,7 @@ static void ioport80_write(void *opaque, hwaddr addr, uint64_t data,
>
> static uint64_t ioport80_read(void *opaque, hwaddr addr, unsigned size)
> {
> - return 0xffffffffffffffff;
> + return 0xffffffffffffffffULL;
> }
>
> /* MSDOS compatibility mode FPU exception support */
> @@ -130,7 +130,7 @@ static void ioportF0_write(void *opaque, hwaddr addr, uint64_t data,
>
> static uint64_t ioportF0_read(void *opaque, hwaddr addr, unsigned size)
> {
> - return 0xffffffffffffffff;
> + return 0xffffffffffffffffULL;
> }
>
> /* TSC handling */
> --
> Julien Grall
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread