* [U-Boot] [PATCH] Remove duplication of CONFIG_BOOTCOUNT_LIMIT
@ 2013-01-13 15:54 Ashok Kumar Reddy
2013-01-13 17:11 ` Wolfgang Denk
0 siblings, 1 reply; 2+ messages in thread
From: Ashok Kumar Reddy @ 2013-01-13 15:54 UTC (permalink / raw)
To: u-boot
Remove duplication of CONFIG_BOOTCOUNT_LIMIT
Signed-off-by: Ashok Kumar Reddy <ashokkourla2000@gmail.com>
---
common/main.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/common/main.c b/common/main.c
index 5d8454e..2314f27 100644
--- a/common/main.c
+++ b/common/main.c
@@ -369,16 +369,14 @@ void main_loop (void)
#ifdef CONFIG_PREBOOT
char *p;
#endif
+
+ bootstage_mark_name(BOOTSTAGE_ID_MAIN_LOOP, "main_loop");
+
#ifdef CONFIG_BOOTCOUNT_LIMIT
unsigned long bootcount = 0;
unsigned long bootlimit = 0;
char *bcs;
char bcs_set[16];
-#endif /* CONFIG_BOOTCOUNT_LIMIT */
-
- bootstage_mark_name(BOOTSTAGE_ID_MAIN_LOOP, "main_loop");
-
-#ifdef CONFIG_BOOTCOUNT_LIMIT
bootcount = bootcount_load();
bootcount++;
bootcount_store (bootcount);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] Remove duplication of CONFIG_BOOTCOUNT_LIMIT
2013-01-13 15:54 [U-Boot] [PATCH] Remove duplication of CONFIG_BOOTCOUNT_LIMIT Ashok Kumar Reddy
@ 2013-01-13 17:11 ` Wolfgang Denk
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2013-01-13 17:11 UTC (permalink / raw)
To: u-boot
Dear Ashok Kumar Reddy,
In message <50F2D8D2.9010606@gmail.com> you wrote:
> Remove duplication of CONFIG_BOOTCOUNT_LIMIT
>
> Signed-off-by: Ashok Kumar Reddy <ashokkourla2000@gmail.com>
> ---
> common/main.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/common/main.c b/common/main.c
> index 5d8454e..2314f27 100644
> --- a/common/main.c
> +++ b/common/main.c
> @@ -369,16 +369,14 @@ void main_loop (void)
> #ifdef CONFIG_PREBOOT
> char *p;
> #endif
> +
> + bootstage_mark_name(BOOTSTAGE_ID_MAIN_LOOP, "main_loop");
> +
> #ifdef CONFIG_BOOTCOUNT_LIMIT
> unsigned long bootcount = 0;
> unsigned long bootlimit = 0;
> char *bcs;
> char bcs_set[16];
> -#endif /* CONFIG_BOOTCOUNT_LIMIT */
> -
> - bootstage_mark_name(BOOTSTAGE_ID_MAIN_LOOP, "main_loop");
> -
> -#ifdef CONFIG_BOOTCOUNT_LIMIT
> bootcount = bootcount_load();
> bootcount++;
> bootcount_store (bootcount);
NAK. You must not move code right in the middle of the declarations.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What was sliced bread the greatest thing since?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-13 17:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-13 15:54 [U-Boot] [PATCH] Remove duplication of CONFIG_BOOTCOUNT_LIMIT Ashok Kumar Reddy
2013-01-13 17:11 ` Wolfgang Denk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.