From: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Colin Cross <ccross-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Mike Galbraith <efault-Mmb7MZpHnFY@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH 2/2] cgroup: remove synchronize_rcu() from rebind_subsystems()
Date: Mon, 14 Jan 2013 17:24:18 +0800 [thread overview]
Message-ID: <50F3CEC2.1020909@huawei.com> (raw)
In-Reply-To: <50F3CE8E.5000402-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Nothing's protected by RCU in rebind_subsystems(), and I can't think
of a reason why it is needed.
Signed-off-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
kernel/cgroup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 67b0fa0..f43c929 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1079,7 +1079,6 @@ static int rebind_subsystems(struct cgroupfs_root *root,
}
}
root->subsys_mask = root->actual_subsys_mask = final_subsys_mask;
- synchronize_rcu();
return 0;
}
--
1.8.0.2
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: Colin Cross <ccross@google.com>, Mike Galbraith <efault@gmx.de>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>
Subject: [PATCH 2/2] cgroup: remove synchronize_rcu() from rebind_subsystems()
Date: Mon, 14 Jan 2013 17:24:18 +0800 [thread overview]
Message-ID: <50F3CEC2.1020909@huawei.com> (raw)
In-Reply-To: <50F3CE8E.5000402@huawei.com>
Nothing's protected by RCU in rebind_subsystems(), and I can't think
of a reason why it is needed.
Signed-off-by: Li Zefan <lizefan@huawei.com>
---
kernel/cgroup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 67b0fa0..f43c929 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1079,7 +1079,6 @@ static int rebind_subsystems(struct cgroupfs_root *root,
}
}
root->subsys_mask = root->actual_subsys_mask = final_subsys_mask;
- synchronize_rcu();
return 0;
}
--
1.8.0.2
next prev parent reply other threads:[~2013-01-14 9:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 9:23 [PATCH 1/2] cgroup: remove synchronize_rcu() from cgroup_attach_{task|proc}() Li Zefan
2013-01-14 9:23 ` Li Zefan
[not found] ` <50F3CE8E.5000402-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-01-14 9:24 ` Li Zefan [this message]
2013-01-14 9:24 ` [PATCH 2/2] cgroup: remove synchronize_rcu() from rebind_subsystems() Li Zefan
[not found] ` <50F3CEC2.1020909-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-01-14 18:55 ` Tejun Heo
2013-01-14 18:55 ` Tejun Heo
[not found] ` <20130114185512.GG27942-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-01-14 18:55 ` Tejun Heo
2013-01-14 18:55 ` Tejun Heo
2013-01-14 18:42 ` [PATCH 1/2] cgroup: remove synchronize_rcu() from cgroup_attach_{task|proc}() Tejun Heo
2013-01-14 18:42 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F3CEC2.1020909@huawei.com \
--to=lizefan-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=ccross-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=efault-Mmb7MZpHnFY@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.