Re: [PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C

[Peter Ujfalusi <peter.ujfalusi@ti.com>]

Hi Liu,

On 01/14/2013 03:18 AM, Liu, Chuansheng wrote:
> Hi maintainers,
> 
> Could you help to push this patch?
> Every time syncing the latest code, always meet this build error.
> Sorry to disturb.

First of all I'm sorry for this, since this is my mistake to not update the
Kconfig file at the same time.
AFAIK Samuel is really busy with Intel stuff (might be worth pinging him
within Intel), but I'm sure he is going to do everything he can to resolve this.
We can ask Greg to take this further as well. Whichever is going to be the faster.

Regards,
Péter

> 
>> -----Original Message-----
>> From: Peter Ujfalusi [mailto:peter.ujfalusi@ti.com]
>> Sent: Monday, December 31, 2012 6:04 PM
>> To: Liu, Chuansheng
>> Cc: sameo@linux.intel.com; linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C
>>
>> On 12/24/2012 03:19 PM, Chuansheng Liu wrote:
>>> This patch fix the below build error:
>>> drivers/built-in.o: In function `twl_probe':
>>> drivers/mfd/twl-core.c:1256: undefined reference to `devm_regmap_init_i2c'
>>> make: *** [vmlinux] Error 1
>>
>> Thanks Liu, I have missed this one.
>>
>> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>>
>>>
>>> Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
>>> ---
>>>  drivers/mfd/Kconfig |    1 +
>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>>> index 1c0abd4..47ad4e2 100644
>>> --- a/drivers/mfd/Kconfig
>>> +++ b/drivers/mfd/Kconfig
>>> @@ -292,6 +292,7 @@ config TWL4030_CORE
>>>  	bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0
>> Support"
>>>  	depends on I2C=y && GENERIC_HARDIRQS
>>>  	select IRQ_DOMAIN
>>> +	select REGMAP_I2C
>>>  	help
>>>  	  Say yes here if you have TWL4030 / TWL6030 family chip on your board.
>>>  	  This core driver provides register access and IRQ handling
>>>