[PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C

[PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C

[Chuansheng Liu]

This patch fix the below build error:
drivers/built-in.o: In function `twl_probe':
drivers/mfd/twl-core.c:1256: undefined reference to `devm_regmap_init_i2c'
make: *** [vmlinux] Error 1

Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
---
 drivers/mfd/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 1c0abd4..47ad4e2 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -292,6 +292,7 @@ config TWL4030_CORE
 	bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support"
 	depends on I2C=y && GENERIC_HARDIRQS
 	select IRQ_DOMAIN
+	select REGMAP_I2C
 	help
 	  Say yes here if you have TWL4030 / TWL6030 family chip on your board.
 	  This core driver provides register access and IRQ handling
-- 
1.7.0.4

Re: [PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C

[Peter Ujfalusi]

On 12/24/2012 03:19 PM, Chuansheng Liu wrote:
> This patch fix the below build error:
> drivers/built-in.o: In function `twl_probe':
> drivers/mfd/twl-core.c:1256: undefined reference to `devm_regmap_init_i2c'
> make: *** [vmlinux] Error 1

Thanks Liu, I have missed this one.

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> 
> Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
> ---
>  drivers/mfd/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 1c0abd4..47ad4e2 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -292,6 +292,7 @@ config TWL4030_CORE
>  	bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support"
>  	depends on I2C=y && GENERIC_HARDIRQS
>  	select IRQ_DOMAIN
> +	select REGMAP_I2C
>  	help
>  	  Say yes here if you have TWL4030 / TWL6030 family chip on your board.
>  	  This core driver provides register access and IRQ handling
> 

Re: [PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C

[Omar Ramirez Luna]

Hi,

On Mon, Dec 31, 2012 at 4:03 AM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> On 12/24/2012 03:19 PM, Chuansheng Liu wrote:
>> This patch fix the below build error:
>> drivers/built-in.o: In function `twl_probe':
>> drivers/mfd/twl-core.c:1256: undefined reference to `devm_regmap_init_i2c'
>> make: *** [vmlinux] Error 1
>
> Thanks Liu, I have missed this one.
>
> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

Mind taking mine, it was sent before this one :)

https://patchwork.kernel.org/patch/1908991/

Cheers,

Omar

Re: [PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C

[Omar Ramirez Luna]

On Thu, Jan 10, 2013 at 4:07 AM, Omar Ramirez Luna
<omar.ramirez@copitl.com> wrote:
> Hi,
>
> On Mon, Dec 31, 2012 at 4:03 AM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
>> On 12/24/2012 03:19 PM, Chuansheng Liu wrote:
>>> This patch fix the below build error:
>>> drivers/built-in.o: In function `twl_probe':
>>> drivers/mfd/twl-core.c:1256: undefined reference to `devm_regmap_init_i2c'
>>> make: *** [vmlinux] Error 1
>>
>> Thanks Liu, I have missed this one.
>>
>> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Mind taking mine, it was sent before this one :)
>
> https://patchwork.kernel.org/patch/1908991/

Actually it looks like Liu beat me by a few hours, so please ignore
mine and the noise.

Cheers,

Omar

RE: [PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C

[Liu, Chuansheng]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1608 bytes --]

Hi maintainers,

Could you help to push this patch?
Every time syncing the latest code, always meet this build error.
Sorry to disturb.

> -----Original Message-----
> From: Peter Ujfalusi [mailto:peter.ujfalusi@ti.com]
> Sent: Monday, December 31, 2012 6:04 PM
> To: Liu, Chuansheng
> Cc: sameo@linux.intel.com; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C
> 
> On 12/24/2012 03:19 PM, Chuansheng Liu wrote:
> > This patch fix the below build error:
> > drivers/built-in.o: In function `twl_probe':
> > drivers/mfd/twl-core.c:1256: undefined reference to `devm_regmap_init_i2c'
> > make: *** [vmlinux] Error 1
> 
> Thanks Liu, I have missed this one.
> 
> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> 
> >
> > Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
> > ---
> >  drivers/mfd/Kconfig |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 1c0abd4..47ad4e2 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -292,6 +292,7 @@ config TWL4030_CORE
> >  	bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0
> Support"
> >  	depends on I2C=y && GENERIC_HARDIRQS
> >  	select IRQ_DOMAIN
> > +	select REGMAP_I2C
> >  	help
> >  	  Say yes here if you have TWL4030 / TWL6030 family chip on your board.
> >  	  This core driver provides register access and IRQ handling
> >
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C

[Peter Ujfalusi]

Hi Liu,

On 01/14/2013 03:18 AM, Liu, Chuansheng wrote:
> Hi maintainers,
> 
> Could you help to push this patch?
> Every time syncing the latest code, always meet this build error.
> Sorry to disturb.

First of all I'm sorry for this, since this is my mistake to not update the
Kconfig file at the same time.
AFAIK Samuel is really busy with Intel stuff (might be worth pinging him
within Intel), but I'm sure he is going to do everything he can to resolve this.
We can ask Greg to take this further as well. Whichever is going to be the faster.

Regards,
Péter

> 
>> -----Original Message-----
>> From: Peter Ujfalusi [mailto:peter.ujfalusi@ti.com]
>> Sent: Monday, December 31, 2012 6:04 PM
>> To: Liu, Chuansheng
>> Cc: sameo@linux.intel.com; linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C
>>
>> On 12/24/2012 03:19 PM, Chuansheng Liu wrote:
>>> This patch fix the below build error:
>>> drivers/built-in.o: In function `twl_probe':
>>> drivers/mfd/twl-core.c:1256: undefined reference to `devm_regmap_init_i2c'
>>> make: *** [vmlinux] Error 1
>>
>> Thanks Liu, I have missed this one.
>>
>> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>>
>>>
>>> Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
>>> ---
>>>  drivers/mfd/Kconfig |    1 +
>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>>> index 1c0abd4..47ad4e2 100644
>>> --- a/drivers/mfd/Kconfig
>>> +++ b/drivers/mfd/Kconfig
>>> @@ -292,6 +292,7 @@ config TWL4030_CORE
>>>  	bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0
>> Support"
>>>  	depends on I2C=y && GENERIC_HARDIRQS
>>>  	select IRQ_DOMAIN
>>> +	select REGMAP_I2C
>>>  	help
>>>  	  Say yes here if you have TWL4030 / TWL6030 family chip on your board.
>>>  	  This core driver provides register access and IRQ handling
>>>

Re: [PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C

[gregkh]

On Mon, Jan 14, 2013 at 10:27:55AM +0100, Peter Ujfalusi wrote:
> Hi Liu,
> 
> On 01/14/2013 03:18 AM, Liu, Chuansheng wrote:
> > Hi maintainers,
> > 
> > Could you help to push this patch?
> > Every time syncing the latest code, always meet this build error.
> > Sorry to disturb.
> 
> First of all I'm sorry for this, since this is my mistake to not update the
> Kconfig file at the same time.
> AFAIK Samuel is really busy with Intel stuff (might be worth pinging him
> within Intel), but I'm sure he is going to do everything he can to resolve this.
> We can ask Greg to take this further as well. Whichever is going to be the faster.

Hm, I'm not taking mfd patches lately, but if needed, I can, just let me
know.

thanks,

greg k-h

Re: [PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C

[Samuel Ortiz]

Hi Liu,

On Mon, Jan 14, 2013 at 02:18:04AM +0000, Liu, Chuansheng wrote:
> Hi maintainers,
> 
> Could you help to push this patch?
> Every time syncing the latest code, always meet this build error.
> Sorry to disturb.
I was going to take this one when I saw Linus already applied it directly.
Sorry for the latency.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

RE: [PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C

[Liu, Chuansheng]

Thanks Samuel and Linus' help.

> -----Original Message-----
> From: Samuel Ortiz [mailto:sameo@linux.intel.com]
> Sent: Tuesday, January 22, 2013 8:37 AM
> To: Liu, Chuansheng
> Cc: Peter Ujfalusi; gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> torvalds@linux-foundation.org; Omar Ramirez Luna
> Subject: Re: [PATCH] mfd, TWL4030: TWL4030 need select REGMAP_I2C
> 
> Hi Liu,
> 
> On Mon, Jan 14, 2013 at 02:18:04AM +0000, Liu, Chuansheng wrote:
> > Hi maintainers,
> >
> > Could you help to push this patch?
> > Every time syncing the latest code, always meet this build error.
> > Sorry to disturb.
> I was going to take this one when I saw Linus already applied it directly.
> Sorry for the latency.
> 
> Cheers,
> Samuel.
> 
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/