All of lore.kernel.org
 help / color / mirror / Atom feed
From: rogerq@ti.com (Roger Quadros)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/14] usb: ehci-omap: Instantiate PHY devices if required
Date: Mon, 14 Jan 2013 11:48:45 +0200	[thread overview]
Message-ID: <50F3D47D.1020103@ti.com> (raw)
In-Reply-To: <20130111163255.GF23505@n2100.arm.linux.org.uk>

On 01/11/2013 06:32 PM, Russell King - ARM Linux wrote:
> On Fri, Jan 11, 2013 at 06:03:21PM +0200, Roger Quadros wrote:
>> diff --git a/include/linux/platform_data/usb-omap.h
>> b/include/linux/platform_data/usb-omap.h
>> index d63eb7d..927b8a1 100644
>> --- a/include/linux/platform_data/usb-omap.h
>> +++ b/include/linux/platform_data/usb-omap.h
>> @@ -38,6 +38,12 @@ enum usbhs_omap_port_mode {
>>  	OMAP_OHCI_PORT_MODE_TLL_2PIN_DPDM
>>  };
>>
>> +struct usbhs_phy_config {
>> +	char *name;		/* binds to device driver */
> 
> You may wish to consider making this const.
> 
OK.

--
cheers,
-roger

WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Alan Stern <stern@rowland.harvard.edu>, <sameo@linux.intel.com>,
	<tony@atomide.com>, <gregkh@linuxfoundation.org>,
	USB list <linux-usb@vger.kernel.org>,
	Kernel development list <linux-kernel@vger.kernel.org>,
	Felipe Balbi <balbi@ti.com>, <kishon@ti.com>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 07/14] usb: ehci-omap: Instantiate PHY devices if required
Date: Mon, 14 Jan 2013 11:48:45 +0200	[thread overview]
Message-ID: <50F3D47D.1020103@ti.com> (raw)
In-Reply-To: <20130111163255.GF23505@n2100.arm.linux.org.uk>

On 01/11/2013 06:32 PM, Russell King - ARM Linux wrote:
> On Fri, Jan 11, 2013 at 06:03:21PM +0200, Roger Quadros wrote:
>> diff --git a/include/linux/platform_data/usb-omap.h
>> b/include/linux/platform_data/usb-omap.h
>> index d63eb7d..927b8a1 100644
>> --- a/include/linux/platform_data/usb-omap.h
>> +++ b/include/linux/platform_data/usb-omap.h
>> @@ -38,6 +38,12 @@ enum usbhs_omap_port_mode {
>>  	OMAP_OHCI_PORT_MODE_TLL_2PIN_DPDM
>>  };
>>
>> +struct usbhs_phy_config {
>> +	char *name;		/* binds to device driver */
> 
> You may wish to consider making this const.
> 
OK.

--
cheers,
-roger

  reply	other threads:[~2013-01-14  9:48 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-10 16:51 [PATCH 00/14] USB: omap-ehci: Move PHY management to PHY driver Roger Quadros
2013-01-10 16:51 ` Roger Quadros
2013-01-10 16:51 ` [PATCH 01/14] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data Roger Quadros
2013-01-10 16:51   ` Roger Quadros
2013-01-10 23:45   ` Tony Lindgren
2013-01-10 23:45     ` Tony Lindgren
2013-01-11  9:40     ` Roger Quadros
2013-01-11  9:40       ` Roger Quadros
2013-01-11 18:13       ` Tony Lindgren
2013-01-11 18:13         ` Tony Lindgren
2013-01-14 11:28         ` Roger Quadros
2013-01-14 11:28           ` Roger Quadros
2013-01-14 17:18           ` Tony Lindgren
2013-01-14 17:18             ` Tony Lindgren
2013-01-10 16:51 ` [PATCH 02/14] usb: phy: Add new API usb_get_phy_from_dev() Roger Quadros
2013-01-10 16:51   ` Roger Quadros
2013-01-10 16:51 ` [PATCH 03/14] usb: xceiv: nop: Manage PHY clock Roger Quadros
2013-01-10 16:51   ` Roger Quadros
2013-01-10 16:51 ` [PATCH 04/14] usb: phy: nop: Handle power supply regulator for the PHY Roger Quadros
2013-01-10 16:51   ` Roger Quadros
2013-01-10 18:06   ` Sergei Shtylyov
2013-01-10 18:06     ` Sergei Shtylyov
2013-01-11  9:41     ` Roger Quadros
2013-01-11  9:41       ` Roger Quadros
2013-01-11 17:17   ` Russell King - ARM Linux
2013-01-11 17:17     ` Russell King - ARM Linux
2013-01-14  9:54     ` Roger Quadros
2013-01-14  9:54       ` Roger Quadros
2013-01-14 11:25       ` Russell King - ARM Linux
2013-01-14 11:25         ` Russell King - ARM Linux
2013-01-14 11:51         ` Roger Quadros
2013-01-14 11:51           ` Roger Quadros
2013-01-14 12:18           ` Russell King - ARM Linux
2013-01-14 12:18             ` Russell King - ARM Linux
2013-01-10 16:51 ` [PATCH 05/14] usb: phy: nop: Handle RESET " Roger Quadros
2013-01-10 16:51   ` Roger Quadros
2013-01-10 16:51 ` [PATCH 06/14] mfd: omap-usb-host: update nports in platform_data Roger Quadros
2013-01-10 16:51   ` Roger Quadros
2013-01-22  3:29   ` Samuel Ortiz
2013-01-22  3:29     ` Samuel Ortiz
2013-01-10 16:51 ` [PATCH 07/14] usb: ehci-omap: Instantiate PHY devices if required Roger Quadros
2013-01-10 16:51   ` Roger Quadros
2013-01-10 20:48   ` Alan Stern
2013-01-10 20:48     ` Alan Stern
2013-01-11 10:59     ` Roger Quadros
2013-01-11 10:59       ` Roger Quadros
2013-01-11 11:06       ` Roger Quadros
2013-01-11 11:06         ` Roger Quadros
2013-01-11 15:28       ` Alan Stern
2013-01-11 15:28         ` Alan Stern
2013-01-11 16:03         ` Roger Quadros
2013-01-11 16:03           ` Roger Quadros
2013-01-11 16:32           ` Russell King - ARM Linux
2013-01-11 16:32             ` Russell King - ARM Linux
2013-01-14  9:48             ` Roger Quadros [this message]
2013-01-14  9:48               ` Roger Quadros
2013-01-11 18:27           ` Alan Stern
2013-01-11 18:27             ` Alan Stern
2013-01-10 16:51 ` [PATCH 08/14] mfd: omap-usb-host: Remove PHY reset handling code Roger Quadros
2013-01-10 16:51   ` Roger Quadros
2013-01-22  3:28   ` Samuel Ortiz
2013-01-22  3:28     ` Samuel Ortiz
2013-01-10 16:51 ` [PATCH 09/14] usb: ehci-omap: " Roger Quadros
2013-01-10 16:51   ` Roger Quadros
2013-01-10 16:51 ` [PATCH 10/14] usb: ehci-omap: Remove PHY regulator " Roger Quadros
2013-01-10 16:51   ` Roger Quadros
2013-01-10 16:51 ` [PATCH 11/14] ARM: OMAP2+: omap4panda: Provide USB Host's PHY platform data Roger Quadros
2013-01-10 16:51   ` Roger Quadros
2013-01-10 16:51 ` [PATCH 12/14] ARM: OMAP2+: omap4panda: Adapt HUB power to regulator framework Roger Quadros
2013-01-10 16:51   ` Roger Quadros
2013-01-10 16:51 ` [PATCH 13/14] ARM: OMAP2+: omap4panda: Adapt HUB reset " Roger Quadros
2013-01-10 16:51   ` Roger Quadros
2013-01-10 16:51 ` [PATCH 14/14] ARM: OMAP2+: omap4panda: Remove irrelevant USB host platform data Roger Quadros
2013-01-10 16:51   ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F3D47D.1020103@ti.com \
    --to=rogerq@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.