From: David Daney <ddaney.cavm@gmail.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-mips@linux-mips.org, Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: 3.8-rc1 build failure with MIPS/SPARSEMEM
Date: Mon, 14 Jan 2013 14:03:39 -0800 [thread overview]
Message-ID: <50F480BB.6070105@gmail.com> (raw)
In-Reply-To: <20130114151641.GA17996@otc-wbsnb-06>
On 01/14/2013 07:16 AM, Kirill A. Shutemov wrote:
> On Sun, Dec 30, 2012 at 12:38:50PM +0200, Kirill A. Shutemov wrote:
>> On Thu, Dec 27, 2012 at 02:16:07PM +0200, Aaro Koskinen wrote:
>>> Hi,
>>>
>>> On Wed, Dec 26, 2012 at 02:34:35AM +0200, Kirill A. Shutemov wrote:
>>>> On MIPS if SPARSEMEM is enabled we've got this:
>>>>
>>>> In file included from /home/kas/git/public/linux/arch/mips/include/asm/pgtable.h:552,
>>>> from include/linux/mm.h:44,
>>>> from arch/mips/kernel/asm-offsets.c:14:
>>>> include/asm-generic/pgtable.h: In function ‘my_zero_pfn’:
>>>> include/asm-generic/pgtable.h:466: error: implicit declaration of function ‘page_to_section’
>>>> In file included from arch/mips/kernel/asm-offsets.c:14:
>>>> include/linux/mm.h: At top level:
>>>> include/linux/mm.h:738: error: conflicting types for ‘page_to_section’
>>>> include/asm-generic/pgtable.h:466: note: previous implicit declaration of ‘page_to_section’ was here
>>>>
>>>> Due header files inter-dependencies, the only way I see to fix it is
>>>> convert my_zero_pfn() for __HAVE_COLOR_ZERO_PAGE to macros.
>>>>
>>>> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
>>>
>>> Thanks, this works.
>>>
>>> Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>>
>> Andrew, could you take the patch?
I found the same problem and arrived at an equivalent solution.
Acked-by: David Daney <david.daney@cavium.com>
>
> ping?
>
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney.cavm@gmail.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-mips@linux-mips.org, Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: 3.8-rc1 build failure with MIPS/SPARSEMEM
Date: Mon, 14 Jan 2013 14:03:39 -0800 [thread overview]
Message-ID: <50F480BB.6070105@gmail.com> (raw)
In-Reply-To: <20130114151641.GA17996@otc-wbsnb-06>
On 01/14/2013 07:16 AM, Kirill A. Shutemov wrote:
> On Sun, Dec 30, 2012 at 12:38:50PM +0200, Kirill A. Shutemov wrote:
>> On Thu, Dec 27, 2012 at 02:16:07PM +0200, Aaro Koskinen wrote:
>>> Hi,
>>>
>>> On Wed, Dec 26, 2012 at 02:34:35AM +0200, Kirill A. Shutemov wrote:
>>>> On MIPS if SPARSEMEM is enabled we've got this:
>>>>
>>>> In file included from /home/kas/git/public/linux/arch/mips/include/asm/pgtable.h:552,
>>>> from include/linux/mm.h:44,
>>>> from arch/mips/kernel/asm-offsets.c:14:
>>>> include/asm-generic/pgtable.h: In function a??my_zero_pfna??:
>>>> include/asm-generic/pgtable.h:466: error: implicit declaration of function a??page_to_sectiona??
>>>> In file included from arch/mips/kernel/asm-offsets.c:14:
>>>> include/linux/mm.h: At top level:
>>>> include/linux/mm.h:738: error: conflicting types for a??page_to_sectiona??
>>>> include/asm-generic/pgtable.h:466: note: previous implicit declaration of a??page_to_sectiona?? was here
>>>>
>>>> Due header files inter-dependencies, the only way I see to fix it is
>>>> convert my_zero_pfn() for __HAVE_COLOR_ZERO_PAGE to macros.
>>>>
>>>> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
>>>
>>> Thanks, this works.
>>>
>>> Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>>
>> Andrew, could you take the patch?
I found the same problem and arrived at an equivalent solution.
Acked-by: David Daney <david.daney@cavium.com>
>
> ping?
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-01-14 22:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-22 12:27 3.8-rc1 build failure with MIPS/SPARSEMEM Aaro Koskinen
2012-12-22 12:27 ` Aaro Koskinen
2012-12-22 13:10 ` Kirill A. Shutemov
2012-12-22 13:31 ` Aaro Koskinen
2012-12-22 13:31 ` Aaro Koskinen
2012-12-26 0:34 ` Kirill A. Shutemov
2012-12-27 12:16 ` Aaro Koskinen
2012-12-27 12:16 ` Aaro Koskinen
2012-12-30 10:38 ` Kirill A. Shutemov
2013-01-14 15:16 ` Kirill A. Shutemov
2013-01-14 22:03 ` David Daney [this message]
2013-01-14 22:03 ` David Daney
2013-01-18 18:10 ` 3.8-rc4 build regression (was: Re: 3.8-rc1 build failure with MIPS/SPARSEMEM) David Daney
2013-01-18 18:10 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F480BB.6070105@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.