From: "Andreas Färber" <afaerber@suse.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] bswap: improve gluing
Date: Tue, 15 Jan 2013 05:25:04 +0100 [thread overview]
Message-ID: <50F4DA20.3020803@suse.de> (raw)
In-Reply-To: <1309ac93ff943931eb213dd87cd3570910b23926.1358094930.git.blauwirbel@gmail.com>
Am 13.01.2013 17:35, schrieb Blue Swirl:
> OpenBSD system compiler (gcc 4.2.1) has problems with concatenation
> of macro arguments in macro functions:
> CC aes.o
> In file included from /src/qemu/include/qemu-common.h:126,
> from /src/qemu/aes.c:30:
> /src/qemu/include/qemu/bswap.h: In function 'leul_to_cpu':
> /src/qemu/include/qemu/bswap.h:461: warning: implicit declaration of function 'bswapHOST_LONG_BITS'
> /src/qemu/include/qemu/bswap.h:461: warning: nested extern declaration of 'bswapHOST_LONG_BITS'
>
> Function leul_to_cpu() is only used in kvm-all.c, so the warnings
> are not fatal on OpenBSD without -Werror.
>
> Fix by applying glue(). Also add do {} while(0) wrapping and fix
> semicolon use while at it.
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Tested-by: Andreas Färber <afaerber@suse.de>
This unbreaks the build on openSUSE 12.2 ppc64:
gcc (SUSE Linux) 4.7.1 20120723 [gcc-4_7-branch revision 189773]
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-01-15 4:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-13 16:35 [Qemu-devel] [PATCH] bswap: improve gluing Blue Swirl
2013-01-14 15:15 ` Richard Henderson
2013-01-15 4:25 ` Andreas Färber [this message]
2013-01-17 1:11 ` David Gibson
2013-01-17 7:50 ` Markus Armbruster
2013-01-18 16:31 ` Alexander Graf
2013-01-18 17:03 ` Markus Armbruster
2013-01-20 20:53 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F4DA20.3020803@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.