From: Fernando Luis Vazquez Cao <fernando_b1@lab.ntt.co.jp>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: add support for Sony RF receiver with USB product id 0x0374
Date: Tue, 15 Jan 2013 19:03:50 +0900 [thread overview]
Message-ID: <50F52986.2080002@lab.ntt.co.jp> (raw)
In-Reply-To: <20130115103638.be566e39f0f5ad7186362dd8@studenti.unina.it>
Hi Antonio,
On 2013/01/15 18:36, Antonio Ospite wrote:
> On Tue, 15 Jan 2013 12:43:48 +0900 Fernando Luis Vázquez Cao <fernando_b1@lab.ntt.co.jp> wrote:
>> diff -urNp linux-3.8-rc3-orig/drivers/hid/hid-sony.c linux-3.8-rc3/drivers/hid/hid-sony.c
>> --- linux-3.8-rc3-orig/drivers/hid/hid-sony.c 2012-12-11 12:30:57.000000000 +0900
>> +++ linux-3.8-rc3/drivers/hid/hid-sony.c 2013-01-13 18:21:19.901347327 +0900
>> @@ -44,19 +44,21 @@ static __u8 *sony_report_fixup(struct hi
>> struct sony_sc *sc = hid_get_drvdata(hdev);
>>
>> if ((sc->quirks & VAIO_RDESC_CONSTANT) &&
>> - *rsize >= 56 && rdesc[54] == 0x81 && rdesc[55] == 0x07) {
>> - hid_info(hdev, "Fixing up Sony Vaio VGX report descriptor\n");
>> + *rsize >= 56 && rdesc[54] == 0x81 && rdesc[55] == 0x07) {
>> + hid_info(hdev,
>> + "Fixing up Sony RF Receiver report descriptor\n");
> Changing the message does make sense, but try to avoid mixing
> functional changes with style changes (I am referring to the change of
> indentation here).
Oops, that was unintended. I will be replying to this email with an
updated version.
Thanks,
Fernando
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Fernando Luis Vazquez Cao <fernando_b1@lab.ntt.co.jp>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: add support for Sony RF receiver with USB product id 0x0374
Date: Tue, 15 Jan 2013 19:03:50 +0900 [thread overview]
Message-ID: <50F52986.2080002@lab.ntt.co.jp> (raw)
In-Reply-To: <20130115103638.be566e39f0f5ad7186362dd8@studenti.unina.it>
Hi Antonio,
On 2013/01/15 18:36, Antonio Ospite wrote:
> On Tue, 15 Jan 2013 12:43:48 +0900 Fernando Luis Vázquez Cao <fernando_b1@lab.ntt.co.jp> wrote:
>> diff -urNp linux-3.8-rc3-orig/drivers/hid/hid-sony.c linux-3.8-rc3/drivers/hid/hid-sony.c
>> --- linux-3.8-rc3-orig/drivers/hid/hid-sony.c 2012-12-11 12:30:57.000000000 +0900
>> +++ linux-3.8-rc3/drivers/hid/hid-sony.c 2013-01-13 18:21:19.901347327 +0900
>> @@ -44,19 +44,21 @@ static __u8 *sony_report_fixup(struct hi
>> struct sony_sc *sc = hid_get_drvdata(hdev);
>>
>> if ((sc->quirks & VAIO_RDESC_CONSTANT) &&
>> - *rsize >= 56 && rdesc[54] == 0x81 && rdesc[55] == 0x07) {
>> - hid_info(hdev, "Fixing up Sony Vaio VGX report descriptor\n");
>> + *rsize >= 56 && rdesc[54] == 0x81 && rdesc[55] == 0x07) {
>> + hid_info(hdev,
>> + "Fixing up Sony RF Receiver report descriptor\n");
> Changing the message does make sense, but try to avoid mixing
> functional changes with style changes (I am referring to the change of
> indentation here).
Oops, that was unintended. I will be replying to this email with an
updated version.
Thanks,
Fernando
next prev parent reply other threads:[~2013-01-15 10:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 3:43 [PATCH] HID: add support for Sony RF receiver with USB product id 0x0374 Fernando Luis Vázquez Cao
2013-01-15 9:36 ` Antonio Ospite
2013-01-15 9:36 ` Antonio Ospite
2013-01-15 10:03 ` Fernando Luis Vazquez Cao [this message]
2013-01-15 10:03 ` Fernando Luis Vazquez Cao
2013-01-15 10:40 ` [PATCH v2] " Fernando Luis Vázquez Cao
2013-01-15 16:02 ` Jiri Kosina
2013-01-16 5:17 ` Fernando Luis Vazquez Cao
2013-01-16 5:17 ` Fernando Luis Vazquez Cao
2013-01-16 10:44 ` Jiri Kosina
[not found] ` <alpine.LNX.2.00.1301161141250.14768-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2013-01-22 5:57 ` Fernando Luis Vazquez Cao
2013-01-22 5:57 ` Fernando Luis Vazquez Cao
2013-01-22 6:20 ` HID: clean up quirk for Sony RF receivers Fernando Luis Vázquez Cao
2013-01-22 10:08 ` Jiri Kosina
2013-01-22 10:08 ` Jiri Kosina
2013-01-22 10:04 ` [PATCH v2] HID: add support for Sony RF receiver with USB product id 0x0374 Jiri Kosina
2013-05-01 0:25 ` Fernando Luis Vázquez Cao
2013-05-01 0:25 ` Fernando Luis Vázquez Cao
2013-05-01 0:26 ` [PATCH] HID: fix botched tree merge that disabled fix-up for certain Sony RF receivers Fernando Luis Vázquez Cao
2013-05-01 12:59 ` Jiri Kosina
2013-05-01 12:59 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F52986.2080002@lab.ntt.co.jp \
--to=fernando_b1@lab.ntt.co.jp \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ospite@studenti.unina.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.