From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/4] scsi-disk: qemu_vfree(NULL) is fine, simplify
Date: Tue, 15 Jan 2013 16:17:27 +0100 [thread overview]
Message-ID: <50F57307.5000408@redhat.com> (raw)
In-Reply-To: <1358256220-5460-3-git-send-email-armbru@redhat.com>
Il 15/01/2013 14:23, Markus Armbruster ha scritto:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/scsi-disk.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
> index f8d7ef3..96db9a7 100644
> --- a/hw/scsi-disk.c
> +++ b/hw/scsi-disk.c
> @@ -85,9 +85,7 @@ static void scsi_free_request(SCSIRequest *req)
> {
> SCSIDiskReq *r = DO_UPCAST(SCSIDiskReq, req, req);
>
> - if (r->iov.iov_base) {
> - qemu_vfree(r->iov.iov_base);
> - }
> + qemu_vfree(r->iov.iov_base);
> }
>
> /* Helper function for command completion with sense. */
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2013-01-15 15:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 13:23 [Qemu-devel] [PATCH 0/4] Fixes around qemu_vfree() Markus Armbruster
2013-01-15 13:23 ` [Qemu-devel] [PATCH 1/4] w32: Make qemu_vfree() accept NULL like the POSIX implementation Markus Armbruster
2013-01-15 13:23 ` [Qemu-devel] [PATCH 2/4] scsi-disk: qemu_vfree(NULL) is fine, simplify Markus Armbruster
2013-01-15 15:17 ` Paolo Bonzini [this message]
2013-01-15 13:23 ` [Qemu-devel] [PATCH 3/4] win32-aio: Fix how win32_aio_process_completion() frees buffer Markus Armbruster
2013-01-15 13:49 ` Kevin Wolf
2013-01-15 13:23 ` [Qemu-devel] [PATCH 4/4] block: Fix how mirror_run() frees its buffer Markus Armbruster
2013-01-15 13:52 ` Kevin Wolf
2013-01-15 14:20 ` Markus Armbruster
2013-01-15 15:20 ` Paolo Bonzini
2013-01-15 13:52 ` [Qemu-devel] [PATCH 0/4] Fixes around qemu_vfree() Kevin Wolf
2013-01-15 15:50 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F57307.5000408@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.