[PATCH] netbase: Fix file search path for 'interfaces'

[PATCH] netbase: Fix file search path for 'interfaces'

[Gary Thomas]

This .bbappend file is used to override the 'interfaces' file for
certain targets.  The current version is broken in that it does not
search the correct path(s).  This patch fixes that, as well as marking
the resulting package as target specific.

Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
 recipes-core/netbase/netbase_5.0.bbappend |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/recipes-core/netbase/netbase_5.0.bbappend b/recipes-core/netbase/netbase_5.0.bbappend
index 4b8d0e6..e5fa909 100644
--- a/recipes-core/netbase/netbase_5.0.bbappend
+++ b/recipes-core/netbase/netbase_5.0.bbappend
@@ -1,3 +1,2 @@
-THISDIR := "${@os.path.dirname(bb.data.getVar('FILE', d, True))}"
-FILESPATH =. "${@base_set_filespath(["${THISDIR}/${PN}"], d)}:"
-
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
+PACKAGE_ARCH = "${MACHINE_ARCH}"
-- 
1.7.7.6

Re: [PATCH] netbase: Fix file search path for 'interfaces'

[Denys Dmytriyenko]

On Sat, Dec 29, 2012 at 05:36:29AM -0700, Gary Thomas wrote:
> This .bbappend file is used to override the 'interfaces' file for
> certain targets.  The current version is broken in that it does not
> search the correct path(s).  This patch fixes that, as well as marking
> the resulting package as target specific.

Thanks. There was similar patch earlier, but w/o marking resulting package as 
machine specific. For that matter, shouldn't the main netbase recipe in 
oe-core do it instead? As it comes with bunch of qemu-arch-specific interfaces 
files anyway, and we just add one more for beagleboard...

-- 
Denys


> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
> ---
>  recipes-core/netbase/netbase_5.0.bbappend |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/recipes-core/netbase/netbase_5.0.bbappend b/recipes-core/netbase/netbase_5.0.bbappend
> index 4b8d0e6..e5fa909 100644
> --- a/recipes-core/netbase/netbase_5.0.bbappend
> +++ b/recipes-core/netbase/netbase_5.0.bbappend
> @@ -1,3 +1,2 @@
> -THISDIR := "${@os.path.dirname(bb.data.getVar('FILE', d, True))}"
> -FILESPATH =. "${@base_set_filespath(["${THISDIR}/${PN}"], d)}:"
> -
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> -- 
> 1.7.7.6
> 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
> 

Re: [PATCH] netbase: Fix file search path for 'interfaces'

[Gary Thomas]

On 2013-01-14 16:31, Denys Dmytriyenko wrote:
> On Sat, Dec 29, 2012 at 05:36:29AM -0700, Gary Thomas wrote:
>> This .bbappend file is used to override the 'interfaces' file for
>> certain targets.  The current version is broken in that it does not
>> search the correct path(s).  This patch fixes that, as well as marking
>> the resulting package as target specific.
>
> Thanks. There was similar patch earlier, but w/o marking resulting package as
> machine specific. For that matter, shouldn't the main netbase recipe in
> oe-core do it instead? As it comes with bunch of qemu-arch-specific interfaces
> files anyway, and we just add one more for beagleboard...
>

Agreed.  When I get two minutes, I'll propose a new patch for meta-ti
for this as well as one for OE-core.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [PATCH] netbase: Fix file search path for 'interfaces'

[Denys Dmytriyenko]

On Wed, Jan 16, 2013 at 07:55:26AM -0700, Gary Thomas wrote:
> On 2013-01-14 16:31, Denys Dmytriyenko wrote:
> >On Sat, Dec 29, 2012 at 05:36:29AM -0700, Gary Thomas wrote:
> >>This .bbappend file is used to override the 'interfaces' file for
> >>certain targets.  The current version is broken in that it does not
> >>search the correct path(s).  This patch fixes that, as well as marking
> >>the resulting package as target specific.
> >
> >Thanks. There was similar patch earlier, but w/o marking resulting package as
> >machine specific. For that matter, shouldn't the main netbase recipe in
> >oe-core do it instead? As it comes with bunch of qemu-arch-specific interfaces
> >files anyway, and we just add one more for beagleboard...
> >
> 
> Agreed.  When I get two minutes, I'll propose a new patch for meta-ti
> for this as well as one for OE-core.

Actually, there is no need for an explicit PACKAGE_ARCH = MACHINE_ARCH neither 
in bbappend nor in the main recipe in oe-core - bitbake does it automatically 
when it detects machine-overriden files being packaged.

-- 
Denys

Re: [PATCH] netbase: Fix file search path for 'interfaces'

[Gary Thomas]

On 2013-01-16 11:10, Denys Dmytriyenko wrote:
> On Wed, Jan 16, 2013 at 07:55:26AM -0700, Gary Thomas wrote:
>> On 2013-01-14 16:31, Denys Dmytriyenko wrote:
>>> On Sat, Dec 29, 2012 at 05:36:29AM -0700, Gary Thomas wrote:
>>>> This .bbappend file is used to override the 'interfaces' file for
>>>> certain targets.  The current version is broken in that it does not
>>>> search the correct path(s).  This patch fixes that, as well as marking
>>>> the resulting package as target specific.
>>>
>>> Thanks. There was similar patch earlier, but w/o marking resulting package as
>>> machine specific. For that matter, shouldn't the main netbase recipe in
>>> oe-core do it instead? As it comes with bunch of qemu-arch-specific interfaces
>>> files anyway, and we just add one more for beagleboard...
>>>
>>
>> Agreed.  When I get two minutes, I'll propose a new patch for meta-ti
>> for this as well as one for OE-core.
>
> Actually, there is no need for an explicit PACKAGE_ARCH = MACHINE_ARCH neither
> in bbappend nor in the main recipe in oe-core - bitbake does it automatically
> when it detects machine-overriden files being packaged.

Cool, I hadn't noticed that.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------