From: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH 6/6] cgroup: remove bogus comments in cgroup_diput()
Date: Thu, 17 Jan 2013 16:05:09 +0800 [thread overview]
Message-ID: <50F7B0B5.9050207@huawei.com> (raw)
In-Reply-To: <50F7B040.2020906-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Since commit 48ddbe194623ae089cc0576e60363f2d2e85662a
("cgroup: make css->refcnt clearing on cgroup removal optional"),
each css holds a ref on cgroup's dentry, so cgroup_diput() won't be
called until all css' refs go down to 0, which invalids the comments.
Signed-off-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
kernel/cgroup.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 83ac78b..77ab520 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -899,12 +899,6 @@ static void cgroup_diput(struct dentry *dentry, struct inode *inode)
struct cgroup *cgrp = dentry->d_fsdata;
BUG_ON(!(cgroup_is_removed(cgrp)));
- /* It's possible for external users to be holding css
- * reference counts on a cgroup; css_put() needs to
- * be able to access the cgroup after decrementing
- * the reference count in order to know if it needs to
- * queue the cgroup to be handled by the release
- * agent */
call_rcu(&cgrp->rcu_head, cgroup_free_rcu);
} else {
struct cfent *cfe = __d_cfe(dentry);
--
1.8.0.2
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>
Subject: [PATCH 6/6] cgroup: remove bogus comments in cgroup_diput()
Date: Thu, 17 Jan 2013 16:05:09 +0800 [thread overview]
Message-ID: <50F7B0B5.9050207@huawei.com> (raw)
In-Reply-To: <50F7B040.2020906@huawei.com>
Since commit 48ddbe194623ae089cc0576e60363f2d2e85662a
("cgroup: make css->refcnt clearing on cgroup removal optional"),
each css holds a ref on cgroup's dentry, so cgroup_diput() won't be
called until all css' refs go down to 0, which invalids the comments.
Signed-off-by: Li Zefan <lizefan@huawei.com>
---
kernel/cgroup.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 83ac78b..77ab520 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -899,12 +899,6 @@ static void cgroup_diput(struct dentry *dentry, struct inode *inode)
struct cgroup *cgrp = dentry->d_fsdata;
BUG_ON(!(cgroup_is_removed(cgrp)));
- /* It's possible for external users to be holding css
- * reference counts on a cgroup; css_put() needs to
- * be able to access the cgroup after decrementing
- * the reference count in order to know if it needs to
- * queue the cgroup to be handled by the release
- * agent */
call_rcu(&cgrp->rcu_head, cgroup_free_rcu);
} else {
struct cfent *cfe = __d_cfe(dentry);
--
1.8.0.2
next prev parent reply other threads:[~2013-01-17 8:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 8:03 [PATCH 1/6] cgroup: initialize cgrp->dentry before css_alloc() Li Zefan
2013-01-17 8:03 ` Li Zefan
2013-01-17 8:03 ` [PATCH 2/6] sched: split out tg creation/destruction to css_online/css_offline Li Zefan
2013-01-17 8:04 ` [PATCH 4/6] cgroup: remove duplicate RCU free on struct cgroup Li Zefan
2013-01-17 8:04 ` [PATCH 5/6] cgroup: remove synchronize_rcu() from cgroup_diput() Li Zefan
[not found] ` <50F7B040.2020906-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-01-17 8:03 ` [PATCH 3/6] sched: remove redundant NULL cgroup check in task_group_path() Li Zefan
2013-01-17 8:03 ` Li Zefan
2013-01-17 8:05 ` Li Zefan [this message]
2013-01-17 8:05 ` [PATCH 6/6] cgroup: remove bogus comments in cgroup_diput() Li Zefan
2013-01-23 0:27 ` [PATCH 1/6] cgroup: initialize cgrp->dentry before css_alloc() Tejun Heo
2013-01-23 0:27 ` Tejun Heo
[not found] ` <20130123002754.GB5359-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-01-23 0:35 ` Andrew Morton
2013-01-23 0:35 ` Andrew Morton
2013-01-23 2:34 ` Li Zefan
2013-01-23 2:34 ` Li Zefan
[not found] ` <50FF4C4D.4020405-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-01-23 16:35 ` Tejun Heo
2013-01-23 16:35 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F7B0B5.9050207@huawei.com \
--to=lizefan-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.