All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] win32-aio fixes
Date: Thu, 17 Jan 2013 11:53:28 +0100	[thread overview]
Message-ID: <50F7D828.7090302@redhat.com> (raw)
In-Reply-To: <1358367600-8074-1-git-send-email-kwolf@redhat.com>

Il 16/01/2013 21:19, Kevin Wolf ha scritto:
> Paolo, especially the first one is worrying with respect to the test status of
> this code. We should probably give it some additional testing.
> 
> Kevin Wolf (2):
>   win32-aio: Fix vectored reads
>   win32-aio: Fix memory leak
> 
>  block/win32-aio.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 

Yes, the worrying part is especially that IIUC qtest does not support
Windows.  There's no way to get good coverage without qtest.

Paolo

  parent reply	other threads:[~2013-01-17 12:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-16 20:19 [Qemu-devel] [PATCH 0/2] win32-aio fixes Kevin Wolf
2013-01-16 20:19 ` [Qemu-devel] [PATCH 1/2] win32-aio: Fix vectored reads Kevin Wolf
2013-01-17  8:33   ` [Qemu-devel] [Qemu-stable] " Michael Tokarev
2013-01-17  8:43     ` Kevin Wolf
2013-01-16 20:20 ` [Qemu-devel] [PATCH 2/2] win32-aio: Fix memory leak Kevin Wolf
2013-01-17  9:59 ` [Qemu-devel] [PATCH 0/2] win32-aio fixes Stefan Hajnoczi
2013-01-17 10:53 ` Paolo Bonzini [this message]
2013-01-17 11:35   ` Kevin Wolf
2013-01-17 11:37     ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2013-01-16 20:19 Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F7D828.7090302@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.