Re: [Qemu-devel] [Qemu-stable] [PATCH 1/2] win32-aio: Fix vectored reads

[Michael Tokarev <mjt@tls.msk.ru>]

17.01.2013 00:19, Kevin Wolf пишет:
> Copying data in the right direction really helps a lot!
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   block/win32-aio.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/block/win32-aio.c b/block/win32-aio.c
> index 46a5db7..53b82e6 100644
> --- a/block/win32-aio.c
> +++ b/block/win32-aio.c
> @@ -84,7 +84,7 @@ static void win32_aio_process_completion(QEMUWin32AIOState *s,
>               int i;
>
>               for (i = 0; i < qiov->niov; ++i) {
> -                memcpy(p, qiov->iov[i].iov_base, qiov->iov[i].iov_len);
> +                memcpy(qiov->iov[i].iov_base, p, qiov->iov[i].iov_len);
>                   p += qiov->iov[i].iov_len;
>               }
>               g_free(waiocb->buf);

Actually this is just

    iov_from_buf(qiov->iov, qiov->niov, 0, waiocb->buf, -1);

Or is it iov_to_buf() ? :)

Thanks,

/mjt