From: rogerq@ti.com (Roger Quadros)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 15/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode
Date: Thu, 17 Jan 2013 14:45:16 +0200 [thread overview]
Message-ID: <50F7F25C.3060909@ti.com> (raw)
In-Reply-To: <20130117122757.GO18978@arwen.pp.htv.fi>
On 01/17/2013 02:27 PM, Felipe Balbi wrote:
> On Thu, Jan 17, 2013 at 02:10:18PM +0200, Roger Quadros wrote:
>> On 01/17/2013 01:45 PM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Thu, Jan 17, 2013 at 01:30:24PM +0200, Roger Quadros wrote:
>>>> @@ -598,6 +639,24 @@ static int usbhs_omap_probe(struct platform_device *pdev)
>>>> clkname, PTR_ERR(pclk));
>>>> else
>>>> omap->utmi_clk[i] = pclk;
>>>> +
>>>> + snprintf(clkname, sizeof(clkname),
>>>> + "usb_host_hs_hsic480m_p%d_clk", i + 1);
>>>
>>> do we really need to know the exact clock node name ?
>>>
>> I think so. Do you have a better suggestion?
>
> update CLKDEV entries ? I mean, what if we have a new OMAP or AMxxxx
> device with a different clock name ? That will be a big bummer.
>
In that case we simply need to add the relevant CLKDEV entries/aliases
for the new platform. I don't think anything needs to be changed in the
driver. We are still using clk_get(dev, clk_name), so the CLKDEV
framework will return the best matching clock for the device.
--
cheers,
-roger
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: <balbi@ti.com>
Cc: <sameo@linux.intel.com>, <tony@atomide.com>, <kishon@ti.com>,
<sshtylyov@mvista.com>, <bjorn@mork.no>, <linux@arm.linux.org.uk>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v7 15/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode
Date: Thu, 17 Jan 2013 14:45:16 +0200 [thread overview]
Message-ID: <50F7F25C.3060909@ti.com> (raw)
In-Reply-To: <20130117122757.GO18978@arwen.pp.htv.fi>
On 01/17/2013 02:27 PM, Felipe Balbi wrote:
> On Thu, Jan 17, 2013 at 02:10:18PM +0200, Roger Quadros wrote:
>> On 01/17/2013 01:45 PM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Thu, Jan 17, 2013 at 01:30:24PM +0200, Roger Quadros wrote:
>>>> @@ -598,6 +639,24 @@ static int usbhs_omap_probe(struct platform_device *pdev)
>>>> clkname, PTR_ERR(pclk));
>>>> else
>>>> omap->utmi_clk[i] = pclk;
>>>> +
>>>> + snprintf(clkname, sizeof(clkname),
>>>> + "usb_host_hs_hsic480m_p%d_clk", i + 1);
>>>
>>> do we really need to know the exact clock node name ?
>>>
>> I think so. Do you have a better suggestion?
>
> update CLKDEV entries ? I mean, what if we have a new OMAP or AMxxxx
> device with a different clock name ? That will be a big bummer.
>
In that case we simply need to add the relevant CLKDEV entries/aliases
for the new platform. I don't think anything needs to be changed in the
driver. We are still using clk_get(dev, clk_name), so the CLKDEV
framework will return the best matching clock for the device.
--
cheers,
-roger
next prev parent reply other threads:[~2013-01-17 12:45 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 11:30 [PATCH v7 00/22] OMAP USB Host cleanup Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 01/22] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 15:16 ` Alan Stern
2013-01-17 15:16 ` Alan Stern
2013-01-17 16:59 ` Tony Lindgren
2013-01-17 16:59 ` Tony Lindgren
2013-01-18 9:45 ` Roger Quadros
2013-01-18 9:45 ` Roger Quadros
2013-02-11 6:46 ` Olof Johansson
2013-02-11 6:46 ` Olof Johansson
2013-02-11 7:58 ` Roger Quadros
2013-02-11 7:58 ` Roger Quadros
2013-02-11 19:02 ` Tony Lindgren
2013-02-11 19:02 ` Tony Lindgren
2013-01-17 11:30 ` [PATCH v7 02/22] mfd: omap-usb-tll: Fix channel count detection Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 03/22] mfd: omap-usb-tll: Use devm_kzalloc/ioremap and clean up error path Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 04/22] mfd: omap-usb-tll: Clean up clock handling Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 05/22] mfd: omap-usb-tll: introduce and use mode_needs_tll() Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 06/22] mfd: omap-usb-tll: Check for missing platform data in probe Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 07/22] mfd: omap-usb-tll: Fix error message Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 08/22] mfd: omap-usb-tll: serialize access to TLL device Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 09/22] mfd: omap-usb-tll: Add OMAP5 revision and HSIC support Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 10/22] mfd: omap_usb_host: Avoid missing platform data checks in suspend/resume Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 11/22] mfd: omap-usb-host: Use devm_kzalloc() and devm_request_and_ioremap() Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 12/22] mfd: omap-usb-host: know about number of ports from revision register Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 13/22] mfd: omap-usb-host: override number of ports from platform data Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 14/22] mfd: omap-usb-host: cleanup clock management code Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:44 ` Felipe Balbi
2013-01-17 11:44 ` Felipe Balbi
2013-01-17 12:07 ` Roger Quadros
2013-01-17 12:07 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 15/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:45 ` Felipe Balbi
2013-01-17 11:45 ` Felipe Balbi
2013-01-17 12:10 ` Roger Quadros
2013-01-17 12:10 ` Roger Quadros
2013-01-17 12:27 ` Felipe Balbi
2013-01-17 12:27 ` Felipe Balbi
2013-01-17 12:45 ` Roger Quadros [this message]
2013-01-17 12:45 ` Roger Quadros
2013-01-17 12:48 ` Felipe Balbi
2013-01-17 12:48 ` Felipe Balbi
2013-01-17 11:30 ` [PATCH v7 16/22] mfd: omap-usb-host: Get rid of unnecessary spinlock Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 17/22] mfd: omap-usb-host: clean up omap_usbhs_init() Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:48 ` Felipe Balbi
2013-01-17 11:48 ` Felipe Balbi
2013-01-17 12:13 ` Roger Quadros
2013-01-17 12:13 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 18/22] USB: ehci-omap: Don't free gpios that we didn't request Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:48 ` Felipe Balbi
2013-01-17 11:48 ` Felipe Balbi
2013-01-17 12:46 ` Roger Quadros
2013-01-17 12:46 ` Roger Quadros
2013-01-17 15:15 ` Alan Stern
2013-01-17 15:15 ` Alan Stern
2013-01-17 11:30 ` [PATCH v7 19/22] ARM: OMAP3: clock data: get rid of unused USB host clock aliases and dummies Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 17:03 ` Tony Lindgren
2013-01-17 17:03 ` Tony Lindgren
2013-01-17 19:00 ` Paul Walmsley
2013-01-17 19:00 ` Paul Walmsley
2013-01-17 21:00 ` Felipe Balbi
2013-01-17 21:00 ` Felipe Balbi
2013-01-17 22:29 ` Paul Walmsley
2013-01-17 22:29 ` Paul Walmsley
2013-01-17 22:31 ` Tony Lindgren
2013-01-17 22:31 ` Tony Lindgren
2013-01-17 22:38 ` Paul Walmsley
2013-01-17 22:38 ` Paul Walmsley
2013-01-17 22:32 ` Felipe Balbi
2013-01-17 22:32 ` Felipe Balbi
2013-01-17 11:30 ` [PATCH v7 20/22] ARM: OMAP4: clock data: get rid of unused USB host clock aliases Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 21/22] mfd: omap-usb-host: Don't spam console on clk_set_parent failure Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:30 ` [PATCH v7 22/22] mdf: omap-usb-host: get rid of build warning Roger Quadros
2013-01-17 11:30 ` Roger Quadros
2013-01-17 11:50 ` Felipe Balbi
2013-01-17 11:50 ` Felipe Balbi
2013-01-17 13:30 ` Roger Quadros
2013-01-17 13:30 ` Roger Quadros
2013-01-17 11:52 ` [PATCH v7 00/22] OMAP USB Host cleanup Felipe Balbi
2013-01-17 11:52 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F7F25C.3060909@ti.com \
--to=rogerq@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.