From: Josh Durgin <josh.durgin@inktank.com>
To: Alex Elder <elder@inktank.com>
Cc: ceph-devel <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH] rbd: fix type of snap_id in rbd_dev_v2_snap_info()
Date: Thu, 17 Jan 2013 09:41:36 -0800 [thread overview]
Message-ID: <50F837D0.1020800@inktank.com> (raw)
In-Reply-To: <50F0D5B2.2090904@inktank.com>
On 01/11/2013 07:17 PM, Alex Elder wrote:
> The type of the snap_id local variable is defined with the
> wrong byte order. Fix that.
>
> Signed-off-by: Alex Elder <elder@inktank.com>
> ---
Oops, I missed that too.
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
> drivers/block/rbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 02002b1..47443eb 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -2800,7 +2800,7 @@ out:
> static char *rbd_dev_v2_snap_info(struct rbd_device *rbd_dev, u32 which,
> u64 *snap_size, u64 *snap_features)
> {
> - __le64 snap_id;
> + u64 snap_id;
> u8 order;
> int ret;
>
prev parent reply other threads:[~2013-01-17 17:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 3:17 [PATCH] rbd: fix type of snap_id in rbd_dev_v2_snap_info() Alex Elder
2013-01-17 17:41 ` Josh Durgin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F837D0.1020800@inktank.com \
--to=josh.durgin@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=elder@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.