* [PATCH] rbd: fix type of snap_id in rbd_dev_v2_snap_info()
@ 2013-01-12 3:17 Alex Elder
2013-01-17 17:41 ` Josh Durgin
0 siblings, 1 reply; 2+ messages in thread
From: Alex Elder @ 2013-01-12 3:17 UTC (permalink / raw)
To: ceph-devel
The type of the snap_id local variable is defined with the
wrong byte order. Fix that.
Signed-off-by: Alex Elder <elder@inktank.com>
---
drivers/block/rbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 02002b1..47443eb 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -2800,7 +2800,7 @@ out:
static char *rbd_dev_v2_snap_info(struct rbd_device *rbd_dev, u32 which,
u64 *snap_size, u64 *snap_features)
{
- __le64 snap_id;
+ u64 snap_id;
u8 order;
int ret;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rbd: fix type of snap_id in rbd_dev_v2_snap_info()
2013-01-12 3:17 [PATCH] rbd: fix type of snap_id in rbd_dev_v2_snap_info() Alex Elder
@ 2013-01-17 17:41 ` Josh Durgin
0 siblings, 0 replies; 2+ messages in thread
From: Josh Durgin @ 2013-01-17 17:41 UTC (permalink / raw)
To: Alex Elder; +Cc: ceph-devel
On 01/11/2013 07:17 PM, Alex Elder wrote:
> The type of the snap_id local variable is defined with the
> wrong byte order. Fix that.
>
> Signed-off-by: Alex Elder <elder@inktank.com>
> ---
Oops, I missed that too.
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
> drivers/block/rbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 02002b1..47443eb 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -2800,7 +2800,7 @@ out:
> static char *rbd_dev_v2_snap_info(struct rbd_device *rbd_dev, u32 which,
> u64 *snap_size, u64 *snap_features)
> {
> - __le64 snap_id;
> + u64 snap_id;
> u8 order;
> int ret;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-17 17:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-12 3:17 [PATCH] rbd: fix type of snap_id in rbd_dev_v2_snap_info() Alex Elder
2013-01-17 17:41 ` Josh Durgin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.