From: Eric Blake <eblake@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Chegu Vinod <chegu_vinod@hp.com>,
Laszlo Ersek <lersek@redhat.com>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions
Date: Thu, 17 Jan 2013 12:55:57 -0700 [thread overview]
Message-ID: <50F8574D.401@redhat.com> (raw)
In-Reply-To: <1358449610-16466-1-git-send-email-ehabkost@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
On 01/17/2013 12:06 PM, Eduardo Habkost wrote:
> There are lots of duplicate parsing code using strto*() in QEMU, and
> most of that code is broken in one way or another. Even the visitors
> code have duplicate integer parsing code[1]. This introduces functions
> to help parsing unsigned int values: parse_uint() and parse_uint_full().
>
> Parsing functions for signed ints and floats will be submitted later.
>
>
> Changes v4:
> - Return -EINVAL in case a minus sign is found
> - Make endptr point to beginning of string in case -EINVAL
> is returned (like the strtoull() behavior)
>
> v3->v4 interdiff:
Thanks; that helped review.
The rest of the series needs no modifications to enjoy the improvements
of this v4 patch.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-01-17 19:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 18:28 [Qemu-devel] [PATCH 0/8] -numa option parsing fixes (v3) Eduardo Habkost
2013-01-16 18:28 ` [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions Eduardo Habkost
2013-01-17 18:29 ` Laszlo Ersek
2013-01-17 18:50 ` Eduardo Habkost
2013-01-17 19:06 ` [Qemu-devel] [PATCH 1/8 v4] " Eduardo Habkost
2013-01-17 19:25 ` Eduardo Habkost
2013-01-17 19:31 ` Laszlo Ersek
2013-01-17 19:55 ` Eric Blake [this message]
2013-01-17 21:04 ` Blue Swirl
2013-01-18 10:01 ` [Qemu-devel] [PATCH 1/8] " Markus Armbruster
2013-01-18 13:26 ` Eduardo Habkost
2013-01-18 13:32 ` Andreas Färber
2013-01-18 17:57 ` [Qemu-devel] [PATCH 1/8 v5] " Eduardo Habkost
2013-01-18 18:11 ` Eric Blake
2013-01-18 19:41 ` [Qemu-devel] [PATCH 1/8 v6] " Eduardo Habkost
2013-01-18 20:20 ` Eric Blake
2013-01-18 18:06 ` [Qemu-devel] [PATCH 1/8] " Markus Armbruster
2013-01-16 18:28 ` [Qemu-devel] [PATCH 2/8] vl.c: Fix off-by-one bug when handling "-numa node" argument Eduardo Habkost
2013-01-16 18:28 ` [Qemu-devel] [PATCH 3/8] vl.c: Abort on unknown -numa option type Eduardo Habkost
2013-01-16 18:28 ` [Qemu-devel] [PATCH 4/8] vl.c: Check for NUMA node limit inside numa_add() Eduardo Habkost
2013-01-16 18:28 ` [Qemu-devel] [PATCH 5/8] vl.c: numa_add(): Validate nodeid before using it Eduardo Habkost
2013-01-16 18:28 ` [Qemu-devel] [PATCH 6/8] vl.c: Use parse_uint_full() for NUMA nodeid Eduardo Habkost
2013-01-16 18:28 ` [Qemu-devel] [PATCH 7/8] vl.c: Extract -numa "cpus" parsing to separate function Eduardo Habkost
2013-01-16 18:28 ` [Qemu-devel] [PATCH 8/8] vl.c: validate -numa "cpus" parameter properly Eduardo Habkost
2013-01-16 20:07 ` [Qemu-devel] [PATCH 0/8] -numa option parsing fixes (v3) Eric Blake
[not found] ` <20130128165559.GA6849@otherpad.lan.raisama.net>
[not found] ` <20130131154227.GH6849@otherpad.lan.raisama.net>
2013-02-01 20:45 ` [Qemu-devel] [PATCH for-1.4 " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F8574D.401@redhat.com \
--to=eblake@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=chegu_vinod@hp.com \
--cc=ehabkost@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.