[meta-fsl-arm][PATCH v2] linux-imx_3.0.35: Support Single Pointer into the eGalax Touchscreen Driver

[meta-fsl-arm][PATCH v2] linux-imx_3.0.35: Support Single Pointer into the eGalax Touchscreen Driver

[Leonardo Sandoval]

This patch enables the touchscreen functionality on i.MX6 Sabre Platforms using the
eGalax Driver.

[YOCTO #3573]

Upstream-Status: Submitted [meta-freescale@yoctoproject.org]

Changed since v1:
- Included Upstream-Status as Otavio suggestion

Signed-off-by: Leonardo Sandoval <leonardo.sandoval@freescale.com>
---
 .../egalax_ts-Add-Single-Pointer-Support.patch     |   24 ++++++++++++++++++++
 recipes-kernel/linux/linux-imx_3.0.35.bb           |    3 ++-
 2 files changed, 26 insertions(+), 1 deletion(-)
 create mode 100644 recipes-kernel/linux/linux-imx/egalax_ts-Add-Single-Pointer-Support.patch

diff --git a/recipes-kernel/linux/linux-imx/egalax_ts-Add-Single-Pointer-Support.patch b/recipes-kernel/linux/linux-imx/egalax_ts-Add-Single-Pointer-Support.patch
new file mode 100644
index 0000000..479f6a8
--- /dev/null
+++ b/recipes-kernel/linux/linux-imx/egalax_ts-Add-Single-Pointer-Support.patch
@@ -0,0 +1,24 @@
+From 8c2ff5df3b585b20547fad98f072e32340444183 Mon Sep 17 00:00:00 2001
+From: Leonardo Sandoval <leonardo.sandoval@freescale.com>
+Date: Wed, 16 Jan 2013 14:48:10 -0600
+Subject: [PATCH] egalax_ts: Add Single Pointer Support
+
+---
+ drivers/input/touchscreen/egalax_ts.c |    1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/drivers/input/touchscreen/egalax_ts.c b/drivers/input/touchscreen/egalax_ts.c
+index fff8afe..a542d0a 100644
+--- a/drivers/input/touchscreen/egalax_ts.c
++++ b/drivers/input/touchscreen/egalax_ts.c
+@@ -56,6 +56,7 @@
+ #define EVENT_DOWN_UP		(0X1 << 0)
+ 
+ #define MAX_I2C_DATA_LEN	10
++#define FORCE_SINGLE_POINTER_SUPPORT
+ 
+ struct egalax_pointer {
+ 	bool valid;
+-- 
+1.7.9.5
+
diff --git a/recipes-kernel/linux/linux-imx_3.0.35.bb b/recipes-kernel/linux/linux-imx_3.0.35.bb
index 9f1e320..a99b209 100644
--- a/recipes-kernel/linux/linux-imx_3.0.35.bb
+++ b/recipes-kernel/linux/linux-imx_3.0.35.bb
@@ -3,7 +3,7 @@
 
 include linux-imx.inc
 
-PR = "${INC_PR}.7"
+PR = "${INC_PR}.8"
 
 COMPATIBLE_MACHINE = "(mx6)"
 
@@ -12,6 +12,7 @@ SRCREV = "059685632ebd37a89e60cbb1e6dd535b3b08c3be"
 LOCALVERSION = "-12.09.01+yocto"
 
 SRC_URI += "file://fix_getrusage_for_perf.patch \
+            file://egalax_ts-Add-Single-Pointer-Support.patch \
            "
 
 # iMX6Q SabreLITE changes done by Boundary Devices
-- 
1.7.9.5

Re: [meta-fsl-arm][PATCH v2] linux-imx_3.0.35: Support Single Pointer into the eGalax Touchscreen Driver

[Daiane Angolini]

On Thu, Jan 17, 2013 at 7:47 PM, Leonardo Sandoval
<leonardo.sandoval@freescale.com> wrote:
> This patch enables the touchscreen functionality on i.MX6 Sabre Platforms using the
> eGalax Driver.
>
> [YOCTO #3573]
>
> Upstream-Status: Submitted [meta-freescale@yoctoproject.org]
>
> Changed since v1:
> - Included Upstream-Status as Otavio suggestion
>
> Signed-off-by: Leonardo Sandoval <leonardo.sandoval@freescale.com>
> ---

Your V2 is very nice!


Could you, please, share which board you tested?


Daiane

Re: [meta-fsl-arm][PATCH v2] linux-imx_3.0.35: Support Single Pointer into the eGalax Touchscreen Driver

[Otavio Salvador]

On Thu, Jan 17, 2013 at 7:47 PM, Leonardo Sandoval
<leonardo.sandoval@freescale.com> wrote:
> This patch enables the touchscreen functionality on i.MX6 Sabre Platforms using the
> eGalax Driver.
>
> [YOCTO #3573]
>
> Upstream-Status: Submitted [meta-freescale@yoctoproject.org]

This should be in the patch file you, as it is the status of the
patch. The upstram status is regarding to FSL BSP so the value would
be 'Pending' until we send it for review.

> Changed since v1:
> - Included Upstream-Status as Otavio suggestion

This needs to be below to '---' or it would be included in the final commit log.

> Signed-off-by: Leonardo Sandoval <leonardo.sandoval@freescale.com>
> ---
>  .../egalax_ts-Add-Single-Pointer-Support.patch     |   24 ++++++++++++++++++++
>  recipes-kernel/linux/linux-imx_3.0.35.bb           |    3 ++-
>  2 files changed, 26 insertions(+), 1 deletion(-)
>  create mode 100644 recipes-kernel/linux/linux-imx/egalax_ts-Add-Single-Pointer-Support.patch
>
> diff --git a/recipes-kernel/linux/linux-imx/egalax_ts-Add-Single-Pointer-Support.patch b/recipes-kernel/linux/linux-imx/egalax_ts-Add-Single-Pointer-Support.patch
> new file mode 100644
> index 0000000..479f6a8
> --- /dev/null
> +++ b/recipes-kernel/linux/linux-imx/egalax_ts-Add-Single-Pointer-Support.patch
> @@ -0,0 +1,24 @@
> +From 8c2ff5df3b585b20547fad98f072e32340444183 Mon Sep 17 00:00:00 2001
> +From: Leonardo Sandoval <leonardo.sandoval@freescale.com>
> +Date: Wed, 16 Jan 2013 14:48:10 -0600
> +Subject: [PATCH] egalax_ts: Add Single Pointer Support
> +
> +---
> + drivers/input/touchscreen/egalax_ts.c |    1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/drivers/input/touchscreen/egalax_ts.c b/drivers/input/touchscreen/egalax_ts.c
> +index fff8afe..a542d0a 100644
> +--- a/drivers/input/touchscreen/egalax_ts.c
> ++++ b/drivers/input/touchscreen/egalax_ts.c
> +@@ -56,6 +56,7 @@
> + #define EVENT_DOWN_UP         (0X1 << 0)
> +
> + #define MAX_I2C_DATA_LEN      10
> ++#define FORCE_SINGLE_POINTER_SUPPORT
> +
> + struct egalax_pointer {
> +       bool valid;
> +--
> +1.7.9.5
> +
> diff --git a/recipes-kernel/linux/linux-imx_3.0.35.bb b/recipes-kernel/linux/linux-imx_3.0.35.bb
> index 9f1e320..a99b209 100644
> --- a/recipes-kernel/linux/linux-imx_3.0.35.bb
> +++ b/recipes-kernel/linux/linux-imx_3.0.35.bb
> @@ -3,7 +3,7 @@
>
>  include linux-imx.inc
>
> -PR = "${INC_PR}.7"
> +PR = "${INC_PR}.8"
>
>  COMPATIBLE_MACHINE = "(mx6)"
>
> @@ -12,6 +12,7 @@ SRCREV = "059685632ebd37a89e60cbb1e6dd535b3b08c3be"
>  LOCALVERSION = "-12.09.01+yocto"
>
>  SRC_URI += "file://fix_getrusage_for_perf.patch \
> +            file://egalax_ts-Add-Single-Pointer-Support.patch \
>             "
>
>  # iMX6Q SabreLITE changes done by Boundary Devices
> --
> 1.7.9.5
>
>
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale



--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [meta-fsl-arm][PATCH v2] linux-imx_3.0.35: Support Single Pointer into the eGalax Touchscreen Driver

[Eric Nelson]

On 01/18/2013 03:23 AM, Daiane Angolini wrote:
> On Thu, Jan 17, 2013 at 7:47 PM, Leonardo Sandoval
> <leonardo.sandoval@freescale.com> wrote:
>> This patch enables the touchscreen functionality on i.MX6 Sabre Platforms using the
>> eGalax Driver.
>>
>> [YOCTO #3573]
>>
>> Upstream-Status: Submitted [meta-freescale@yoctoproject.org]
>>
>> Changed since v1:
>> - Included Upstream-Status as Otavio suggestion
>>
>> Signed-off-by: Leonardo Sandoval <leonardo.sandoval@freescale.com>
>> ---
>
> Your V2 is very nice!
>
> Could you, please, share which board you tested?
>

I can confirm by inspection that this works. We've tested single-touch
support on all of our i.MX6 boards and Leonardo's patch just adds the
macro definition to enable it.

I would recommend to the Freescale team that this should really be a
Kconfig switch as done here:
	https://github.com/boundarydevices/linux-imx6/commit/f6b560538edca833481c1d67ecf3cfe2d65c4018

Then the userspace can select based on the configuration file, so
a multi-touch enabled userspace can select that feature. I'm sure
that Yocto will contain support for multi-touch userspaces if it
doesn't already.

Regards,


Eric

Re: [meta-fsl-arm][PATCH v2] linux-imx_3.0.35: Support Single Pointer into the eGalax Touchscreen Driver

[Otavio Salvador]

Hello Eric and Leonardo,

On Fri, Jan 18, 2013 at 12:27 PM, Eric Nelson
<eric.nelson@boundarydevices.com> wrote:
> On 01/18/2013 03:23 AM, Daiane Angolini wrote:
>>
>> On Thu, Jan 17, 2013 at 7:47 PM, Leonardo Sandoval
>> <leonardo.sandoval@freescale.com> wrote:
>>>
>>> This patch enables the touchscreen functionality on i.MX6 Sabre Platforms
>>> using the
>>> eGalax Driver.
>>>
>>> [YOCTO #3573]
>>>
>>> Upstream-Status: Submitted [meta-freescale@yoctoproject.org]
>>>
>>> Changed since v1:
>>> - Included Upstream-Status as Otavio suggestion
>>>
>>> Signed-off-by: Leonardo Sandoval <leonardo.sandoval@freescale.com>
>>> ---
>>
>>
>> Your V2 is very nice!
>>
>> Could you, please, share which board you tested?
>>
>
> I can confirm by inspection that this works. We've tested single-touch
> support on all of our i.MX6 boards and Leonardo's patch just adds the
> macro definition to enable it.
>
> I would recommend to the Freescale team that this should really be a
> Kconfig switch as done here:
>
> https://github.com/boundarydevices/linux-imx6/commit/f6b560538edca833481c1d67ecf3cfe2d65c4018
>
> Then the userspace can select based on the configuration file, so
> a multi-touch enabled userspace can select that feature. I'm sure
> that Yocto will contain support for multi-touch userspaces if it
> doesn't already.

Eric, thanks by pointing this change out for us. It does seems to be a
better fix for this. Leonardo, please integrate the Eric's patch and
send a v3 with this.

Regards,

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br