From: Rongqing Li <rongqing.li@windriver.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org, joe.macdonald@windriver.com
Subject: Re: [PATCH 1/2] xinetd: enable tcp-wrappers support by DISTRO_FEATURE
Date: Sat, 19 Jan 2013 12:37:55 +0800 [thread overview]
Message-ID: <50FA2323.5060305@windriver.com> (raw)
In-Reply-To: <20130118082611.GC3091@jama>
On 01/18/2013 04:26 PM, Martin Jansa wrote:
> On Fri, Jan 18, 2013 at 10:56:22AM +0800, rongqing.li@windriver.com wrote:
>> From: "Roy.Li" <rongqing.li@windriver.com>
>>
>> Signed-off-by: Roy.Li <rongqing.li@windriver.com>
>> ---
>> meta/recipes-extended/xinetd/xinetd_2.3.15.bb | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-extended/xinetd/xinetd_2.3.15.bb b/meta/recipes-extended/xinetd/xinetd_2.3.15.bb
>> index 3bde512..9278cc2 100644
>> --- a/meta/recipes-extended/xinetd/xinetd_2.3.15.bb
>> +++ b/meta/recipes-extended/xinetd/xinetd_2.3.15.bb
>> @@ -7,7 +7,7 @@ LICENSE = "BSD"
>> LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=8ad8615198542444f84d28a6cf226dd8"
>>
>> DEPENDS = ""
>> -PR = "r1"
>> +PR = "r2"
>>
>> SRC_URI = "http://www.xinetd.org/xinetd-${PV}.tar.gz \
>> file://xinetd.init \
>> @@ -28,6 +28,9 @@ INITSCRIPT_PARAMS = "defaults"
>>
>> EXTRA_OECONF="--disable-nls"
>>
>> +DEPENDS += "${@base_contains('DISTRO_FEATURES', 'tcp-wrappers', 'tcp-wrappers', '', d)}"
>> +EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'tcp-wrappers', '--with-libwrap', '', d)}"
>> +
>
> Why not use PACKAGECONFIG here?
>
Enabling tcp-wrapper is not a random thing for some customer,
it is a must. So I think feature is more suitable
-Roy
> Cheers,
>
>> do_configure() {
>> # Looks like configure.in is broken, so we are skipping
>> # rebuilding configure and are just using the shipped one
>> --
>> 1.7.10.4
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
--
Best Reagrds,
Roy | RongQing Li
next prev parent reply other threads:[~2013-01-19 4:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 2:56 [PATCH 0/2] define and use tcp-wrappers DISTRO_FEATURE rongqing.li
2013-01-18 2:56 ` [PATCH 1/2] xinetd: enable tcp-wrappers support by DISTRO_FEATURE rongqing.li
2013-01-18 8:26 ` Martin Jansa
2013-01-19 4:37 ` Rongqing Li [this message]
2013-01-19 4:45 ` Saul Wold
2013-01-19 4:53 ` Rongqing Li
2013-01-18 2:56 ` [PATCH 2/2] default-distrovars: add tcp-wrappers to default DISTRO_FEATURES rongqing.li
2013-01-18 8:24 ` Martin Jansa
2013-01-19 4:42 ` Rongqing Li
-- strict thread matches above, loose matches on Subject: below --
2013-01-21 2:36 [PATCH 0/2 v2] define and use tcp-wrappers DISTRO_FEATURE rongqing.li
2013-01-21 2:36 ` [PATCH 1/2] xinetd: enable tcp-wrappers support by DISTRO_FEATURE rongqing.li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FA2323.5060305@windriver.com \
--to=rongqing.li@windriver.com \
--cc=joe.macdonald@windriver.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.