From: Rongqing Li <rongqing.li@windriver.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: joe.macdonald@windriver.com,
Martin Jansa <martin.jansa@gmail.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] xinetd: enable tcp-wrappers support by DISTRO_FEATURE
Date: Sat, 19 Jan 2013 12:53:45 +0800 [thread overview]
Message-ID: <50FA26D9.5020601@windriver.com> (raw)
In-Reply-To: <50FA24EA.5060200@linux.intel.com>
On 01/19/2013 12:45 PM, Saul Wold wrote:
>>>> +EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'tcp-wrappers',
>>>> '--with-libwrap', '', d)}"
>>>> +
>>>
>>> Why not use PACKAGECONFIG here?
>>>
>>
>> Enabling tcp-wrapper is not a random thing for some customer,
>> it is a must. So I think feature is more suitable
>>
> Martin's point is you can use the PACKAGECONFIG syntax here instead of 2
> base_contains.
>
> for example:
> PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'tcp_wrappers',
> 'tcp_wrappers', '', d)}"
> PACKAGECONFIG[tcp_wrappers] = "--with-libwrap,--without-libwrap,
> tcp_wrappers"
>
> See docs for more information.
>
> Sau!
I see, thanks
-Roy
--
Best Reagrds,
Roy | RongQing Li
next prev parent reply other threads:[~2013-01-19 5:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 2:56 [PATCH 0/2] define and use tcp-wrappers DISTRO_FEATURE rongqing.li
2013-01-18 2:56 ` [PATCH 1/2] xinetd: enable tcp-wrappers support by DISTRO_FEATURE rongqing.li
2013-01-18 8:26 ` Martin Jansa
2013-01-19 4:37 ` Rongqing Li
2013-01-19 4:45 ` Saul Wold
2013-01-19 4:53 ` Rongqing Li [this message]
2013-01-18 2:56 ` [PATCH 2/2] default-distrovars: add tcp-wrappers to default DISTRO_FEATURES rongqing.li
2013-01-18 8:24 ` Martin Jansa
2013-01-19 4:42 ` Rongqing Li
-- strict thread matches above, loose matches on Subject: below --
2013-01-21 2:36 [PATCH 0/2 v2] define and use tcp-wrappers DISTRO_FEATURE rongqing.li
2013-01-21 2:36 ` [PATCH 1/2] xinetd: enable tcp-wrappers support by DISTRO_FEATURE rongqing.li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FA26D9.5020601@windriver.com \
--to=rongqing.li@windriver.com \
--cc=joe.macdonald@windriver.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.