Re: [Qemu-devel] [PATCH RFC for-1.4] qemu-thread-posix: Fix build for OpenBSD

["Andreas Färber" <andreas.faerber@web.de>]

Am 19.01.2013 10:44, schrieb Blue Swirl:
> On Fri, Jan 18, 2013 at 4:16 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 18/01/2013 17:07, Andreas Färber ha scritto:
>>> Am 18.01.2013 17:05, schrieb Paolo Bonzini:
>>>> Il 18/01/2013 16:58, Andreas Färber ha scritto:
>>>>> Avoid an undefined reference to sem_timedwait.
>>>>>
>>>>> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
>>>>> ---
>>>>>  include/qemu/thread-posix.h |    2 +-
>>>>>  util/qemu-thread-posix.c    |   10 +++++-----
>>>>>  2 Dateien geändert, 6 Zeilen hinzugefügt(+), 6 Zeilen entfernt(-)
>>>>>
>>>>> diff --git a/include/qemu/thread-posix.h b/include/qemu/thread-posix.h
>>>>> index 0f30dcc..772d925 100644
>>>>> --- a/include/qemu/thread-posix.h
>>>>> +++ b/include/qemu/thread-posix.h
>>>>> @@ -12,7 +12,7 @@ struct QemuCond {
>>>>>  };
>>>>>
>>>>>  struct QemuSemaphore {
>>>>> -#if defined(__APPLE__) || defined(__NetBSD__)
>>>>> +#if defined(__APPLE__) || defined(__NetBSD__) || defined(__OpenBSD__)
>>>>>      pthread_mutex_t lock;
>>>>>      pthread_cond_t cond;
>>>>>      int count;
[...]
>>>> This was reverted recently.  Apparently your OpenBSD is too old compared
>>>> to what Brad wants to support...
>>>
>>> This is 5.1 from 2012.
>>
>> 2012 does sound a bit too recent, but then maybe not considering OpenBSD
>> is only now getting a decent threading library.  I suggest this
>> approach: http://lwn.net/Articles/527216/
> 
> Brad, please correct me if I'm wrong, but I don't think OpenBSD
> supports the previous releases, only the last release (5.2 was
> released in November, 2012), -stable and -current:
> http://www.openbsd.org/stable.html
> http://www.openbsd.org/errata52.html

Forgot to reply: I upgraded to 5.2 yesterday and that did fix this issue
for me! Please drop this patch. I just need *some* working BSD system to
test bsd-user with my upcoming CPU changes.

Andreas

> 
> This is a different approach to for example Ubuntu LTS, Debian stable or RHEL.
> 
>>
>> Paolo
>>
>> Paolo
>>
>>