All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Zhang <nvmarkzhang@gmail.com>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] man: Fix typo and use $() for make expressions
Date: Sun, 20 Jan 2013 14:39:10 +0800	[thread overview]
Message-ID: <50FB910E.70201@gmail.com> (raw)
In-Reply-To: <CANq1E4QSQ8yfvangqEqukMhaHcmNztkOnFFUVh-xxNy15vnuyA@mail.gmail.com>

Hi David:

Sorry for jumping in. I pulled the ToT libdrm and it seems the manpages
will not be built("make html" does nothing), any suggestions?

P.S: I've installed xsltproc.

Mark
On 01/19/2013 12:01 AM, David Herrmann wrote:
> On Fri, Jan 18, 2013 at 5:00 PM, David Herrmann
> <dh.herrmann@googlemail.com> wrote:
>> Hi Thierry
>>
>> On Fri, Jan 18, 2013 at 1:22 PM, Thierry Reding
>> <thierry.reding@avionic-design.de> wrote:
>>> Due to the typo, none of the .xml files would end up in the release
>>> tarball and cause make distcheck as well as builds from the tarball to
>>> fail.
>>>
>>> Using $() isn't strictly necessary but other variables and expressions
>>> use that variant already so it makes the usage consistent.
>>
>> That's weird. "make distcheck" should not be able to build the
>> manpages if the XML files are not available. Also ${} is pretty
>> standard in makefiles, isn't it? I wonder what the problem here is. At
>> least distcheck runs fine on my machine.
> 
> Ah sorry, I now saw the "subs" => "subst" typo. Still I wonder why
> distcheck works here. But the patch looks fine. Thanks!
> 
>> Regards
>> David
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

  parent reply	other threads:[~2013-01-20  6:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18 12:22 [PATCH] man: Fix typo and use $() for make expressions Thierry Reding
2013-01-18 16:00 ` David Herrmann
2013-01-18 16:01   ` David Herrmann
2013-01-18 16:54     ` Jesse Barnes
2013-01-25 15:54       ` David Herrmann
2013-01-25 21:47         ` Jesse Barnes
2013-01-20  6:39     ` Mark Zhang [this message]
2013-01-20  9:17       ` David Herrmann
2013-01-20  9:41         ` Mark Zhang
2013-01-21  6:52   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50FB910E.70201@gmail.com \
    --to=nvmarkzhang@gmail.com \
    --cc=dh.herrmann@googlemail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.