Re: [PATCH] serial: lpc32xx: Fix fallout from tty_port conversion

[Jiri Slaby <jslaby@suse.cz>]

On 01/18/2013 08:25 AM, Thierry Reding wrote:
> A duplicate definition of the port variable was introduced in the
> interrupt handler, which causes the build to break. The fix is to
> rename the variable to tport, which is already properly used in
> subsequent code.
> 
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> ---
>  drivers/tty/serial/lpc32xx_hs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/lpc32xx_hs.c b/drivers/tty/serial/lpc32xx_hs.c
> index c01b58f..dffea6b 100644
> --- a/drivers/tty/serial/lpc32xx_hs.c
> +++ b/drivers/tty/serial/lpc32xx_hs.c
> @@ -322,7 +322,7 @@ exit_tx:
>  static irqreturn_t serial_lpc32xx_interrupt(int irq, void *dev_id)
>  {
>  	struct uart_port *port = dev_id;
> -	struct tty_port *port = &port->state->port;
> +	struct tty_port *tport = &port->state->port;

Oh, yeah, these arch-dependent drivers... This one is arm, tty-build
script has been updated here. Thanks for spotting and fixing.

-- 
js
suse labs