* [PATCH] serial: lpc32xx: Fix fallout from tty_port conversion
@ 2013-01-18 7:25 Thierry Reding
2013-01-20 10:19 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: Thierry Reding @ 2013-01-18 7:25 UTC (permalink / raw)
To: Alan Cox; +Cc: Greg Kroah-Hartman, Jiri Slaby, linux-serial, linux-kernel
A duplicate definition of the port variable was introduced in the
interrupt handler, which causes the build to break. The fix is to
rename the variable to tport, which is already properly used in
subsequent code.
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
---
drivers/tty/serial/lpc32xx_hs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/lpc32xx_hs.c b/drivers/tty/serial/lpc32xx_hs.c
index c01b58f..dffea6b 100644
--- a/drivers/tty/serial/lpc32xx_hs.c
+++ b/drivers/tty/serial/lpc32xx_hs.c
@@ -322,7 +322,7 @@ exit_tx:
static irqreturn_t serial_lpc32xx_interrupt(int irq, void *dev_id)
{
struct uart_port *port = dev_id;
- struct tty_port *port = &port->state->port;
+ struct tty_port *tport = &port->state->port;
u32 status;
spin_lock(&port->lock);
--
1.8.1.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] serial: lpc32xx: Fix fallout from tty_port conversion
2013-01-18 7:25 [PATCH] serial: lpc32xx: Fix fallout from tty_port conversion Thierry Reding
@ 2013-01-20 10:19 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2013-01-20 10:19 UTC (permalink / raw)
To: Thierry Reding; +Cc: Alan Cox, Greg Kroah-Hartman, linux-serial, linux-kernel
On 01/18/2013 08:25 AM, Thierry Reding wrote:
> A duplicate definition of the port variable was introduced in the
> interrupt handler, which causes the build to break. The fix is to
> rename the variable to tport, which is already properly used in
> subsequent code.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> ---
> drivers/tty/serial/lpc32xx_hs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/lpc32xx_hs.c b/drivers/tty/serial/lpc32xx_hs.c
> index c01b58f..dffea6b 100644
> --- a/drivers/tty/serial/lpc32xx_hs.c
> +++ b/drivers/tty/serial/lpc32xx_hs.c
> @@ -322,7 +322,7 @@ exit_tx:
> static irqreturn_t serial_lpc32xx_interrupt(int irq, void *dev_id)
> {
> struct uart_port *port = dev_id;
> - struct tty_port *port = &port->state->port;
> + struct tty_port *tport = &port->state->port;
Oh, yeah, these arch-dependent drivers... This one is arm, tty-build
script has been updated here. Thanks for spotting and fixing.
--
js
suse labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-20 10:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-18 7:25 [PATCH] serial: lpc32xx: Fix fallout from tty_port conversion Thierry Reding
2013-01-20 10:19 ` Jiri Slaby
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.