From: Antti Palosaari <crope@iki.fi>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: mchehab@redhat.com, mkrufky@linuxtv.org, patricechotard@free.fr,
kosio.dimitrov@gmail.com, liplianin@me.by,
danny.kukawka@bisect.de, s.nawrocki@samsung.com,
laurent.pinchart@ideasonboard.com, hans.verkuil@cisco.com,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] [media] use IS_ENABLED() macro
Date: Sun, 20 Jan 2013 18:07:55 +0000 [thread overview]
Message-ID: <50FC327B.6050903@iki.fi> (raw)
In-Reply-To: <1358659976-8767-1-git-send-email-peter.senna@gmail.com>
On 01/20/2013 07:32 AM, Peter Senna Tschudin wrote:
> This patch introduces the use of IS_ENABLED() macro. For example,
> replacing:
> #if defined(CONFIG_I2C) || (defined(CONFIG_I2C_MODULE) && defined(MODULE))
>
> with:
> #if IS_ENABLED(CONFIG_I2C)
>
> All changes made by this patch respect the same replacement pattern.
>
> Reported-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
For my drivers
> drivers/media/tuners/qt1010.h | 2 +-
> drivers/media/tuners/xc4000.h | 2 +-
Acked-by: Antti Palosaari <crope@iki.fi>
Why you didn't changed all those drivers as once?
I was planning to do just similar change to all dvb drivers (I did it
for DVB USB V2 remote controller already).
I have also changed some of my new driver printk() calls from these
headers to new pr/dev _foo() style. Please, could you fix it also :)
regard
Antti
--
http://palosaari.fi/
WARNING: multiple messages have this Message-ID (diff)
From: Antti Palosaari <crope@iki.fi>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: mchehab@redhat.com, mkrufky@linuxtv.org, patricechotard@free.fr,
kosio.dimitrov@gmail.com, liplianin@me.by,
danny.kukawka@bisect.de, s.nawrocki@samsung.com,
laurent.pinchart@ideasonboard.com, hans.verkuil@cisco.com,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] [media] use IS_ENABLED() macro
Date: Sun, 20 Jan 2013 20:07:55 +0200 [thread overview]
Message-ID: <50FC327B.6050903@iki.fi> (raw)
In-Reply-To: <1358659976-8767-1-git-send-email-peter.senna@gmail.com>
On 01/20/2013 07:32 AM, Peter Senna Tschudin wrote:
> This patch introduces the use of IS_ENABLED() macro. For example,
> replacing:
> #if defined(CONFIG_I2C) || (defined(CONFIG_I2C_MODULE) && defined(MODULE))
>
> with:
> #if IS_ENABLED(CONFIG_I2C)
>
> All changes made by this patch respect the same replacement pattern.
>
> Reported-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
For my drivers
> drivers/media/tuners/qt1010.h | 2 +-
> drivers/media/tuners/xc4000.h | 2 +-
Acked-by: Antti Palosaari <crope@iki.fi>
Why you didn't changed all those drivers as once?
I was planning to do just similar change to all dvb drivers (I did it
for DVB USB V2 remote controller already).
I have also changed some of my new driver printk() calls from these
headers to new pr/dev _foo() style. Please, could you fix it also :)
regard
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2013-01-20 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 5:32 [PATCH] [media] use IS_ENABLED() macro Peter Senna Tschudin
2013-01-20 5:32 ` Peter Senna Tschudin
2013-01-20 18:07 ` Antti Palosaari [this message]
2013-01-20 18:07 ` Antti Palosaari
2013-01-20 18:12 ` Antti Palosaari
2013-01-20 18:12 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FC327B.6050903@iki.fi \
--to=crope@iki.fi \
--cc=danny.kukawka@bisect.de \
--cc=hans.verkuil@cisco.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kosio.dimitrov@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=liplianin@me.by \
--cc=mchehab@redhat.com \
--cc=mkrufky@linuxtv.org \
--cc=patricechotard@free.fr \
--cc=peter.senna@gmail.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.