All of lore.kernel.org
 help / color / mirror / Atom feed
* scripts/package/Makefile: KBUILD_OUTPUT is useless in rpm build
@ 2013-01-21  6:35 Bin Wang
  0 siblings, 0 replies; only message in thread
From: Bin Wang @ 2013-01-21  6:35 UTC (permalink / raw)
  To: Michal Marek, linux-kernel, linux-kbuild; +Cc: Bin Wang

I found KBUILD_OUTPUT variable is useless in the rpm-pkg and rpm target.

Yes there is a comment said:

# Note that the rpm-pkg target cannot be used with KBUILD_OUTPUT,
# but the binrpm-pkg target can; for some reason O= gets ignored.

It does not say for what reason. Also, the code under rpm-pkg checks if
KBUILD_OUTPUT is defined.

> @if test -n "$(KBUILD_OUTPUT)"; then \
> echo "Building source + binary RPM is not possible outside the"; \
> echo "kernel source tree. Don't set KBUILD_OUTPUT, or use the"; \
> echo "binrpm-pkg target instead."; \
> false; \
> fi

But the fact is, whether or not the user use "O=" option, KBUILD_OUTPUT
is always empty. I try to figure out why but the big Makefile drives me
crazy. I'm thinking if the "O=" option really don't effect KBUILD_OUTPUT
here, at least remove these code.

-- 
Bin Wang

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2013-01-21  6:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-21  6:35 scripts/package/Makefile: KBUILD_OUTPUT is useless in rpm build Bin Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.