From: Mark Zhang <markz@nvidia.com>
To: Marc Dietrich <marvin24@gmx.de>
Cc: Mark Zhang <nvmarkzhang@gmail.com>,
Alex Courbot <acourbot@nvidia.com>,
Thierry Reding <thierry.reding@avionic-design.de>,
Stephen Warren <swarren@wwwdotorg.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"gnurou@gmail.com" <gnurou@gmail.com>
Subject: Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver
Date: Mon, 21 Jan 2013 08:55:53 +0000 [thread overview]
Message-ID: <50FD0299.2090408@nvidia.com> (raw)
In-Reply-To: <2440319.UsvGAcXXBp@fb07-iapwap2>
On 01/21/2013 04:52 PM, Marc Dietrich wrote:
> Hi,
>
>>> diff --git a/drivers/video/backlight/pwm_bl_tegra.c
>>> b/drivers/video/backlight/pwm_bl_tegra.c new file mode 100644
>>> index 0000000..8f2195b
>>> --- /dev/null
>>> +++ b/drivers/video/backlight/pwm_bl_tegra.c
>>
>> So according to the filename, I think we can put all tegra boards codes
>> here, right? Just like what you do for Ventana, if I wanna add support
>> for cardhu, I can define similar functions -- let's say "init_cardhu",
>> "exit_cardhu", "notify_cardhu" and "notify_after_cardhu", right?
>>
>> But I think if we do in this way, the file will become very long soon.
>> And there are a lot of redundant codes in it. So do you have any
>> suggestions?
>
> I think we (for PAZ00) will just reuse the ventana code which is sufficient
> for us. But adding "pwm-backlight-ventana" to our DTS may look a bit strange.
> On the other hand, I guess that's why the property is called "compatible".
>
Ah, yeah, that looks strange. :)
Okay, so I know why Alex wants to use panel name while not board name...
> Marc
>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Zhang <markz@nvidia.com>
To: Marc Dietrich <marvin24@gmx.de>
Cc: Mark Zhang <nvmarkzhang@gmail.com>,
Alex Courbot <acourbot@nvidia.com>,
Thierry Reding <thierry.reding@avionic-design.de>,
Stephen Warren <swarren@wwwdotorg.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"gnurou@gmail.com" <gnurou@gmail.com>
Subject: Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver
Date: Mon, 21 Jan 2013 16:55:53 +0800 [thread overview]
Message-ID: <50FD0299.2090408@nvidia.com> (raw)
In-Reply-To: <2440319.UsvGAcXXBp@fb07-iapwap2>
On 01/21/2013 04:52 PM, Marc Dietrich wrote:
> Hi,
>
>>> diff --git a/drivers/video/backlight/pwm_bl_tegra.c
>>> b/drivers/video/backlight/pwm_bl_tegra.c new file mode 100644
>>> index 0000000..8f2195b
>>> --- /dev/null
>>> +++ b/drivers/video/backlight/pwm_bl_tegra.c
>>
>> So according to the filename, I think we can put all tegra boards codes
>> here, right? Just like what you do for Ventana, if I wanna add support
>> for cardhu, I can define similar functions -- let's say "init_cardhu",
>> "exit_cardhu", "notify_cardhu" and "notify_after_cardhu", right?
>>
>> But I think if we do in this way, the file will become very long soon.
>> And there are a lot of redundant codes in it. So do you have any
>> suggestions?
>
> I think we (for PAZ00) will just reuse the ventana code which is sufficient
> for us. But adding "pwm-backlight-ventana" to our DTS may look a bit strange.
> On the other hand, I guess that's why the property is called "compatible".
>
Ah, yeah, that looks strange. :)
Okay, so I know why Alex wants to use panel name while not board name...
> Marc
>
next prev parent reply other threads:[~2013-01-21 8:55 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 10:30 [PATCH 0/3] pwm-backlight: add subdrivers & Tegra support Alexandre Courbot
2013-01-19 10:30 ` Alexandre Courbot
2013-01-19 10:30 ` [PATCH 1/3] pwm-backlight: add subdriver mechanism Alexandre Courbot
2013-01-19 10:30 ` Alexandre Courbot
2013-01-19 10:30 ` [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver Alexandre Courbot
2013-01-19 10:30 ` Alexandre Courbot
[not found] ` <1358591420-7790-3-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-21 7:35 ` Mark Zhang
2013-01-21 7:35 ` Mark Zhang
2013-01-21 7:35 ` Mark Zhang
2013-01-21 8:24 ` Alex Courbot
2013-01-21 8:24 ` Alex Courbot
2013-01-21 8:35 ` Mark Zhang
2013-01-21 8:35 ` Mark Zhang
2013-01-21 8:35 ` Mark Zhang
[not found] ` <50FCEFDE.8000705-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-01-21 8:52 ` Marc Dietrich
2013-01-21 8:52 ` Marc Dietrich
2013-01-21 8:52 ` Marc Dietrich
2013-01-21 8:55 ` Mark Zhang [this message]
2013-01-21 8:55 ` Mark Zhang
2013-01-21 17:46 ` Stephen Warren
2013-01-21 17:46 ` Stephen Warren
2013-01-21 17:46 ` Stephen Warren
[not found] ` <50FD7EF9.1010205-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-22 3:24 ` Alex Courbot
2013-01-22 3:24 ` Alex Courbot
2013-01-22 3:24 ` Alex Courbot
2013-01-22 7:06 ` Thierry Reding
2013-01-22 7:06 ` Thierry Reding
2013-01-23 9:45 ` Alex Courbot
2013-01-23 9:45 ` Alex Courbot
2013-01-24 6:10 ` Alex Courbot
2013-01-24 6:10 ` Alex Courbot
2013-01-24 6:10 ` Alex Courbot
2013-01-22 16:30 ` Stephen Warren
2013-01-22 16:30 ` Stephen Warren
2013-01-22 16:30 ` Stephen Warren
2013-01-23 10:15 ` Leela Krishna Amudala
2013-01-23 10:27 ` Leela Krishna Amudala
2013-01-23 10:15 ` Leela Krishna Amudala
[not found] ` <CAL1wa8d2BS3RxdsdUyCqF20ZKe46jUZcfUKitnpP9Lgb9aB5hw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-23 10:29 ` Alex Courbot
2013-01-23 10:29 ` Alex Courbot
2013-01-23 10:29 ` Alex Courbot
[not found] ` <1358591420-7790-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-19 10:30 ` [PATCH 3/3] tegra: ventana: of: add host1x device to DT Alexandre Courbot
2013-01-19 10:30 ` Alexandre Courbot
2013-01-19 10:30 ` Alexandre Courbot
2013-01-20 3:38 ` [PATCH 0/3] pwm-backlight: add subdrivers & Tegra support Mark Zhang
2013-01-20 3:38 ` Mark Zhang
2013-01-20 3:38 ` Mark Zhang
2013-01-20 5:26 ` Alexandre Courbot
2013-01-20 5:26 ` Alexandre Courbot
2013-01-20 5:51 ` Mark Zhang
2013-01-20 5:51 ` Mark Zhang
2013-01-21 2:09 ` Mark Zhang
2013-01-21 2:09 ` Mark Zhang
2013-01-21 2:09 ` Mark Zhang
[not found] ` <50FCA346.2070608-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-01-21 2:59 ` Mark Zhang
2013-01-21 2:59 ` Mark Zhang
2013-01-21 2:59 ` Mark Zhang
2013-01-21 7:49 ` Thierry Reding
2013-01-21 7:49 ` Thierry Reding
[not found] ` <20130121074928.GE15508-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org>
2013-01-21 8:18 ` Alex Courbot
2013-01-21 8:18 ` Alex Courbot
2013-01-21 8:18 ` Alex Courbot
2013-01-22 7:17 ` Thierry Reding
2013-01-22 7:17 ` Thierry Reding
2013-01-22 7:17 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FD0299.2090408@nvidia.com \
--to=markz@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=nvmarkzhang@gmail.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.