All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: 3.7.3+:  Bad paging request in ip_rcv_finish while running NFS traffic.
Date: Mon, 21 Jan 2013 21:57:43 -0800	[thread overview]
Message-ID: <50FE2A57.3040804@candelatech.com> (raw)
In-Reply-To: <1358829606.3464.3151.camel@edumazet-glaptop>

On 01/21/2013 08:40 PM, Eric Dumazet wrote:
> On Mon, 2013-01-21 at 16:32 -0800, Ben Greear wrote:
>> On 01/21/2013 01:07 PM, Ben Greear wrote:
>>> I posted about this a few days ago, but this time the patches applied
>>> are minimal and there are no out-of-tree kernel modules loaded.
>>
>> Here's another crash, this time with SLUB memory debugging turned on.
>>
>> Seems much harder to hit this way...I've only managed this one.  I
>> believe the RCX register might be interesting...that 6b is probably
>> freed memory poisioning.  Maybe skb or skb_dest() is already freed?
>>
>> I have added a 'verify_mem_not_deleted(skb)' before the
>> dst_input line in ip_rcv_finish..but so far, it hasn't
>> hit the problem...
>>
>
> There is no way skb is freed here.
>
> I would say macvlan is at fault here.
>
> It probably lacks a proper (dev->flags & IFF_UP) test.

Thanks for the patch.  It's running OK so far, but I'll need to
do a bunch more testing tomorrow to make sure I'm not just getting
lucky!

I'll let you know how it goes tomorrow.

Thanks,
Ben



-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org>
To: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: 3.7.3+:  Bad paging request in ip_rcv_finish while running NFS traffic.
Date: Mon, 21 Jan 2013 21:57:43 -0800	[thread overview]
Message-ID: <50FE2A57.3040804@candelatech.com> (raw)
In-Reply-To: <1358829606.3464.3151.camel@edumazet-glaptop>

On 01/21/2013 08:40 PM, Eric Dumazet wrote:
> On Mon, 2013-01-21 at 16:32 -0800, Ben Greear wrote:
>> On 01/21/2013 01:07 PM, Ben Greear wrote:
>>> I posted about this a few days ago, but this time the patches applied
>>> are minimal and there are no out-of-tree kernel modules loaded.
>>
>> Here's another crash, this time with SLUB memory debugging turned on.
>>
>> Seems much harder to hit this way...I've only managed this one.  I
>> believe the RCX register might be interesting...that 6b is probably
>> freed memory poisioning.  Maybe skb or skb_dest() is already freed?
>>
>> I have added a 'verify_mem_not_deleted(skb)' before the
>> dst_input line in ip_rcv_finish..but so far, it hasn't
>> hit the problem...
>>
>
> There is no way skb is freed here.
>
> I would say macvlan is at fault here.
>
> It probably lacks a proper (dev->flags & IFF_UP) test.

Thanks for the patch.  It's running OK so far, but I'll need to
do a bunch more testing tomorrow to make sure I'm not just getting
lucky!

I'll let you know how it goes tomorrow.

Thanks,
Ben



-- 
Ben Greear <greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2013-01-22  5:57 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-21 21:07 3.7.3+: Bad paging request in ip_rcv_finish while running NFS traffic Ben Greear
2013-01-21 21:07 ` Ben Greear
2013-01-22  0:32 ` Ben Greear
2013-01-22  4:40   ` Eric Dumazet
2013-01-22  5:57     ` Ben Greear [this message]
2013-01-22  5:57       ` Ben Greear
2013-01-22 17:08       ` Ben Greear
2013-01-22 17:08         ` Ben Greear
2013-01-22 17:17         ` Eric Dumazet
2013-01-22 17:17           ` Eric Dumazet
2013-01-22 17:26           ` Ben Greear
2013-01-22 17:26             ` Ben Greear
2013-01-22 17:26           ` Eric Dumazet
2013-01-22 22:18             ` Ben Greear
2013-01-22 22:18               ` Ben Greear
2013-01-23  2:32               ` Ben Greear
2013-01-23  2:32                 ` Ben Greear
2013-01-23  6:11                 ` Eric Dumazet
2013-01-23  7:14                   ` Ben Greear
2013-01-23  7:14                     ` Ben Greear
2013-01-23 13:35                     ` Eric Dumazet
2013-01-23 13:35                       ` Eric Dumazet
2013-01-23 18:15                       ` Ben Greear
2013-01-23 18:15                         ` Ben Greear
2013-01-23 21:43                         ` Eric Dumazet
2013-01-23 14:42                     ` Eric Dumazet
2013-01-23 14:42                       ` Eric Dumazet
2013-01-23 21:53                       ` Ben Greear
2013-01-23 21:53                         ` Ben Greear
2013-01-23 23:55                 ` Ben Greear
2013-01-23 23:55                   ` Ben Greear
2013-01-24  0:01                   ` Eric Dumazet
2013-01-24  0:01                     ` Eric Dumazet
2013-01-24  0:13                     ` Ben Greear
2013-01-24  0:13                       ` Ben Greear
2013-01-24  0:23                       ` Eric Dumazet
2013-01-24  0:23                         ` Eric Dumazet
2013-01-24  0:38                         ` Ben Greear
2013-01-24  0:45                           ` Eric Dumazet
2013-01-24  0:51                             ` Ben Greear
2013-01-24  1:00                               ` Eric Dumazet
2013-01-24  1:06                                 ` Ben Greear
2013-01-24  1:10                                   ` Eric Dumazet
2013-01-24  1:45                                     ` Eric Dumazet
2013-01-24  4:26                                       ` Ben Greear
2013-01-24  5:39                                         ` Eric Dumazet
2013-01-24 20:03                                       ` Ben Greear
2013-01-24 20:59                                         ` Eric Dumazet
2013-01-24 21:01                                           ` Ben Greear
2013-01-25 17:44                                       ` [PATCH] net: loopback: fix a dst refcounting issue Eric Dumazet
2013-01-27  6:32                                         ` David Miller
2013-01-27 17:25                                           ` Eric Dumazet
2013-01-28  0:26                                             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50FE2A57.3040804@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.