* [libata:upstream 7/11] drivers/ata/libata-zpodd.c:83 zpodd_wake_dev() warn: variable dereferenced before check 'ata_dev' (see line 80)
@ 2013-01-22 6:25 Dan Carpenter
2013-01-22 8:32 ` Aaron Lu
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2013-01-22 6:25 UTC (permalink / raw)
To: Aaron Lu; +Cc: Jeff Garzik, linux-ide, kbuild
Hi Aaron,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream
head: 7e15e9be37eb834aaaca69030064ac97eaf5df2f
commit: f064a20dded807448669426c9bfb7d03aba5659c [7/11] libata: move acpi notification code to zpodd
New smatch warnings:
drivers/ata/libata-zpodd.c:83 zpodd_wake_dev() warn: variable dereferenced before check 'ata_dev' (see line 80)
git remote add libata git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
git remote update libata
git checkout f064a20dded807448669426c9bfb7d03aba5659c
vim +/ata_dev +83 drivers/ata/libata-zpodd.c
afe75951 Aaron Lu 2013-01-15 74 return acpi_device_can_poweroff(acpi_dev);
afe75951 Aaron Lu 2013-01-15 75 }
afe75951 Aaron Lu 2013-01-15 76
f064a20d Aaron Lu 2013-01-15 77 static void zpodd_wake_dev(acpi_handle handle, u32 event, void *context)
f064a20d Aaron Lu 2013-01-15 78 {
f064a20d Aaron Lu 2013-01-15 79 struct ata_device *ata_dev = context;
f064a20d Aaron Lu 2013-01-15 @80 struct zpodd *zpodd = ata_dev->zpodd;
f064a20d Aaron Lu 2013-01-15 81 struct device *dev = &ata_dev->sdev->sdev_gendev;
f064a20d Aaron Lu 2013-01-15 82
f064a20d Aaron Lu 2013-01-15 @83 if (event == ACPI_NOTIFY_DEVICE_WAKE && ata_dev &&
f064a20d Aaron Lu 2013-01-15 84 pm_runtime_suspended(dev)) {
f064a20d Aaron Lu 2013-01-15 85 zpodd->from_notify = true;
f064a20d Aaron Lu 2013-01-15 86 pm_runtime_resume(dev);
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [libata:upstream 7/11] drivers/ata/libata-zpodd.c:83 zpodd_wake_dev() warn: variable dereferenced before check 'ata_dev' (see line 80) 2013-01-22 6:25 [libata:upstream 7/11] drivers/ata/libata-zpodd.c:83 zpodd_wake_dev() warn: variable dereferenced before check 'ata_dev' (see line 80) Dan Carpenter @ 2013-01-22 8:32 ` Aaron Lu 2013-01-22 8:38 ` Dan Carpenter 0 siblings, 1 reply; 5+ messages in thread From: Aaron Lu @ 2013-01-22 8:32 UTC (permalink / raw) To: Dan Carpenter; +Cc: Jeff Garzik, linux-ide, kbuild Hi Dan, Thanks for the remind. On 01/22/2013 02:25 PM, Dan Carpenter wrote: > Hi Aaron, > > FYI, there are new smatch warnings show up in > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream > head: 7e15e9be37eb834aaaca69030064ac97eaf5df2f > commit: f064a20dded807448669426c9bfb7d03aba5659c [7/11] libata: move acpi notification code to zpodd > > New smatch warnings: > drivers/ata/libata-zpodd.c:83 zpodd_wake_dev() warn: variable dereferenced before check 'ata_dev' (see line 80) The ata_dev variable shouldn't ever be NULL here. > > git remote add libata git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git > git remote update libata > git checkout f064a20dded807448669426c9bfb7d03aba5659c > vim +/ata_dev +83 drivers/ata/libata-zpodd.c > > afe75951 Aaron Lu 2013-01-15 74 return acpi_device_can_poweroff(acpi_dev); > afe75951 Aaron Lu 2013-01-15 75 } > afe75951 Aaron Lu 2013-01-15 76 > f064a20d Aaron Lu 2013-01-15 77 static void zpodd_wake_dev(acpi_handle handle, u32 event, void *context) > f064a20d Aaron Lu 2013-01-15 78 { > f064a20d Aaron Lu 2013-01-15 79 struct ata_device *ata_dev = context; > f064a20d Aaron Lu 2013-01-15 @80 struct zpodd *zpodd = ata_dev->zpodd; > f064a20d Aaron Lu 2013-01-15 81 struct device *dev = &ata_dev->sdev->sdev_gendev; > f064a20d Aaron Lu 2013-01-15 82 > f064a20d Aaron Lu 2013-01-15 @83 if (event == ACPI_NOTIFY_DEVICE_WAKE && ata_dev && If I remove the check for ata_dev here, will the smatch warning go away? Or should I add a check above? I suppose we need to do something to the warning, so that it won't pop up in the future, so please feel free to suggest, thanks! -Aaron > f064a20d Aaron Lu 2013-01-15 84 pm_runtime_suspended(dev)) { > f064a20d Aaron Lu 2013-01-15 85 zpodd->from_notify = true; > f064a20d Aaron Lu 2013-01-15 86 pm_runtime_resume(dev); > > --- > 0-DAY kernel build testing backend Open Source Technology Center > http://lists.01.org/mailman/listinfo/kbuild Intel Corporation > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [libata:upstream 7/11] drivers/ata/libata-zpodd.c:83 zpodd_wake_dev() warn: variable dereferenced before check 'ata_dev' (see line 80) 2013-01-22 8:32 ` Aaron Lu @ 2013-01-22 8:38 ` Dan Carpenter 2013-01-22 8:45 ` Aaron Lu 0 siblings, 1 reply; 5+ messages in thread From: Dan Carpenter @ 2013-01-22 8:38 UTC (permalink / raw) To: Aaron Lu; +Cc: Jeff Garzik, linux-ide, kbuild On Tue, Jan 22, 2013 at 04:32:06PM +0800, Aaron Lu wrote: > Hi Dan, > > Thanks for the remind. > > On 01/22/2013 02:25 PM, Dan Carpenter wrote: > > Hi Aaron, > > > > FYI, there are new smatch warnings show up in > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream > > head: 7e15e9be37eb834aaaca69030064ac97eaf5df2f > > commit: f064a20dded807448669426c9bfb7d03aba5659c [7/11] libata: move acpi notification code to zpodd > > > > New smatch warnings: > > drivers/ata/libata-zpodd.c:83 zpodd_wake_dev() warn: variable dereferenced before check 'ata_dev' (see line 80) > > The ata_dev variable shouldn't ever be NULL here. > > > > > git remote add libata git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git > > git remote update libata > > git checkout f064a20dded807448669426c9bfb7d03aba5659c > > vim +/ata_dev +83 drivers/ata/libata-zpodd.c > > > > afe75951 Aaron Lu 2013-01-15 74 return acpi_device_can_poweroff(acpi_dev); > > afe75951 Aaron Lu 2013-01-15 75 } > > afe75951 Aaron Lu 2013-01-15 76 > > f064a20d Aaron Lu 2013-01-15 77 static void zpodd_wake_dev(acpi_handle handle, u32 event, void *context) > > f064a20d Aaron Lu 2013-01-15 78 { > > f064a20d Aaron Lu 2013-01-15 79 struct ata_device *ata_dev = context; > > f064a20d Aaron Lu 2013-01-15 @80 struct zpodd *zpodd = ata_dev->zpodd; > > f064a20d Aaron Lu 2013-01-15 81 struct device *dev = &ata_dev->sdev->sdev_gendev; > > f064a20d Aaron Lu 2013-01-15 82 > > f064a20d Aaron Lu 2013-01-15 @83 if (event == ACPI_NOTIFY_DEVICE_WAKE && ata_dev && > > If I remove the check for ata_dev here, will the smatch warning go away? > Or should I add a check above? I suppose we need to do something to the > warning, so that it won't pop up in the future, so please feel free to > suggest, thanks! Removing the check would silence the warning. regards, dan carpenter ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [libata:upstream 7/11] drivers/ata/libata-zpodd.c:83 zpodd_wake_dev() warn: variable dereferenced before check 'ata_dev' (see line 80) 2013-01-22 8:38 ` Dan Carpenter @ 2013-01-22 8:45 ` Aaron Lu 2013-01-25 20:38 ` Jeff Garzik 0 siblings, 1 reply; 5+ messages in thread From: Aaron Lu @ 2013-01-22 8:45 UTC (permalink / raw) To: Dan Carpenter, Jeff Garzik; +Cc: linux-ide, kbuild On 01/22/2013 04:38 PM, Dan Carpenter wrote: > On Tue, Jan 22, 2013 at 04:32:06PM +0800, Aaron Lu wrote: >> Hi Dan, >> >> Thanks for the remind. >> >> On 01/22/2013 02:25 PM, Dan Carpenter wrote: >>> Hi Aaron, >>> >>> FYI, there are new smatch warnings show up in >>> >>> tree: git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream >>> head: 7e15e9be37eb834aaaca69030064ac97eaf5df2f >>> commit: f064a20dded807448669426c9bfb7d03aba5659c [7/11] libata: move acpi notification code to zpodd >>> >>> New smatch warnings: >>> drivers/ata/libata-zpodd.c:83 zpodd_wake_dev() warn: variable dereferenced before check 'ata_dev' (see line 80) >> >> The ata_dev variable shouldn't ever be NULL here. >> >>> >>> git remote add libata git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git >>> git remote update libata >>> git checkout f064a20dded807448669426c9bfb7d03aba5659c >>> vim +/ata_dev +83 drivers/ata/libata-zpodd.c >>> >>> afe75951 Aaron Lu 2013-01-15 74 return acpi_device_can_poweroff(acpi_dev); >>> afe75951 Aaron Lu 2013-01-15 75 } >>> afe75951 Aaron Lu 2013-01-15 76 >>> f064a20d Aaron Lu 2013-01-15 77 static void zpodd_wake_dev(acpi_handle handle, u32 event, void *context) >>> f064a20d Aaron Lu 2013-01-15 78 { >>> f064a20d Aaron Lu 2013-01-15 79 struct ata_device *ata_dev = context; >>> f064a20d Aaron Lu 2013-01-15 @80 struct zpodd *zpodd = ata_dev->zpodd; >>> f064a20d Aaron Lu 2013-01-15 81 struct device *dev = &ata_dev->sdev->sdev_gendev; >>> f064a20d Aaron Lu 2013-01-15 82 >>> f064a20d Aaron Lu 2013-01-15 @83 if (event == ACPI_NOTIFY_DEVICE_WAKE && ata_dev && >> >> If I remove the check for ata_dev here, will the smatch warning go away? >> Or should I add a check above? I suppose we need to do something to the >> warning, so that it won't pop up in the future, so please feel free to >> suggest, thanks! > > Removing the check would silence the warning. OK, thanks. Hi Jeff, Should I prepare a new patch to fix this or update the original patch? Thanks, Aaron ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [libata:upstream 7/11] drivers/ata/libata-zpodd.c:83 zpodd_wake_dev() warn: variable dereferenced before check 'ata_dev' (see line 80) 2013-01-22 8:45 ` Aaron Lu @ 2013-01-25 20:38 ` Jeff Garzik 0 siblings, 0 replies; 5+ messages in thread From: Jeff Garzik @ 2013-01-25 20:38 UTC (permalink / raw) To: Aaron Lu; +Cc: Dan Carpenter, Jeff Garzik, linux-ide, kbuild On 01/22/2013 03:45 AM, Aaron Lu wrote: > On 01/22/2013 04:38 PM, Dan Carpenter wrote: >> On Tue, Jan 22, 2013 at 04:32:06PM +0800, Aaron Lu wrote: >>> Hi Dan, >>> >>> Thanks for the remind. >>> >>> On 01/22/2013 02:25 PM, Dan Carpenter wrote: >>>> Hi Aaron, >>>> >>>> FYI, there are new smatch warnings show up in >>>> >>>> tree: git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream >>>> head: 7e15e9be37eb834aaaca69030064ac97eaf5df2f >>>> commit: f064a20dded807448669426c9bfb7d03aba5659c [7/11] libata: move acpi notification code to zpodd >>>> >>>> New smatch warnings: >>>> drivers/ata/libata-zpodd.c:83 zpodd_wake_dev() warn: variable dereferenced before check 'ata_dev' (see line 80) >>> >>> The ata_dev variable shouldn't ever be NULL here. >>> >>>> >>>> git remote add libata git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git >>>> git remote update libata >>>> git checkout f064a20dded807448669426c9bfb7d03aba5659c >>>> vim +/ata_dev +83 drivers/ata/libata-zpodd.c >>>> >>>> afe75951 Aaron Lu 2013-01-15 74 return acpi_device_can_poweroff(acpi_dev); >>>> afe75951 Aaron Lu 2013-01-15 75 } >>>> afe75951 Aaron Lu 2013-01-15 76 >>>> f064a20d Aaron Lu 2013-01-15 77 static void zpodd_wake_dev(acpi_handle handle, u32 event, void *context) >>>> f064a20d Aaron Lu 2013-01-15 78 { >>>> f064a20d Aaron Lu 2013-01-15 79 struct ata_device *ata_dev = context; >>>> f064a20d Aaron Lu 2013-01-15 @80 struct zpodd *zpodd = ata_dev->zpodd; >>>> f064a20d Aaron Lu 2013-01-15 81 struct device *dev = &ata_dev->sdev->sdev_gendev; >>>> f064a20d Aaron Lu 2013-01-15 82 >>>> f064a20d Aaron Lu 2013-01-15 @83 if (event == ACPI_NOTIFY_DEVICE_WAKE && ata_dev && >>> >>> If I remove the check for ata_dev here, will the smatch warning go away? >>> Or should I add a check above? I suppose we need to do something to the >>> warning, so that it won't pop up in the future, so please feel free to >>> suggest, thanks! >> >> Removing the check would silence the warning. > > OK, thanks. > > Hi Jeff, > Should I prepare a new patch to fix this or update the original patch? If it's in libata-dev.git#upstream, then a patch on top of all the others, which addresses the issue. Jeff ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-01-25 20:38 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-01-22 6:25 [libata:upstream 7/11] drivers/ata/libata-zpodd.c:83 zpodd_wake_dev() warn: variable dereferenced before check 'ata_dev' (see line 80) Dan Carpenter 2013-01-22 8:32 ` Aaron Lu 2013-01-22 8:38 ` Dan Carpenter 2013-01-22 8:45 ` Aaron Lu 2013-01-25 20:38 ` Jeff Garzik
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.