From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH RFC 02/10] libxl: add new hotplug interface support to hotplug script callers
Date: Tue, 22 Jan 2013 10:30:39 +0100 [thread overview]
Message-ID: <50FE5C3F.7070709@citrix.com> (raw)
In-Reply-To: <1358515771.3279.33.camel@zakaz.uk.xensource.com>
On 18/01/13 14:29, Ian Campbell wrote:
>> diff --git a/tools/libxl/libxl_netbsd.c b/tools/libxl/libxl_netbsd.c
>> index 9587833..8061e7a 100644
>> --- a/tools/libxl/libxl_netbsd.c
>> +++ b/tools/libxl/libxl_netbsd.c
>> @@ -62,7 +62,7 @@ out:
>> int libxl__get_hotplug_script_info(libxl__gc *gc, libxl__device *dev,
>> char ***args, char ***env,
>> libxl__device_action action,
>> - int num_exec)
>> + int num_exec, int hotplug_version)
>
> Is it worth wrapping verison and action into a little
> libxl__hotplug_action struct?
I'm going to pack hotplug_version and num_exec inside a
libxl__hotplug_action struct, but not device_action, because
device_action is not only used by hotplug scripts, it is also used by
the general device connection/disconnection flow, and it will be strange
to put it inside a hotplug specific struct.
next prev parent reply other threads:[~2013-01-22 9:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 16:59 [PATCH RFC 00/10] libxl: new hotplug calling convention Roger Pau Monne
2012-12-21 16:59 ` [PATCH RFC 01/10] libxl: libxl__prepare_ao_device should reset num_exec Roger Pau Monne
2013-01-17 13:57 ` Ian Campbell
2012-12-21 17:00 ` [PATCH RFC 02/10] libxl: add new hotplug interface support to hotplug script callers Roger Pau Monne
2013-01-18 13:29 ` Ian Campbell
2013-01-18 16:24 ` Roger Pau Monné
2013-01-21 10:07 ` Ian Campbell
2013-01-21 12:11 ` Roger Pau Monné
2013-01-21 12:18 ` Ian Campbell
2013-01-22 9:30 ` Roger Pau Monné [this message]
2012-12-21 17:00 ` [PATCH RFC 03/10] libxl: add new "method" parameter to xl disk config Roger Pau Monne
2013-01-17 15:49 ` Ian Campbell
2012-12-21 17:00 ` [PATCH RFC 04/10] libxl: add prepare/unprepare operations to the libxl public interface Roger Pau Monne
2012-12-21 17:00 ` [PATCH RFC 05/10] libxl: add disk specific remove functions Roger Pau Monne
2012-12-21 17:00 ` [PATCH RFC 06/10] xl: add support for new hotplug interface to block-attach/detach Roger Pau Monne
2012-12-21 17:00 ` [PATCH RFC 07/10] libxl: add local attach support for new hotplug scripts Roger Pau Monne
2012-12-21 17:00 ` [PATCH RFC 08/10] libxl: add new hotplug interface support for HVM guests Roger Pau Monne
2012-12-21 17:00 ` [PATCH RFC 09/10] hotplug: document new hotplug interface Roger Pau Monne
2012-12-21 17:00 ` [PATCH RFC 10/10] hotplug/Linux: add iscsi block hotplug script Roger Pau Monne
2013-01-15 16:56 ` [PATCH RFC 00/10] libxl: new hotplug calling convention Roger Pau Monné
2013-01-17 13:56 ` Ian Campbell
2013-01-17 15:30 ` Roger Pau Monné
2013-01-17 15:40 ` Ian Campbell
2013-01-17 15:47 ` Roger Pau Monné
2013-01-17 15:57 ` Ian Campbell
2013-01-17 16:10 ` Roger Pau Monné
2013-01-17 16:15 ` Ian Campbell
2013-01-17 16:45 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FE5C3F.7070709@citrix.com \
--to=roger.pau@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.