From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: davinci: da850 evm: pass platform data for adv7343 encoder
Date: Tue, 22 Jan 2013 17:31:04 +0530 [thread overview]
Message-ID: <50FE7F80.4060202@ti.com> (raw)
In-Reply-To: <CA+V-a8t26rMT+Prz-p5627AYiv2Nndr57mxE4E6F9UJ3CkRzng@mail.gmail.com>
On 1/22/2013 5:27 PM, Prabhakar Lad wrote:
> Sekhar,
>
> On Tue, Jan 15, 2013 at 1:34 PM, Lad, Prabhakar
> <prabhakar.csengg@gmail.com> wrote:
>> Without this patch the adv7343 encoder was being set to default
>> configuration which caused display not to work on this board.
>> This patch passes the necessary platform data required for adv7343
>> encoder to work on da850 evm.
>>
>> Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
>> ---
>> This patch is dependent on http://patchwork.linuxtv.org/patch/16272/
>>
> Since this patch depends on media [1] , I would like to get this patch
> through media tree as fix for 3.8. Could you review and ACK it ?
The patch looks good to me. Feel free to add my
Acked-by: Sekhar Nori <nsekhar@ti.com>
and merge through the media tree to ease the dependencies.
Thanks,
Sekhar
>
> [1] http://patchwork.linuxtv.org/patch/16391/
>
> Regards,
> --Prabhakar
>
>> arch/arm/mach-davinci/board-da850-evm.c | 13 +++++++++++++
>> 1 files changed, 13 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c
>> index 0299915..d0e3ec3 100644
>> --- a/arch/arm/mach-davinci/board-da850-evm.c
>> +++ b/arch/arm/mach-davinci/board-da850-evm.c
>> @@ -1256,11 +1256,24 @@ static struct vpif_capture_config da850_vpif_capture_config = {
>> };
>>
>> /* VPIF display configuration */
>> +
>> +static struct adv7343_platform_data adv7343_pdata = {
>> + .mode_config = {
>> + .dac_3 = 1,
>> + .dac_2 = 1,
>> + .dac_1 = 1,
>> + },
>> + .sd_config = {
>> + .sd_dac_out1 = 1,
>> + },
>> +};
>> +
>> static struct vpif_subdev_info da850_vpif_subdev[] = {
>> {
>> .name = "adv7343",
>> .board_info = {
>> I2C_BOARD_INFO("adv7343", 0x2a),
>> + .platform_data = &adv7343_pdata,
>> },
>> },
>> };
>> --
>> 1.7.4.1
>>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: Prabhakar Lad <prabhakar.csengg@gmail.com>
Cc: LAK <linux-arm-kernel@lists.infradead.org>,
DLOS <davinci-linux-open-source@linux.davincidsp.com>,
LKML <linux-kernel@vger.kernel.org>,
"Lad, Prabhakar" <prabhakar.lad@ti.com>
Subject: Re: [PATCH] ARM: davinci: da850 evm: pass platform data for adv7343 encoder
Date: Tue, 22 Jan 2013 17:31:04 +0530 [thread overview]
Message-ID: <50FE7F80.4060202@ti.com> (raw)
In-Reply-To: <CA+V-a8t26rMT+Prz-p5627AYiv2Nndr57mxE4E6F9UJ3CkRzng@mail.gmail.com>
On 1/22/2013 5:27 PM, Prabhakar Lad wrote:
> Sekhar,
>
> On Tue, Jan 15, 2013 at 1:34 PM, Lad, Prabhakar
> <prabhakar.csengg@gmail.com> wrote:
>> Without this patch the adv7343 encoder was being set to default
>> configuration which caused display not to work on this board.
>> This patch passes the necessary platform data required for adv7343
>> encoder to work on da850 evm.
>>
>> Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
>> ---
>> This patch is dependent on http://patchwork.linuxtv.org/patch/16272/
>>
> Since this patch depends on media [1] , I would like to get this patch
> through media tree as fix for 3.8. Could you review and ACK it ?
The patch looks good to me. Feel free to add my
Acked-by: Sekhar Nori <nsekhar@ti.com>
and merge through the media tree to ease the dependencies.
Thanks,
Sekhar
>
> [1] http://patchwork.linuxtv.org/patch/16391/
>
> Regards,
> --Prabhakar
>
>> arch/arm/mach-davinci/board-da850-evm.c | 13 +++++++++++++
>> 1 files changed, 13 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c
>> index 0299915..d0e3ec3 100644
>> --- a/arch/arm/mach-davinci/board-da850-evm.c
>> +++ b/arch/arm/mach-davinci/board-da850-evm.c
>> @@ -1256,11 +1256,24 @@ static struct vpif_capture_config da850_vpif_capture_config = {
>> };
>>
>> /* VPIF display configuration */
>> +
>> +static struct adv7343_platform_data adv7343_pdata = {
>> + .mode_config = {
>> + .dac_3 = 1,
>> + .dac_2 = 1,
>> + .dac_1 = 1,
>> + },
>> + .sd_config = {
>> + .sd_dac_out1 = 1,
>> + },
>> +};
>> +
>> static struct vpif_subdev_info da850_vpif_subdev[] = {
>> {
>> .name = "adv7343",
>> .board_info = {
>> I2C_BOARD_INFO("adv7343", 0x2a),
>> + .platform_data = &adv7343_pdata,
>> },
>> },
>> };
>> --
>> 1.7.4.1
>>
>
>
next prev parent reply other threads:[~2013-01-22 12:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 8:04 [PATCH] ARM: davinci: da850 evm: pass platform data for adv7343 encoder Lad, Prabhakar
2013-01-15 8:04 ` Lad, Prabhakar
2013-01-22 11:57 ` Prabhakar Lad
2013-01-22 11:57 ` Prabhakar Lad
2013-01-22 12:01 ` Sekhar Nori [this message]
2013-01-22 12:01 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FE7F80.4060202@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.