From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: Add axi-clkgen driver
Date: Wed, 23 Jan 2013 11:49:16 +0100 [thread overview]
Message-ID: <50FFC02C.9000109@metafoo.de> (raw)
In-Reply-To: <20130123102755.GP23505@n2100.arm.linux.org.uk>
On 01/23/2013 11:27 AM, Russell King - ARM Linux wrote:
> On Wed, Jan 23, 2013 at 11:00:56AM +0100, Lars-Peter Clausen wrote:
>> I think I read somewhere at some point that ioread{8,16,32} is preferred
>> over write{b,h,l} in new code.
>
> But... there's *no* point using ioread*() if you don't only use the
> ioremap() interface.
>
> ioread*() is there to allow PC IO and PC MMIO accesses through one
> accessor depending on the cookie. ioremap() only ever returns cookies
> for MMIO accesses.
So your point is, if you know that it is MMIO memory only ever use readl and
friends?
- Lars
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Mike Turquette <mturquette@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: Add axi-clkgen driver
Date: Wed, 23 Jan 2013 11:49:16 +0100 [thread overview]
Message-ID: <50FFC02C.9000109@metafoo.de> (raw)
In-Reply-To: <20130123102755.GP23505@n2100.arm.linux.org.uk>
On 01/23/2013 11:27 AM, Russell King - ARM Linux wrote:
> On Wed, Jan 23, 2013 at 11:00:56AM +0100, Lars-Peter Clausen wrote:
>> I think I read somewhere at some point that ioread{8,16,32} is preferred
>> over write{b,h,l} in new code.
>
> But... there's *no* point using ioread*() if you don't only use the
> ioremap() interface.
>
> ioread*() is there to allow PC IO and PC MMIO accesses through one
> accessor depending on the cookie. ioremap() only ever returns cookies
> for MMIO accesses.
So your point is, if you know that it is MMIO memory only ever use readl and
friends?
- Lars
next prev parent reply other threads:[~2013-01-23 10:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 18:12 [PATCH] clk: Add axi-clkgen driver Lars-Peter Clausen
2013-01-09 18:12 ` Lars-Peter Clausen
2013-01-22 17:55 ` Mike Turquette
2013-01-23 10:00 ` Lars-Peter Clausen
2013-01-23 10:00 ` Lars-Peter Clausen
2013-01-23 10:27 ` Russell King - ARM Linux
2013-01-23 10:27 ` Russell King - ARM Linux
2013-01-23 10:49 ` Lars-Peter Clausen [this message]
2013-01-23 10:49 ` Lars-Peter Clausen
2013-01-23 10:57 ` Russell King - ARM Linux
2013-01-23 10:57 ` Russell King - ARM Linux
2013-01-22 18:08 ` Josh Cartwright
2013-01-22 18:08 ` Josh Cartwright
2013-01-23 9:57 ` Lars-Peter Clausen
2013-01-23 9:57 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FFC02C.9000109@metafoo.de \
--to=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.