From: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH 2/2] cgroup: remove a NULL check in cgroup_exit()
Date: Thu, 24 Jan 2013 14:43:51 +0800 [thread overview]
Message-ID: <5100D827.20807@huawei.com> (raw)
In-Reply-To: <5100D810.5020406-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
init_task.cgroups is initialized at boot phase, and whenver a ask
is forked, it's cgroups pointer is inherited from its parent, and
it's never set to NULL afterwards.
Signed-off-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
kernel/cgroup.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 09c5869..5d4c92e 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -5011,8 +5011,7 @@ void cgroup_exit(struct task_struct *tsk, int run_callbacks)
}
task_unlock(tsk);
- if (cg)
- put_css_set_taskexit(cg);
+ put_css_set_taskexit(cg);
}
/**
--
1.8.0.2
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: cgroups <cgroups@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] cgroup: remove a NULL check in cgroup_exit()
Date: Thu, 24 Jan 2013 14:43:51 +0800 [thread overview]
Message-ID: <5100D827.20807@huawei.com> (raw)
In-Reply-To: <5100D810.5020406@huawei.com>
init_task.cgroups is initialized at boot phase, and whenver a ask
is forked, it's cgroups pointer is inherited from its parent, and
it's never set to NULL afterwards.
Signed-off-by: Li Zefan <lizefan@huawei.com>
---
kernel/cgroup.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 09c5869..5d4c92e 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -5011,8 +5011,7 @@ void cgroup_exit(struct task_struct *tsk, int run_callbacks)
}
task_unlock(tsk);
- if (cg)
- put_css_set_taskexit(cg);
+ put_css_set_taskexit(cg);
}
/**
--
1.8.0.2
next prev parent reply other threads:[~2013-01-24 6:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 6:43 [PATCH 1/2] cgroup: fix exit() vsrmdir() race Li Zefan
2013-01-24 6:43 ` Li Zefan
[not found] ` <5100D810.5020406-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-01-24 6:43 ` Li Zefan [this message]
2013-01-24 6:43 ` [PATCH 2/2] cgroup: remove a NULL check in cgroup_exit() Li Zefan
[not found] ` <5100D827.20807-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-01-24 18:20 ` Tejun Heo
2013-01-24 18:20 ` Tejun Heo
2013-01-24 18:19 ` [PATCH 1/2] cgroup: fix exit() vsrmdir() race Tejun Heo
2013-01-24 18:19 ` Tejun Heo
[not found] ` <20130124181923.GK2373-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-01-24 18:36 ` Tejun Heo
2013-01-24 18:36 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5100D827.20807@huawei.com \
--to=lizefan-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.