All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH for-1.4] target-cris: Fix typo in D_LOG() macro
Date: Thu, 24 Jan 2013 10:53:44 +0100	[thread overview]
Message-ID: <510104A8.1040709@suse.de> (raw)
In-Reply-To: <1359021107-29413-1-git-send-email-afaerber@suse.de>

Am 24.01.2013 10:51, schrieb Andreas Färber:
> It's __VAR_ARGS__. Fixes the build with CRIS_[OP_]HELPER_DEBUG defined.

__VA_ARGS__ obviously. :) Please fix when committing.

Andreas

> 
> Broken since r6338 / 93fcfe39a0383377e647b821c9f165fd927cd4e0 (Convert
> references to logfile/loglevel to use qemu_log*() macros).
> 
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  target-cris/helper.c    |    2 +-
>  target-cris/op_helper.c |    2 +-
>  2 Dateien geändert, 2 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-)
> 
> diff --git a/target-cris/helper.c b/target-cris/helper.c
> index 8407a6d..6e75e98 100644
> --- a/target-cris/helper.c
> +++ b/target-cris/helper.c
> @@ -28,7 +28,7 @@
>  
>  #ifdef CRIS_HELPER_DEBUG
>  #define D(x) x
> -#define D_LOG(...) qemu_log(__VA__ARGS__)
> +#define D_LOG(...) qemu_log(__VA_ARGS__)
>  #else
>  #define D(x)
>  #define D_LOG(...) do { } while (0)
> diff --git a/target-cris/op_helper.c b/target-cris/op_helper.c
> index 79bff38..0f6a1ee 100644
> --- a/target-cris/op_helper.c
> +++ b/target-cris/op_helper.c
> @@ -28,7 +28,7 @@
>  
>  #ifdef CRIS_OP_HELPER_DEBUG
>  #define D(x) x
> -#define D_LOG(...) qemu_log(__VA__ARGS__)
> +#define D_LOG(...) qemu_log(__VA_ARGS__)
>  #else
>  #define D(x)
>  #define D_LOG(...) do { } while (0)
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg


  reply	other threads:[~2013-01-24 10:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-24  9:51 [Qemu-trivial] [PATCH for-1.4] target-cris: Fix typo in D_LOG() macro Andreas Färber
2013-01-24  9:53 ` Andreas Färber [this message]
2013-01-24 10:30 ` Edgar E. Iglesias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=510104A8.1040709@suse.de \
    --to=afaerber@suse.de \
    --cc=edgar.iglesias@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.