* [Qemu-trivial] [PATCH for-1.4] target-cris: Fix typo in D_LOG() macro
@ 2013-01-24 9:51 Andreas Färber
2013-01-24 9:53 ` [Qemu-trivial] [Qemu-devel] " Andreas Färber
2013-01-24 10:30 ` [Qemu-trivial] " Edgar E. Iglesias
0 siblings, 2 replies; 3+ messages in thread
From: Andreas Färber @ 2013-01-24 9:51 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Edgar E. Iglesias, Andreas Färber,
Eduardo Habkost
It's __VAR_ARGS__. Fixes the build with CRIS_[OP_]HELPER_DEBUG defined.
Broken since r6338 / 93fcfe39a0383377e647b821c9f165fd927cd4e0 (Convert
references to logfile/loglevel to use qemu_log*() macros).
Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
target-cris/helper.c | 2 +-
target-cris/op_helper.c | 2 +-
2 Dateien geändert, 2 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-)
diff --git a/target-cris/helper.c b/target-cris/helper.c
index 8407a6d..6e75e98 100644
--- a/target-cris/helper.c
+++ b/target-cris/helper.c
@@ -28,7 +28,7 @@
#ifdef CRIS_HELPER_DEBUG
#define D(x) x
-#define D_LOG(...) qemu_log(__VA__ARGS__)
+#define D_LOG(...) qemu_log(__VA_ARGS__)
#else
#define D(x)
#define D_LOG(...) do { } while (0)
diff --git a/target-cris/op_helper.c b/target-cris/op_helper.c
index 79bff38..0f6a1ee 100644
--- a/target-cris/op_helper.c
+++ b/target-cris/op_helper.c
@@ -28,7 +28,7 @@
#ifdef CRIS_OP_HELPER_DEBUG
#define D(x) x
-#define D_LOG(...) qemu_log(__VA__ARGS__)
+#define D_LOG(...) qemu_log(__VA_ARGS__)
#else
#define D(x)
#define D_LOG(...) do { } while (0)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH for-1.4] target-cris: Fix typo in D_LOG() macro
2013-01-24 9:51 [Qemu-trivial] [PATCH for-1.4] target-cris: Fix typo in D_LOG() macro Andreas Färber
@ 2013-01-24 9:53 ` Andreas Färber
2013-01-24 10:30 ` [Qemu-trivial] " Edgar E. Iglesias
1 sibling, 0 replies; 3+ messages in thread
From: Andreas Färber @ 2013-01-24 9:53 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Edgar E. Iglesias, Eduardo Habkost
Am 24.01.2013 10:51, schrieb Andreas Färber:
> It's __VAR_ARGS__. Fixes the build with CRIS_[OP_]HELPER_DEBUG defined.
__VA_ARGS__ obviously. :) Please fix when committing.
Andreas
>
> Broken since r6338 / 93fcfe39a0383377e647b821c9f165fd927cd4e0 (Convert
> references to logfile/loglevel to use qemu_log*() macros).
>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> target-cris/helper.c | 2 +-
> target-cris/op_helper.c | 2 +-
> 2 Dateien geändert, 2 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-)
>
> diff --git a/target-cris/helper.c b/target-cris/helper.c
> index 8407a6d..6e75e98 100644
> --- a/target-cris/helper.c
> +++ b/target-cris/helper.c
> @@ -28,7 +28,7 @@
>
> #ifdef CRIS_HELPER_DEBUG
> #define D(x) x
> -#define D_LOG(...) qemu_log(__VA__ARGS__)
> +#define D_LOG(...) qemu_log(__VA_ARGS__)
> #else
> #define D(x)
> #define D_LOG(...) do { } while (0)
> diff --git a/target-cris/op_helper.c b/target-cris/op_helper.c
> index 79bff38..0f6a1ee 100644
> --- a/target-cris/op_helper.c
> +++ b/target-cris/op_helper.c
> @@ -28,7 +28,7 @@
>
> #ifdef CRIS_OP_HELPER_DEBUG
> #define D(x) x
> -#define D_LOG(...) qemu_log(__VA__ARGS__)
> +#define D_LOG(...) qemu_log(__VA_ARGS__)
> #else
> #define D(x)
> #define D_LOG(...) do { } while (0)
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-trivial] [PATCH for-1.4] target-cris: Fix typo in D_LOG() macro
2013-01-24 9:51 [Qemu-trivial] [PATCH for-1.4] target-cris: Fix typo in D_LOG() macro Andreas Färber
2013-01-24 9:53 ` [Qemu-trivial] [Qemu-devel] " Andreas Färber
@ 2013-01-24 10:30 ` Edgar E. Iglesias
1 sibling, 0 replies; 3+ messages in thread
From: Edgar E. Iglesias @ 2013-01-24 10:30 UTC (permalink / raw)
To: Andreas Färber; +Cc: qemu-trivial, qemu-devel, Eduardo Habkost
On Thu, Jan 24, 2013 at 10:51:47AM +0100, Andreas Färber wrote:
> It's __VAR_ARGS__. Fixes the build with CRIS_[OP_]HELPER_DEBUG defined.
>
> Broken since r6338 / 93fcfe39a0383377e647b821c9f165fd927cd4e0 (Convert
> references to logfile/loglevel to use qemu_log*() macros).
Applied, thanks!
>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> target-cris/helper.c | 2 +-
> target-cris/op_helper.c | 2 +-
> 2 Dateien geändert, 2 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-)
>
> diff --git a/target-cris/helper.c b/target-cris/helper.c
> index 8407a6d..6e75e98 100644
> --- a/target-cris/helper.c
> +++ b/target-cris/helper.c
> @@ -28,7 +28,7 @@
>
> #ifdef CRIS_HELPER_DEBUG
> #define D(x) x
> -#define D_LOG(...) qemu_log(__VA__ARGS__)
> +#define D_LOG(...) qemu_log(__VA_ARGS__)
> #else
> #define D(x)
> #define D_LOG(...) do { } while (0)
> diff --git a/target-cris/op_helper.c b/target-cris/op_helper.c
> index 79bff38..0f6a1ee 100644
> --- a/target-cris/op_helper.c
> +++ b/target-cris/op_helper.c
> @@ -28,7 +28,7 @@
>
> #ifdef CRIS_OP_HELPER_DEBUG
> #define D(x) x
> -#define D_LOG(...) qemu_log(__VA__ARGS__)
> +#define D_LOG(...) qemu_log(__VA_ARGS__)
> #else
> #define D(x)
> #define D_LOG(...) do { } while (0)
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-24 10:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-24 9:51 [Qemu-trivial] [PATCH for-1.4] target-cris: Fix typo in D_LOG() macro Andreas Färber
2013-01-24 9:53 ` [Qemu-trivial] [Qemu-devel] " Andreas Färber
2013-01-24 10:30 ` [Qemu-trivial] " Edgar E. Iglesias
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.