From: florian@openwrt.org (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/1 net-next] net: fec: add napi support to improve proformance
Date: Thu, 24 Jan 2013 14:11:43 +0100 [thread overview]
Message-ID: <5101330F.3030702@openwrt.org> (raw)
In-Reply-To: <1359014309-8636-1-git-send-email-Frank.Li@freescale.com>
On 01/24/2013 08:58 AM, Frank Li wrote:
65,6 +566,20 @@ fec_timeout(struct net_device *ndev)
> }
>
> static void
> +fec_enet_rx_int_is_enabled(struct net_device *ndev, bool enabled)
> +{
> + struct fec_enet_private *fep = netdev_priv(ndev);
> + uint int_events;
> +
> + int_events = readl(fep->hwp + FEC_IMASK);
> + if (enabled)
> + int_events |= FEC_ENET_RXF;
> + else
> + int_events &= ~FEC_ENET_RXF;
> + writel(int_events, fep->hwp + FEC_IMASK);
> +}
This function is badly named with respect to what it does. A better name
would be fec_enet_rx_interrupt_set() for instance.
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <florian@openwrt.org>
To: Frank Li <Frank.Li@freescale.com>
Cc: lznuaa@gmail.com, shawn.guo@linaro.org, B38611@freescale.com,
davem@davemloft.net, linux-arm-kernel@lists.infradead.org,
netdev@vger.kernel.org, s.hauer@pengutronix.de
Subject: Re: [PATCH v2 1/1 net-next] net: fec: add napi support to improve proformance
Date: Thu, 24 Jan 2013 14:11:43 +0100 [thread overview]
Message-ID: <5101330F.3030702@openwrt.org> (raw)
In-Reply-To: <1359014309-8636-1-git-send-email-Frank.Li@freescale.com>
On 01/24/2013 08:58 AM, Frank Li wrote:
65,6 +566,20 @@ fec_timeout(struct net_device *ndev)
> }
>
> static void
> +fec_enet_rx_int_is_enabled(struct net_device *ndev, bool enabled)
> +{
> + struct fec_enet_private *fep = netdev_priv(ndev);
> + uint int_events;
> +
> + int_events = readl(fep->hwp + FEC_IMASK);
> + if (enabled)
> + int_events |= FEC_ENET_RXF;
> + else
> + int_events &= ~FEC_ENET_RXF;
> + writel(int_events, fep->hwp + FEC_IMASK);
> +}
This function is badly named with respect to what it does. A better name
would be fec_enet_rx_interrupt_set() for instance.
--
Florian
next prev parent reply other threads:[~2013-01-24 13:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 7:58 [PATCH v2 1/1 net-next] net: fec: add napi support to improve proformance Frank Li
2013-01-24 7:58 ` Frank Li
2013-01-24 13:11 ` Florian Fainelli [this message]
2013-01-24 13:11 ` Florian Fainelli
2013-01-24 13:56 ` Eric Dumazet
2013-01-24 13:56 ` Eric Dumazet
2013-01-25 2:02 ` Frank Li
2013-01-25 2:02 ` Frank Li
2013-01-24 17:56 ` Troy Kisky
2013-01-24 17:56 ` Troy Kisky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5101330F.3030702@openwrt.org \
--to=florian@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.