From: Stephen Warren <swarren@wwwdotorg.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: rob.herring@calxeda.com, rob@landley.net, tony@atomide.com,
balbi@ti.com, b-cousson@ti.com, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, gregkh@linuxfoundation.org,
linux@arm.linux.org.uk
Subject: Re: [PATCH v3 1/4] drivers: usb: phy: add a new driver for usb part of control module
Date: Thu, 24 Jan 2013 21:32:46 -0800 [thread overview]
Message-ID: <510218FE.8080606@wwwdotorg.org> (raw)
In-Reply-To: <1359080391-5120-2-git-send-email-kishon@ti.com>
On 01/24/2013 06:19 PM, Kishon Vijay Abraham I wrote:
> Added a new driver for the usb part of control module. This has an API
> to power on the USB2 phy and an API to write to the mailbox depending on
> whether MUSB has to act in host mode or in device mode.
>
> Writing to control module registers for doing the above task which was
> previously done in omap glue and in omap-usb2 phy will be removed.
> diff --git a/Documentation/devicetree/bindings/usb/usb-phy.txt b/Documentation/devicetree/bindings/usb/usb-phy.txt
This file seems to be specific to the TI USB PHYs, not all USB PHYs;
shouldn't it be renamed ti-usb-phy.txt, or even better renamed to match
the compatible value it documents, giving ti,omap-usb2.txt?
> add the address of control module dev conf register until a driver for
> control module is added
>
> +Optional properties:
> + - ctrl_module : phandle of the control module used by PHY driver to power on
> + the PHY.
DT property names generally use - not _ as the word separator.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/4] drivers: usb: phy: add a new driver for usb part of control module
Date: Thu, 24 Jan 2013 21:32:46 -0800 [thread overview]
Message-ID: <510218FE.8080606@wwwdotorg.org> (raw)
In-Reply-To: <1359080391-5120-2-git-send-email-kishon@ti.com>
On 01/24/2013 06:19 PM, Kishon Vijay Abraham I wrote:
> Added a new driver for the usb part of control module. This has an API
> to power on the USB2 phy and an API to write to the mailbox depending on
> whether MUSB has to act in host mode or in device mode.
>
> Writing to control module registers for doing the above task which was
> previously done in omap glue and in omap-usb2 phy will be removed.
> diff --git a/Documentation/devicetree/bindings/usb/usb-phy.txt b/Documentation/devicetree/bindings/usb/usb-phy.txt
This file seems to be specific to the TI USB PHYs, not all USB PHYs;
shouldn't it be renamed ti-usb-phy.txt, or even better renamed to match
the compatible value it documents, giving ti,omap-usb2.txt?
> add the address of control module dev conf register until a driver for
> control module is added
>
> +Optional properties:
> + - ctrl_module : phandle of the control module used by PHY driver to power on
> + the PHY.
DT property names generally use - not _ as the word separator.
next prev parent reply other threads:[~2013-01-25 5:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 2:19 [PATCH v3 0/4] usb: musb/dwc3: add driver for control module Kishon Vijay Abraham I
2013-01-25 2:19 ` Kishon Vijay Abraham I
2013-01-25 2:19 ` Kishon Vijay Abraham I
[not found] ` <1359080391-5120-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-01-25 2:19 ` [PATCH v3 1/4] drivers: usb: phy: add a new driver for usb part of " Kishon Vijay Abraham I
2013-01-25 2:19 ` Kishon Vijay Abraham I
2013-01-25 2:19 ` Kishon Vijay Abraham I
2013-01-25 5:32 ` Stephen Warren [this message]
2013-01-25 5:32 ` Stephen Warren
2013-01-25 7:48 ` Felipe Balbi
2013-01-25 7:48 ` Felipe Balbi
2013-01-25 7:48 ` Felipe Balbi
2013-01-25 8:42 ` kishon
2013-01-25 8:42 ` kishon
2013-01-25 8:42 ` kishon
[not found] ` <51024581.6020301-l0cyMroinI0@public.gmane.org>
2013-01-25 8:45 ` Felipe Balbi
2013-01-25 8:45 ` Felipe Balbi
2013-01-25 8:45 ` Felipe Balbi
2013-01-25 8:46 ` kishon
2013-01-25 8:46 ` kishon
2013-01-25 8:46 ` kishon
2013-01-25 2:19 ` [PATCH v3 2/4] ARM: OMAP: devices: create device " Kishon Vijay Abraham I
2013-01-25 2:19 ` Kishon Vijay Abraham I
2013-01-25 2:19 ` Kishon Vijay Abraham I
2013-01-25 2:19 ` [PATCH v3 3/4] ARM: OMAP2: MUSB: Specify omap4 has mailbox Kishon Vijay Abraham I
2013-01-25 2:19 ` Kishon Vijay Abraham I
2013-01-25 2:19 ` Kishon Vijay Abraham I
2013-01-25 2:19 ` [PATCH v3 4/4] drivers: usb: start using the control module driver Kishon Vijay Abraham I
2013-01-25 2:19 ` Kishon Vijay Abraham I
2013-01-25 2:19 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510218FE.8080606@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.