[PATCH] Display the sector size

[PATCH] Display the sector size

[Paulo Flabiano Smorigo/Brazil/IBM]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

Hi all,

What about show the disk sector size with the disk info?

-- 
Paulo Flabiano Smorigo
Software Engineer
Linux Technology Center - IBM Systems & Technology Group

[-- Attachment #2: grub_display_sector_size.patch --]
[-- Type: text/x-patch, Size: 1058 bytes --]

=== modified file 'ChangeLog'
--- ChangeLog	2013-01-22 17:54:34 +0000
+++ ChangeLog	2013-01-22 17:59:00 +0000
@@ -1,5 +1,10 @@
 2013-01-22  Paulo Flabiano Smorigo <pfsmorigo@br.ibm.com>
 
+	* grub-core/normal/misc.c (grub_normal_print_device_info): Display
+	the sector size.
+
+2013-01-22  Paulo Flabiano Smorigo <pfsmorigo@br.ibm.com>
+
 	Support Openfirmware disks with non-512B sectors.
 
 	* grub-core/disk/ieee1275/ofdisk.c (grub_ofdisk_open): Get the block

=== modified file 'grub-core/normal/misc.c'
--- grub-core/normal/misc.c	2012-05-23 07:10:56 +0000
+++ grub-core/normal/misc.c	2013-01-22 17:55:49 +0000
@@ -119,6 +119,10 @@
       if (dev->disk->partition)
 	grub_printf (_(" - Partition start at %llu"),
 		     (unsigned long long) grub_partition_get_start (dev->disk->partition));
+      
+      if (dev->disk->log_sector_size != 0)
+        grub_printf (_(" - Sector size %u"), 1 << dev->disk->log_sector_size);
+
       if (grub_disk_get_size (dev->disk) == GRUB_DISK_SIZE_UNKNOWN)
 	grub_puts_ (N_(" - Total size unknown"));
       else

Re: [PATCH] Display the sector size

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

On 22.01.2013 19:11, Paulo Flabiano Smorigo/Brazil/IBM wrote:

> Hi all,
> 
> What about show the disk sector size with the disk info?
> 

This is very confusing as the rest of the info is in 512B-units
independently of actual sector size. Do you have an idea how to output
unambigously that all info is in 512B sector? Perhaps output everything
in kibibytes?

> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel



-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]