[PATCH v2 1/2] linux-yocto: added kernel configuration for KVM

[PATCH v2 1/2] linux-yocto: added kernel configuration for KVM

[Mihai Prica]

Signed-off-by: Mihai Prica <mihai.prica@intel.com>
---
 recipes-kernel/linux/linux-yocto_3.4.bbappend |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/recipes-kernel/linux/linux-yocto_3.4.bbappend b/recipes-kernel/linux/linux-yocto_3.4.bbappend
index 5b163ff..6fa02e8 100644
--- a/recipes-kernel/linux/linux-yocto_3.4.bbappend
+++ b/recipes-kernel/linux/linux-yocto_3.4.bbappend
@@ -6,3 +6,8 @@ SRC_URI += "file://xt-checksum.scc \
 	    file://lxc.scc \
 	    "
 
+KERNEL_FEATURES_append = " kvm/qemu-kvm-enable"
+
+module_autoload_kvm = "kvm"
+module_autoload_kvm-amd = "kvm-amd"
+module_autoload_kvm-intel = "kvm-intel"
-- 
1.7.9.5

[PATCH v2 2/2] Created new target:kvm-image-minimal

[Mihai Prica]

Signed-off-by: Mihai Prica <mihai.prica@intel.com>
---
 recipes-extended/images/kvm-image-minimal.bb |   28 ++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 recipes-extended/images/kvm-image-minimal.bb

diff --git a/recipes-extended/images/kvm-image-minimal.bb b/recipes-extended/images/kvm-image-minimal.bb
new file mode 100644
index 0000000..275c43b
--- /dev/null
+++ b/recipes-extended/images/kvm-image-minimal.bb
@@ -0,0 +1,28 @@
+DESCRIPTION = "A minimal kvm image"
+
+IMAGE_INSTALL = " \
+    packagegroup-core-boot \
+    ${ROOTFS_PKGMANAGE_BOOTSTRAP} \
+    qemu \
+    libvirt \
+    libvirt-libvirtd \
+    libvirt-virsh \
+    "
+
+IMAGE_FEATURES += "ssh-server-openssh"
+
+IMAGE_LINGUAS = " "
+
+LICENSE = "MIT"
+
+inherit core-image
+
+IMAGE_ROOTFS_SIZE = "8192"
+
+ROOTFS_POSTPROCESS_COMMAND += "remove_packaging_data_files ; "
+
+PACKAGE_INSTALL_ATTEMPTONLY = "\
+    kernel-module-kvm \
+    kernel-module-kvm-intel \
+    kernel-module-kvm-amd \
+    "
-- 
1.7.9.5

Re: [PATCH v2 2/2] Created new target:kvm-image-minimal

[Lei Yang]

On 01/12/2013 12:27 AM, Mihai Prica wrote:
> Signed-off-by: Mihai Prica<mihai.prica@intel.com>
> ---
>   recipes-extended/images/kvm-image-minimal.bb |   28 ++++++++++++++++++++++++++
>   1 file changed, 28 insertions(+)
>   create mode 100644 recipes-extended/images/kvm-image-minimal.bb
>
> diff --git a/recipes-extended/images/kvm-image-minimal.bb b/recipes-extended/images/kvm-image-minimal.bb
> new file mode 100644
> index 0000000..275c43b
> --- /dev/null
> +++ b/recipes-extended/images/kvm-image-minimal.bb
> @@ -0,0 +1,28 @@
> +DESCRIPTION = "A minimal kvm image"
> +
> +IMAGE_INSTALL = " \
> +    packagegroup-core-boot \
> +    ${ROOTFS_PKGMANAGE_BOOTSTRAP} \
> +    qemu \
> +    libvirt \
> +    libvirt-libvirtd \
> +    libvirt-virsh \
> +    "
> +
> +IMAGE_FEATURES += "ssh-server-openssh"
> +
> +IMAGE_LINGUAS = " "
> +
> +LICENSE = "MIT"
> +
> +inherit core-image
> +
> +IMAGE_ROOTFS_SIZE = "8192"
> +
> +ROOTFS_POSTPROCESS_COMMAND += "remove_packaging_data_files ; "
> +
> +PACKAGE_INSTALL_ATTEMPTONLY = "\
Hi Mibai

can you explain "PACKAGE_INSTALL_ATTEMPTONLY " to me, I just see this 
variable first time

Lei
:-)

> +    kernel-module-kvm \
> +    kernel-module-kvm-intel \
> +    kernel-module-kvm-amd \
> +    "

Re: [PATCH v2 1/2] linux-yocto: added kernel configuration for KVM

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]

On Fri, Jan 11, 2013 at 11:27 AM, Mihai Prica <mihai.prica@intel.com> wrote:

> Signed-off-by: Mihai Prica <mihai.prica@intel.com>
> ---
>  recipes-kernel/linux/linux-yocto_3.4.bbappend |    5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/recipes-kernel/linux/linux-yocto_3.4.bbappend
> b/recipes-kernel/linux/linux-yocto_3.4.bbappend
> index 5b163ff..6fa02e8 100644
> --- a/recipes-kernel/linux/linux-yocto_3.4.bbappend
> +++ b/recipes-kernel/linux/linux-yocto_3.4.bbappend
> @@ -6,3 +6,8 @@ SRC_URI += "file://xt-checksum.scc \
>             file://lxc.scc \
>             "
>
> +KERNEL_FEATURES_append = " kvm/qemu-kvm-enable"
>

Have you confirmed that this is adding the option you want ? I would have
expected this to be:

KERNEL_FEATURES_append = " features/kvm/qemu-kvm-enable.scc"



> +
> +module_autoload_kvm = "kvm"
> +module_autoload_kvm-amd = "kvm-amd"
> +module_autoload_kvm-intel = "kvm-intel"
>

This part looks fine though.

Cheers,

Bruce


> --
> 1.7.9.5
>
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 2633 bytes --]

Re: [PATCH v2 1/2] linux-yocto: added kernel configuration for KVM

[lei yang]

On Fri, Jan 11, 2013 at 1:08 PM, Bruce Ashfield
<bruce.ashfield@gmail.com> wrote:
> On Fri, Jan 11, 2013 at 11:27 AM, Mihai Prica <mihai.prica@intel.com> wrote:
>>
>> Signed-off-by: Mihai Prica <mihai.prica@intel.com>
>> ---
>>  recipes-kernel/linux/linux-yocto_3.4.bbappend |    5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/recipes-kernel/linux/linux-yocto_3.4.bbappend
>> b/recipes-kernel/linux/linux-yocto_3.4.bbappend
>> index 5b163ff..6fa02e8 100644
>> --- a/recipes-kernel/linux/linux-yocto_3.4.bbappend
>> +++ b/recipes-kernel/linux/linux-yocto_3.4.bbappend
>> @@ -6,3 +6,8 @@ SRC_URI += "file://xt-checksum.scc \
>>             file://lxc.scc \
>>             "
>>
>> +KERNEL_FEATURES_append = " kvm/qemu-kvm-enable"
>
>
> Have you confirmed that this is adding the option you want ? I would have
> expected this to be:
>
> KERNEL_FEATURES_append = " features/kvm/qemu-kvm-enable.scc"
>
>

Hi Bruce,

I also notice this, I did a serch in internal layer just found below
in wr-kernel use the same way

templates/feature/libhugetlbfs/template.conf:KERNEL_FEATURES_append +=
"features/hugetlb"

I don't know if there is defect for this, both work or not,or we like
.scc is there(coding style)

I'm glad to do a test later.

Lei


>>
>> +
>> +module_autoload_kvm = "kvm"
>> +module_autoload_kvm-amd = "kvm-amd"
>> +module_autoload_kvm-intel = "kvm-intel"
>
>
> This part looks fine though.
>
> Cheers,
>
> Bruce
>
>>
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> meta-virtualization mailing list
>> meta-virtualization@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-virtualization
>
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await thee at
> its end"
>
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
>

Re: [PATCH v2 1/2] linux-yocto: added kernel configuration for KVM

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 2726 bytes --]

On Sat, Jan 12, 2013 at 1:08 AM, lei yang <yanglei.fage@gmail.com> wrote:

> On Fri, Jan 11, 2013 at 1:08 PM, Bruce Ashfield
> <bruce.ashfield@gmail.com> wrote:
> > On Fri, Jan 11, 2013 at 11:27 AM, Mihai Prica <mihai.prica@intel.com>
> wrote:
> >>
> >> Signed-off-by: Mihai Prica <mihai.prica@intel.com>
> >> ---
> >>  recipes-kernel/linux/linux-yocto_3.4.bbappend |    5 +++++
> >>  1 file changed, 5 insertions(+)
> >>
> >> diff --git a/recipes-kernel/linux/linux-yocto_3.4.bbappend
> >> b/recipes-kernel/linux/linux-yocto_3.4.bbappend
> >> index 5b163ff..6fa02e8 100644
> >> --- a/recipes-kernel/linux/linux-yocto_3.4.bbappend
> >> +++ b/recipes-kernel/linux/linux-yocto_3.4.bbappend
> >> @@ -6,3 +6,8 @@ SRC_URI += "file://xt-checksum.scc \
> >>             file://lxc.scc \
> >>             "
> >>
> >> +KERNEL_FEATURES_append = " kvm/qemu-kvm-enable"
> >
> >
> > Have you confirmed that this is adding the option you want ? I would have
> > expected this to be:
> >
> > KERNEL_FEATURES_append = " features/kvm/qemu-kvm-enable.scc"
> >
> >
>
> Hi Bruce,
>
> I also notice this, I did a serch in internal layer just found below
> in wr-kernel use the same way
>
> templates/feature/libhugetlbfs/template.conf:KERNEL_FEATURES_append +=
> "features/hugetlb"
>
> I don't know if there is defect for this, both work or not,or we like
> .scc is there(coding style)
>

They style is an older way of doing things. I have a yocto 1.4 bugzilla
entry to convert
all cases of features that do not end with ".scc" to the more explicit
format that includes
the extension.

So no need to do anything special, but just keep in mind to use ".scc" when
possible,
and eventually existing features will be converted.

Cheers,

Bruce


>
> I'm glad to do a test later.
>
> Lei
>
>
> >>
> >> +
> >> +module_autoload_kvm = "kvm"
> >> +module_autoload_kvm-amd = "kvm-amd"
> >> +module_autoload_kvm-intel = "kvm-intel"
> >
> >
> > This part looks fine though.
> >
> > Cheers,
> >
> > Bruce
> >
> >>
> >> --
> >> 1.7.9.5
> >>
> >> _______________________________________________
> >> meta-virtualization mailing list
> >> meta-virtualization@yoctoproject.org
> >> https://lists.yoctoproject.org/listinfo/meta-virtualization
> >
> >
> >
> >
> > --
> > "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at
> > its end"
> >
> > _______________________________________________
> > meta-virtualization mailing list
> > meta-virtualization@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-virtualization
> >
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 4466 bytes --]

Re: [PATCH v2 2/2] Created new target:kvm-image-minimal

[Prica, Mihai]

> -----Original Message-----
> From: Lei Yang [mailto:lei.yang@windriver.com]
> Sent: Friday, January 11, 2013 7:17 PM
> To: Prica, Mihai
> Cc: meta-virtualization@yoctoproject.org
> Subject: Re: [meta-virtualization] [PATCH v2 2/2] Created new target:kvm-image-
> minimal
> 
> On 01/12/2013 12:27 AM, Mihai Prica wrote:
> > Signed-off-by: Mihai Prica<mihai.prica@intel.com>
> > ---
> >   recipes-extended/images/kvm-image-minimal.bb |   28
> ++++++++++++++++++++++++++
> >   1 file changed, 28 insertions(+)
> >   create mode 100644 recipes-extended/images/kvm-image-minimal.bb
> >
> > diff --git a/recipes-extended/images/kvm-image-minimal.bb
> > b/recipes-extended/images/kvm-image-minimal.bb
> > new file mode 100644
> > index 0000000..275c43b
> > --- /dev/null
> > +++ b/recipes-extended/images/kvm-image-minimal.bb
> > @@ -0,0 +1,28 @@
> > +DESCRIPTION = "A minimal kvm image"
> > +
> > +IMAGE_INSTALL = " \
> > +    packagegroup-core-boot \
> > +    ${ROOTFS_PKGMANAGE_BOOTSTRAP} \
> > +    qemu \
> > +    libvirt \
> > +    libvirt-libvirtd \
> > +    libvirt-virsh \
> > +    "
> > +
> > +IMAGE_FEATURES += "ssh-server-openssh"
> > +
> > +IMAGE_LINGUAS = " "
> > +
> > +LICENSE = "MIT"
> > +
> > +inherit core-image
> > +
> > +IMAGE_ROOTFS_SIZE = "8192"
> > +
> > +ROOTFS_POSTPROCESS_COMMAND += "remove_packaging_data_files ; "
> > +
> > +PACKAGE_INSTALL_ATTEMPTONLY = "\
> Hi Mibai
> 
> can you explain "PACKAGE_INSTALL_ATTEMPTONLY " to me, I just see this
> variable first time

In an image recipe you can't use RRECOMMENDS to specify a list of packages that extend the usability of the image being built.  In this type of recipe you can use PACKAGE_INSTALL_ATTEMPTONLY that has the same functionality.

Thanks,
Mihai
> 
> Lei
> :-)
> 
> > +    kernel-module-kvm \
> > +    kernel-module-kvm-intel \
> > +    kernel-module-kvm-amd \
> > +    "

Re: [PATCH v2 2/2] Created new target:kvm-image-minimal

[lei yang]

On 01/15/2013 06:44 PM, Prica, Mihai wrote:
>> -----Original Message-----
>> From: Lei Yang [mailto:lei.yang@windriver.com]
>> Sent: Friday, January 11, 2013 7:17 PM
>> To: Prica, Mihai
>> Cc: meta-virtualization@yoctoproject.org
>> Subject: Re: [meta-virtualization] [PATCH v2 2/2] Created new target:kvm-image-
>> minimal
>>
>> On 01/12/2013 12:27 AM, Mihai Prica wrote:
>>> Signed-off-by: Mihai Prica<mihai.prica@intel.com>
>>> ---
>>>    recipes-extended/images/kvm-image-minimal.bb |   28
>> ++++++++++++++++++++++++++
>>>    1 file changed, 28 insertions(+)
>>>    create mode 100644 recipes-extended/images/kvm-image-minimal.bb
>>>
>>> diff --git a/recipes-extended/images/kvm-image-minimal.bb
>>> b/recipes-extended/images/kvm-image-minimal.bb
>>> new file mode 100644
>>> index 0000000..275c43b
>>> --- /dev/null
>>> +++ b/recipes-extended/images/kvm-image-minimal.bb
>>> @@ -0,0 +1,28 @@
>>> +DESCRIPTION = "A minimal kvm image"
>>> +
>>> +IMAGE_INSTALL = " \
>>> +    packagegroup-core-boot \
>>> +    ${ROOTFS_PKGMANAGE_BOOTSTRAP} \
>>> +    qemu \
>>> +    libvirt \
>>> +    libvirt-libvirtd \
>>> +    libvirt-virsh \
>>> +    "
>>> +
>>> +IMAGE_FEATURES += "ssh-server-openssh"
>>> +
>>> +IMAGE_LINGUAS = " "
>>> +
>>> +LICENSE = "MIT"
>>> +
>>> +inherit core-image
>>> +
>>> +IMAGE_ROOTFS_SIZE = "8192"
>>> +
>>> +ROOTFS_POSTPROCESS_COMMAND += "remove_packaging_data_files ; "
>>> +
>>> +PACKAGE_INSTALL_ATTEMPTONLY = "\
>> Hi Mibai
>>
>> can you explain "PACKAGE_INSTALL_ATTEMPTONLY " to me, I just see this
>> variable first time
> In an image recipe you can't use RRECOMMENDS to specify a list of packages that extend the usability of the image being built.  In this type of recipe you can use PACKAGE_INSTALL_ATTEMPTONLY that has the same functionality.

I don't know why RRECOMMENDS can't be used in image recipes, How about 
"IMAGE_INSTALL", this is always used

Lei




> Thanks,
> Mihai
>> Lei
>> :-)
>>
>>> +    kernel-module-kvm \
>>> +    kernel-module-kvm-intel \
>>> +    kernel-module-kvm-amd \
>>> +    "

Re: [PATCH v2 2/2] Created new target:kvm-image-minimal

[lei yang]

On 01/15/2013 06:44 PM, Prica, Mihai wrote:
>> -----Original Message-----
>> From: Lei Yang [mailto:lei.yang@windriver.com]
>> Sent: Friday, January 11, 2013 7:17 PM
>> To: Prica, Mihai
>> Cc: meta-virtualization@yoctoproject.org
>> Subject: Re: [meta-virtualization] [PATCH v2 2/2] Created new target:kvm-image-
>> minimal
>>
>> On 01/12/2013 12:27 AM, Mihai Prica wrote:
>>> Signed-off-by: Mihai Prica<mihai.prica@intel.com>
>>> ---
>>>    recipes-extended/images/kvm-image-minimal.bb |   28
>> ++++++++++++++++++++++++++
>>>    1 file changed, 28 insertions(+)
>>>    create mode 100644 recipes-extended/images/kvm-image-minimal.bb
>>>
>>> diff --git a/recipes-extended/images/kvm-image-minimal.bb
>>> b/recipes-extended/images/kvm-image-minimal.bb
>>> new file mode 100644
>>> index 0000000..275c43b
>>> --- /dev/null
>>> +++ b/recipes-extended/images/kvm-image-minimal.bb
>>> @@ -0,0 +1,28 @@
>>> +DESCRIPTION = "A minimal kvm image"
>>> +
>>> +IMAGE_INSTALL = " \
>>> +    packagegroup-core-boot \
>>> +    ${ROOTFS_PKGMANAGE_BOOTSTRAP} \
>>> +    qemu \
>>> +    libvirt \
>>> +    libvirt-libvirtd \
>>> +    libvirt-virsh \
>>> +    "
>>> +
>>> +IMAGE_FEATURES += "ssh-server-openssh"
>>> +
>>> +IMAGE_LINGUAS = " "
>>> +
>>> +LICENSE = "MIT"
>>> +
>>> +inherit core-image
>>> +
>>> +IMAGE_ROOTFS_SIZE = "8192"
>>> +
>>> +ROOTFS_POSTPROCESS_COMMAND += "remove_packaging_data_files ; "
>>> +
>>> +PACKAGE_INSTALL_ATTEMPTONLY = "\
>> Hi Mibai
>>
>> can you explain "PACKAGE_INSTALL_ATTEMPTONLY " to me, I just see this
>> variable first time
> In an image recipe you can't use RRECOMMENDS to specify a list of packages that extend the usability of the image being built.  In this type of recipe you can use PACKAGE_INSTALL_ATTEMPTONLY that has the same functionality.

and I think both can be used, from below, it tells me, they can perform 
the same function, do you try RRECOMEEDS and meet an error?

lyang001@lyang0-9010:~/intel-xeon-core/layers/oe-core/meta/classes$ cat 
image.bbclass |grep -E "^RRECOM|^PACKAGE_INSTALL_ATTEMPTONLY"
RRECOMMENDS += "${NORMAL_FEATURE_INSTALL_OPTIONAL}"
PACKAGE_INSTALL_ATTEMPTONLY ?= "${FEATURE_INSTALL_OPTIONAL}"


  Lei



> Thanks,
> Mihai
>> Lei
>> :-)
>>
>>> +    kernel-module-kvm \
>>> +    kernel-module-kvm-intel \
>>> +    kernel-module-kvm-amd \
>>> +    "

Re: [PATCH v2 2/2] Created new target:kvm-image-minimal

[Prica, Mihai]

> -----Original Message-----
> From: lei yang [mailto:lei.yang@windriver.com]
> Sent: Wednesday, January 16, 2013 5:28 AM
> To: Prica, Mihai
> Cc: meta-virtualization@yoctoproject.org
> Subject: Re: [meta-virtualization] [PATCH v2 2/2] Created new target:kvm-image-
> minimal
> 
> On 01/15/2013 06:44 PM, Prica, Mihai wrote:
> >> -----Original Message-----
> >> From: Lei Yang [mailto:lei.yang@windriver.com]
> >> Sent: Friday, January 11, 2013 7:17 PM
> >> To: Prica, Mihai
> >> Cc: meta-virtualization@yoctoproject.org
> >> Subject: Re: [meta-virtualization] [PATCH v2 2/2] Created new
> >> target:kvm-image- minimal
> >>
> >> On 01/12/2013 12:27 AM, Mihai Prica wrote:
> >>> Signed-off-by: Mihai Prica<mihai.prica@intel.com>
> >>> ---
> >>>    recipes-extended/images/kvm-image-minimal.bb |   28
> >> ++++++++++++++++++++++++++
> >>>    1 file changed, 28 insertions(+)
> >>>    create mode 100644 recipes-extended/images/kvm-image-minimal.bb
> >>>
> >>> diff --git a/recipes-extended/images/kvm-image-minimal.bb
> >>> b/recipes-extended/images/kvm-image-minimal.bb
> >>> new file mode 100644
> >>> index 0000000..275c43b
> >>> --- /dev/null
> >>> +++ b/recipes-extended/images/kvm-image-minimal.bb
> >>> @@ -0,0 +1,28 @@
> >>> +DESCRIPTION = "A minimal kvm image"
> >>> +
> >>> +IMAGE_INSTALL = " \
> >>> +    packagegroup-core-boot \
> >>> +    ${ROOTFS_PKGMANAGE_BOOTSTRAP} \
> >>> +    qemu \
> >>> +    libvirt \
> >>> +    libvirt-libvirtd \
> >>> +    libvirt-virsh \
> >>> +    "
> >>> +
> >>> +IMAGE_FEATURES += "ssh-server-openssh"
> >>> +
> >>> +IMAGE_LINGUAS = " "
> >>> +
> >>> +LICENSE = "MIT"
> >>> +
> >>> +inherit core-image
> >>> +
> >>> +IMAGE_ROOTFS_SIZE = "8192"
> >>> +
> >>> +ROOTFS_POSTPROCESS_COMMAND += "remove_packaging_data_files ; "
> >>> +
> >>> +PACKAGE_INSTALL_ATTEMPTONLY = "\
> >> Hi Mibai
> >>
> >> can you explain "PACKAGE_INSTALL_ATTEMPTONLY " to me, I just see this
> >> variable first time
> > In an image recipe you can't use RRECOMMENDS to specify a list of packages
> that extend the usability of the image being built.  In this type of recipe you can
> use PACKAGE_INSTALL_ATTEMPTONLY that has the same functionality.
> 
> and I think both can be used, from below, it tells me, they can perform the same
> function, do you try RRECOMEEDS and meet an error?

I tried using RRECOMMENDS. I didn't get any errors but the kernel modules were not loaded onto the image. I tried a number of times to be sure it's because of the shared state, but with the same result. With PACAKAGE_INSTALL_ATTEMPTONLY it worked.

> 
> lyang001@lyang0-9010:~/intel-xeon-core/layers/oe-core/meta/classes$ cat
> image.bbclass |grep -E "^RRECOM|^PACKAGE_INSTALL_ATTEMPTONLY"
> RRECOMMENDS += "${NORMAL_FEATURE_INSTALL_OPTIONAL}"
> PACKAGE_INSTALL_ATTEMPTONLY ?= "${FEATURE_INSTALL_OPTIONAL}"
> 
> 
>   Lei
> 
> 
> 
> > Thanks,
> > Mihai
> >> Lei
> >> :-)
> >>
> >>> +    kernel-module-kvm \
> >>> +    kernel-module-kvm-intel \
> >>> +    kernel-module-kvm-amd \
> >>> +    "

Re: [PATCH v2 1/2] linux-yocto: added kernel configuration for KVM

[Prica, Mihai]

> From: Bruce Ashfield [mailto:bruce.ashfield@gmail.com] 
> Sent: Sunday, January 13, 2013 4:49 PM
> To: lei yang
> Cc: Prica, Mihai; meta-virtualization@yoctoproject.org
> Subject: Re: [meta-virtualization] [PATCH v2 1/2] linux-yocto: added kernel configuration for KVM
>
>
>
> On Sat, Jan 12, 2013 at 1:08 AM, lei yang <yanglei.fage@gmail.com> wrote:
> On Fri, Jan 11, 2013 at 1:08 PM, Bruce Ashfield
> <bruce.ashfield@gmail.com> wrote:
> > On Fri, Jan 11, 2013 at 11:27 AM, Mihai Prica <mihai.prica@intel.com> wrote:
> >>
>> Signed-off-by: Mihai Prica <mihai.prica@intel.com>
>> ---
>>  recipes-kernel/linux/linux-yocto_3.4.bbappend |    5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/recipes-kernel/linux/linux-yocto_3.4.bbappend
>> b/recipes-kernel/linux/linux-yocto_3.4.bbappend
>> index 5b163ff..6fa02e8 100644
>> --- a/recipes-kernel/linux/linux-yocto_3.4.bbappend
>> +++ b/recipes-kernel/linux/linux-yocto_3.4.bbappend
>> @@ -6,3 +6,8 @@ SRC_URI += "file://xt-checksum.scc \
>>             file://lxc.scc \
>>             "
>>
>> +KERNEL_FEATURES_append = " kvm/qemu-kvm-enable"
>
>
> Have you confirmed that this is adding the option you want ? I would have
> expected this to be:
>
> KERNEL_FEATURES_append = " features/kvm/qemu-kvm-enable.scc"
>
>
> Hi Bruce,
>
> I also notice this, I did a serch in internal layer just found below
> in wr-kernel use the same way
>
> templates/feature/libhugetlbfs/template.conf:KERNEL_FEATURES_append +=
> "features/hugetlb"
>
> I don't know if there is defect for this, both work or not,or we like
>.scc is there(coding style)
>
> They style is an older way of doing things. I have a yocto 1.4 bugzilla entry to convert
> all cases of features that do not end with ".scc" to the more explicit format that includes
> the extension.
>
> So no need to do anything special, but just keep in mind to use ".scc" when possible, 
> and eventually existing features will be converted.
>
> Cheers,
>
> Bruce

I see that this hasn't been merged to master. Do I have to redo this  with "features/kvm/qemu-kvm-enable.scc" ?

Mihai

> I'm glad to do a test later.
>
> Lei
>
>
>>
>> +
>> +module_autoload_kvm = "kvm"
>> +module_autoload_kvm-amd = "kvm-amd"
>> +module_autoload_kvm-intel = "kvm-intel"
>
>
> This part looks fine though.
>
> Cheers,
>
> Bruce
>
>>
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> meta-virtualization mailing list
>> meta-virtualization@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-virtualization
>
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await thee at
> its end"
>
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
>




-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end" 

Re: [PATCH v2 2/2] Created new target:kvm-image-minimal

[Prica, Mihai]

> -----Original Message-----
> From: meta-virtualization-bounces@yoctoproject.org [mailto:meta-virtualization-
> bounces@yoctoproject.org] On Behalf Of Prica, Mihai
> Sent: Wednesday, January 16, 2013 3:59 PM
> To: lei yang
> Cc: meta-virtualization@yoctoproject.org
> Subject: Re: [meta-virtualization] [PATCH v2 2/2] Created new target:kvm-image-
> minimal
> 
> > -----Original Message-----
> > From: lei yang [mailto:lei.yang@windriver.com]
> > Sent: Wednesday, January 16, 2013 5:28 AM
> > To: Prica, Mihai
> > Cc: meta-virtualization@yoctoproject.org
> > Subject: Re: [meta-virtualization] [PATCH v2 2/2] Created new
> > target:kvm-image- minimal
> >
> > On 01/15/2013 06:44 PM, Prica, Mihai wrote:
> > >> -----Original Message-----
> > >> From: Lei Yang [mailto:lei.yang@windriver.com]
> > >> Sent: Friday, January 11, 2013 7:17 PM
> > >> To: Prica, Mihai
> > >> Cc: meta-virtualization@yoctoproject.org
> > >> Subject: Re: [meta-virtualization] [PATCH v2 2/2] Created new
> > >> target:kvm-image- minimal
> > >>
> > >> On 01/12/2013 12:27 AM, Mihai Prica wrote:
> > >>> Signed-off-by: Mihai Prica<mihai.prica@intel.com>
> > >>> ---
> > >>>    recipes-extended/images/kvm-image-minimal.bb |   28
> > >> ++++++++++++++++++++++++++
> > >>>    1 file changed, 28 insertions(+)
> > >>>    create mode 100644 recipes-extended/images/kvm-image-minimal.bb
> > >>>
> > >>> diff --git a/recipes-extended/images/kvm-image-minimal.bb
> > >>> b/recipes-extended/images/kvm-image-minimal.bb
> > >>> new file mode 100644
> > >>> index 0000000..275c43b
> > >>> --- /dev/null
> > >>> +++ b/recipes-extended/images/kvm-image-minimal.bb
> > >>> @@ -0,0 +1,28 @@
> > >>> +DESCRIPTION = "A minimal kvm image"
> > >>> +
> > >>> +IMAGE_INSTALL = " \
> > >>> +    packagegroup-core-boot \
> > >>> +    ${ROOTFS_PKGMANAGE_BOOTSTRAP} \
> > >>> +    qemu \
> > >>> +    libvirt \
> > >>> +    libvirt-libvirtd \
> > >>> +    libvirt-virsh \
> > >>> +    "
> > >>> +
> > >>> +IMAGE_FEATURES += "ssh-server-openssh"
> > >>> +
> > >>> +IMAGE_LINGUAS = " "
> > >>> +
> > >>> +LICENSE = "MIT"
> > >>> +
> > >>> +inherit core-image
> > >>> +
> > >>> +IMAGE_ROOTFS_SIZE = "8192"
> > >>> +
> > >>> +ROOTFS_POSTPROCESS_COMMAND += "remove_packaging_data_files ;
> "
> > >>> +
> > >>> +PACKAGE_INSTALL_ATTEMPTONLY = "\
> > >> Hi Mibai
> > >>
> > >> can you explain "PACKAGE_INSTALL_ATTEMPTONLY " to me, I just see
> > >> this variable first time
> > > In an image recipe you can't use RRECOMMENDS to specify a list of
> > > packages
> > that extend the usability of the image being built.  In this type of
> > recipe you can use PACKAGE_INSTALL_ATTEMPTONLY that has the same
> functionality.
> >
> > and I think both can be used, from below, it tells me, they can
> > perform the same function, do you try RRECOMEEDS and meet an error?
> 
> I tried using RRECOMMENDS. I didn't get any errors but the kernel modules were
> not loaded onto the image. I tried a number of times to be sure it's because of
> the shared state, but with the same result. With
> PACAKAGE_INSTALL_ATTEMPTONLY it worked.

I see this hasn't been merged to master yet. Is there a specific reason for this ? Maybe it's something I'm missing.

Mihai

> 
> >
> > lyang001@lyang0-9010:~/intel-xeon-core/layers/oe-core/meta/classes$
> > cat image.bbclass |grep -E "^RRECOM|^PACKAGE_INSTALL_ATTEMPTONLY"
> > RRECOMMENDS += "${NORMAL_FEATURE_INSTALL_OPTIONAL}"
> > PACKAGE_INSTALL_ATTEMPTONLY ?= "${FEATURE_INSTALL_OPTIONAL}"
> >
> >
> >   Lei
> >
> >
> >
> > > Thanks,
> > > Mihai
> > >> Lei
> > >> :-)
> > >>
> > >>> +    kernel-module-kvm \
> > >>> +    kernel-module-kvm-intel \
> > >>> +    kernel-module-kvm-amd \
> > >>> +    "
> 
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization

Re: [PATCH v2 1/2] linux-yocto: added kernel configuration for KVM

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 3658 bytes --]

On Fri, Jan 25, 2013 at 10:48 AM, Prica, Mihai <mihai.prica@intel.com>wrote:

>
>
> > From: Bruce Ashfield [mailto:bruce.ashfield@gmail.com]
> > Sent: Sunday, January 13, 2013 4:49 PM
> > To: lei yang
> > Cc: Prica, Mihai; meta-virtualization@yoctoproject.org
> > Subject: Re: [meta-virtualization] [PATCH v2 1/2] linux-yocto: added
> kernel configuration for KVM
> >
> >
> >
> > On Sat, Jan 12, 2013 at 1:08 AM, lei yang <yanglei.fage@gmail.com>
> wrote:
> > On Fri, Jan 11, 2013 at 1:08 PM, Bruce Ashfield
> > <bruce.ashfield@gmail.com> wrote:
> > > On Fri, Jan 11, 2013 at 11:27 AM, Mihai Prica <mihai.prica@intel.com>
> wrote:
> > >>
> >> Signed-off-by: Mihai Prica <mihai.prica@intel.com>
> >> ---
> >>  recipes-kernel/linux/linux-yocto_3.4.bbappend |    5 +++++
> >>  1 file changed, 5 insertions(+)
> >>
> >> diff --git a/recipes-kernel/linux/linux-yocto_3.4.bbappend
> >> b/recipes-kernel/linux/linux-yocto_3.4.bbappend
> >> index 5b163ff..6fa02e8 100644
> >> --- a/recipes-kernel/linux/linux-yocto_3.4.bbappend
> >> +++ b/recipes-kernel/linux/linux-yocto_3.4.bbappend
> >> @@ -6,3 +6,8 @@ SRC_URI += "file://xt-checksum.scc \
> >>             file://lxc.scc \
> >>             "
> >>
> >> +KERNEL_FEATURES_append = " kvm/qemu-kvm-enable"
> >
> >
> > Have you confirmed that this is adding the option you want ? I would have
> > expected this to be:
> >
> > KERNEL_FEATURES_append = " features/kvm/qemu-kvm-enable.scc"
> >
> >
> > Hi Bruce,
> >
> > I also notice this, I did a serch in internal layer just found below
> > in wr-kernel use the same way
> >
> > templates/feature/libhugetlbfs/template.conf:KERNEL_FEATURES_append +=
> > "features/hugetlb"
> >
> > I don't know if there is defect for this, both work or not,or we like
> >.scc is there(coding style)
> >
> > They style is an older way of doing things. I have a yocto 1.4 bugzilla
> entry to convert
> > all cases of features that do not end with ".scc" to the more explicit
> format that includes
> > the extension.
> >
> > So no need to do anything special, but just keep in mind to use ".scc"
> when possible,
> > and eventually existing features will be converted.
> >
> > Cheers,
> >
> > Bruce
>
> I see that this hasn't been merged to master. Do I have to redo this  with
> "features/kvm/qemu-kvm-enable.scc" ?
>
>
Hmm. Sorry for letting this sit idle. Yes, let's make that change and I'll
do the
merge. I've recently converted all includes to be explicit, so having this
in the
same format is important.

Cheers,

Bruce


> Mihai
>
> > I'm glad to do a test later.
> >
> > Lei
> >
> >
> >>
> >> +
> >> +module_autoload_kvm = "kvm"
> >> +module_autoload_kvm-amd = "kvm-amd"
> >> +module_autoload_kvm-intel = "kvm-intel"
> >
> >
> > This part looks fine though.
> >
> > Cheers,
> >
> > Bruce
> >
> >>
> >> --
> >> 1.7.9.5
> >>
> >> _______________________________________________
> >> meta-virtualization mailing list
> >> meta-virtualization@yoctoproject.org
> >> https://lists.yoctoproject.org/listinfo/meta-virtualization
> >
> >
> >
> >
> > --
> > "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at
> > its end"
> >
> > _______________________________________________
> > meta-virtualization mailing list
> > meta-virtualization@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-virtualization
> >
>
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end"
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 5769 bytes --]

Re: [PATCH v2 2/2] Created new target:kvm-image-minimal

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 4771 bytes --]

On Fri, Jan 25, 2013 at 10:58 AM, Prica, Mihai <mihai.prica@intel.com>wrote:

> > -----Original Message-----
> > From: meta-virtualization-bounces@yoctoproject.org [mailto:
> meta-virtualization-
> > bounces@yoctoproject.org] On Behalf Of Prica, Mihai
> > Sent: Wednesday, January 16, 2013 3:59 PM
> > To: lei yang
> > Cc: meta-virtualization@yoctoproject.org
> > Subject: Re: [meta-virtualization] [PATCH v2 2/2] Created new
> target:kvm-image-
> > minimal
> >
> > > -----Original Message-----
> > > From: lei yang [mailto:lei.yang@windriver.com]
> > > Sent: Wednesday, January 16, 2013 5:28 AM
> > > To: Prica, Mihai
> > > Cc: meta-virtualization@yoctoproject.org
> > > Subject: Re: [meta-virtualization] [PATCH v2 2/2] Created new
> > > target:kvm-image- minimal
> > >
> > > On 01/15/2013 06:44 PM, Prica, Mihai wrote:
> > > >> -----Original Message-----
> > > >> From: Lei Yang [mailto:lei.yang@windriver.com]
> > > >> Sent: Friday, January 11, 2013 7:17 PM
> > > >> To: Prica, Mihai
> > > >> Cc: meta-virtualization@yoctoproject.org
> > > >> Subject: Re: [meta-virtualization] [PATCH v2 2/2] Created new
> > > >> target:kvm-image- minimal
> > > >>
> > > >> On 01/12/2013 12:27 AM, Mihai Prica wrote:
> > > >>> Signed-off-by: Mihai Prica<mihai.prica@intel.com>
> > > >>> ---
> > > >>>    recipes-extended/images/kvm-image-minimal.bb |   28
> > > >> ++++++++++++++++++++++++++
> > > >>>    1 file changed, 28 insertions(+)
> > > >>>    create mode 100644 recipes-extended/images/kvm-image-minimal.bb
> > > >>>
> > > >>> diff --git a/recipes-extended/images/kvm-image-minimal.bb
> > > >>> b/recipes-extended/images/kvm-image-minimal.bb
> > > >>> new file mode 100644
> > > >>> index 0000000..275c43b
> > > >>> --- /dev/null
> > > >>> +++ b/recipes-extended/images/kvm-image-minimal.bb
> > > >>> @@ -0,0 +1,28 @@
> > > >>> +DESCRIPTION = "A minimal kvm image"
> > > >>> +
> > > >>> +IMAGE_INSTALL = " \
> > > >>> +    packagegroup-core-boot \
> > > >>> +    ${ROOTFS_PKGMANAGE_BOOTSTRAP} \
> > > >>> +    qemu \
> > > >>> +    libvirt \
> > > >>> +    libvirt-libvirtd \
> > > >>> +    libvirt-virsh \
> > > >>> +    "
> > > >>> +
> > > >>> +IMAGE_FEATURES += "ssh-server-openssh"
> > > >>> +
> > > >>> +IMAGE_LINGUAS = " "
> > > >>> +
> > > >>> +LICENSE = "MIT"
> > > >>> +
> > > >>> +inherit core-image
> > > >>> +
> > > >>> +IMAGE_ROOTFS_SIZE = "8192"
> > > >>> +
> > > >>> +ROOTFS_POSTPROCESS_COMMAND += "remove_packaging_data_files ;
> > "
> > > >>> +
> > > >>> +PACKAGE_INSTALL_ATTEMPTONLY = "\
> > > >> Hi Mibai
> > > >>
> > > >> can you explain "PACKAGE_INSTALL_ATTEMPTONLY " to me, I just see
> > > >> this variable first time
> > > > In an image recipe you can't use RRECOMMENDS to specify a list of
> > > > packages
> > > that extend the usability of the image being built.  In this type of
> > > recipe you can use PACKAGE_INSTALL_ATTEMPTONLY that has the same
> > functionality.
> > >
> > > and I think both can be used, from below, it tells me, they can
> > > perform the same function, do you try RRECOMEEDS and meet an error?
> >
> > I tried using RRECOMMENDS. I didn't get any errors but the kernel
> modules were
> > not loaded onto the image. I tried a number of times to be sure it's
> because of
> > the shared state, but with the same result. With
> > PACAKAGE_INSTALL_ATTEMPTONLY it worked.
>
> I see this hasn't been merged to master yet. Is there a specific reason
> for this ? Maybe it's something I'm missing.
>
>
No reason, except I had mentally tied it to the other patch you just ping'd
about.
Resend both (with the minor tweak to the enable .scc) and it should be good
for merge.

Bruce


> Mihai
>
> >
> > >
> > > lyang001@lyang0-9010:~/intel-xeon-core/layers/oe-core/meta/classes$
> > > cat image.bbclass |grep -E "^RRECOM|^PACKAGE_INSTALL_ATTEMPTONLY"
> > > RRECOMMENDS += "${NORMAL_FEATURE_INSTALL_OPTIONAL}"
> > > PACKAGE_INSTALL_ATTEMPTONLY ?= "${FEATURE_INSTALL_OPTIONAL}"
> > >
> > >
> > >   Lei
> > >
> > >
> > >
> > > > Thanks,
> > > > Mihai
> > > >> Lei
> > > >> :-)
> > > >>
> > > >>> +    kernel-module-kvm \
> > > >>> +    kernel-module-kvm-intel \
> > > >>> +    kernel-module-kvm-amd \
> > > >>> +    "
> >
> > _______________________________________________
> > meta-virtualization mailing list
> > meta-virtualization@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-virtualization
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 8013 bytes --]

Re: [PATCH v2 2/2] Created new target:kvm-image-minimal

[lei yang]

On 01/25/2013 11:58 PM, Prica, Mihai wrote:
>> -----Original Message-----
>> From: meta-virtualization-bounces@yoctoproject.org [mailto:meta-virtualization-
>> bounces@yoctoproject.org] On Behalf Of Prica, Mihai
>> Sent: Wednesday, January 16, 2013 3:59 PM
>> To: lei yang
>> Cc: meta-virtualization@yoctoproject.org
>> Subject: Re: [meta-virtualization] [PATCH v2 2/2] Created new target:kvm-image-
>> minimal
>>
>>> -----Original Message-----
>>> From: lei yang [mailto:lei.yang@windriver.com]
>>> Sent: Wednesday, January 16, 2013 5:28 AM
>>> To: Prica, Mihai
>>> Cc: meta-virtualization@yoctoproject.org
>>> Subject: Re: [meta-virtualization] [PATCH v2 2/2] Created new
>>> target:kvm-image- minimal
>>>
>>> On 01/15/2013 06:44 PM, Prica, Mihai wrote:
>>>>> -----Original Message-----
>>>>> From: Lei Yang [mailto:lei.yang@windriver.com]
>>>>> Sent: Friday, January 11, 2013 7:17 PM
>>>>> To: Prica, Mihai
>>>>> Cc: meta-virtualization@yoctoproject.org
>>>>> Subject: Re: [meta-virtualization] [PATCH v2 2/2] Created new
>>>>> target:kvm-image- minimal
>>>>>
>>>>> On 01/12/2013 12:27 AM, Mihai Prica wrote:
>>>>>> Signed-off-by: Mihai Prica<mihai.prica@intel.com>
>>>>>> ---
>>>>>>     recipes-extended/images/kvm-image-minimal.bb |   28
>>>>> ++++++++++++++++++++++++++
>>>>>>     1 file changed, 28 insertions(+)
>>>>>>     create mode 100644 recipes-extended/images/kvm-image-minimal.bb
>>>>>>
>>>>>> diff --git a/recipes-extended/images/kvm-image-minimal.bb
>>>>>> b/recipes-extended/images/kvm-image-minimal.bb
>>>>>> new file mode 100644
>>>>>> index 0000000..275c43b
>>>>>> --- /dev/null
>>>>>> +++ b/recipes-extended/images/kvm-image-minimal.bb
>>>>>> @@ -0,0 +1,28 @@
>>>>>> +DESCRIPTION = "A minimal kvm image"
>>>>>> +
>>>>>> +IMAGE_INSTALL = " \
>>>>>> +    packagegroup-core-boot \
>>>>>> +    ${ROOTFS_PKGMANAGE_BOOTSTRAP} \
>>>>>> +    qemu \
>>>>>> +    libvirt \
>>>>>> +    libvirt-libvirtd \
>>>>>> +    libvirt-virsh \
>>>>>> +    "
>>>>>> +
>>>>>> +IMAGE_FEATURES += "ssh-server-openssh"
>>>>>> +
>>>>>> +IMAGE_LINGUAS = " "
>>>>>> +
>>>>>> +LICENSE = "MIT"
>>>>>> +
>>>>>> +inherit core-image
>>>>>> +
>>>>>> +IMAGE_ROOTFS_SIZE = "8192"
>>>>>> +
>>>>>> +ROOTFS_POSTPROCESS_COMMAND += "remove_packaging_data_files ;
>> "
>>>>>> +
>>>>>> +PACKAGE_INSTALL_ATTEMPTONLY = "\
>>>>> Hi Mibai
>>>>>
>>>>> can you explain "PACKAGE_INSTALL_ATTEMPTONLY " to me, I just see
>>>>> this variable first time
>>>> In an image recipe you can't use RRECOMMENDS to specify a list of
>>>> packages
>>> that extend the usability of the image being built.  In this type of
>>> recipe you can use PACKAGE_INSTALL_ATTEMPTONLY that has the same
>> functionality.
>>> and I think both can be used, from below, it tells me, they can
>>> perform the same function, do you try RRECOMEEDS and meet an error?
>> I tried using RRECOMMENDS. I didn't get any errors but the kernel modules were
>> not loaded onto the image. I tried a number of times to be sure it's because of
>> the shared state, but with the same result. With
>> PACAKAGE_INSTALL_ATTEMPTONLY it worked.

if you want to install  those kernel-modules, I like IMAGE_INSTALL , 
this is more popular used in practice

Lei

> I see this hasn't been merged to master yet. Is there a specific reason for this ? Maybe it's something I'm missing.
>
> Mihai
>
>>> lyang001@lyang0-9010:~/intel-xeon-core/layers/oe-core/meta/classes$
>>> cat image.bbclass |grep -E "^RRECOM|^PACKAGE_INSTALL_ATTEMPTONLY"
>>> RRECOMMENDS += "${NORMAL_FEATURE_INSTALL_OPTIONAL}"
>>> PACKAGE_INSTALL_ATTEMPTONLY ?= "${FEATURE_INSTALL_OPTIONAL}"
>>>
>>>
>>>    Lei
>>>
>>>
>>>
>>>> Thanks,
>>>> Mihai
>>>>> Lei
>>>>> :-)
>>>>>
>>>>>> +    kernel-module-kvm \
>>>>>> +    kernel-module-kvm-intel \
>>>>>> +    kernel-module-kvm-amd \
>>>>>> +    "
>> _______________________________________________
>> meta-virtualization mailing list
>> meta-virtualization@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-virtualization