All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] change misleading comment about device.map in grub-install
Date: Sun, 27 Jan 2013 16:18:32 +0100	[thread overview]
Message-ID: <51054548.2000908@gmail.com> (raw)
In-Reply-To: <1358874068-31100-1-git-send-email-arvidjaar@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1355 bytes --]

Comitted, thanks.
On 22.01.2013 18:01, Andrey Borzenkov wrote:

> grub-install is not supposed to create device.map; change comment
> to avoid confusion. It was already considered a bug by users.
> 
> Signed-off-by: Andrey Borzenkov <arvidjaar@gmail.com>
> 
> ---
>  ChangeLog            |    5 +++++
>  util/grub-install.in |    2 +-
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index 8c4d087..61dda4e 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2013-01-22  Andrey Borzenkov <arvidjaar@gmail.com>
> +
> +	* util/grub-install.in: change misleading comment about
> +	device.map creation
> +
>  2013-01-22  Colin Watson  <cjwatson@ubuntu.com>
>  
>  	* util/grub-reboot.in (usage): Document the need for
> diff --git a/util/grub-install.in b/util/grub-install.in
> index aac27c7..9e63cf5 100644
> --- a/util/grub-install.in
> +++ b/util/grub-install.in
> @@ -505,7 +505,7 @@ if test $recheck = yes; then
>      rm -f "$device_map"
>  fi
>  
> -# Create the device map file if it is not present.
> +# Device map file is optional
>  if test -f "$device_map"; then
>      # Make sure that there is no duplicated entry.
>      tmp=`sed -n '/^([fh]d[0-9]*)/s/\(^(.*)\).*/\1/p' "$device_map" \



-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

      reply	other threads:[~2013-01-27 15:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-22 17:01 [PATCH] change misleading comment about device.map in grub-install Andrey Borzenkov
2013-01-27 15:18 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51054548.2000908@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.