From: "H. Peter Anvin" <hpa@zytor.com>
To: Thomas Renninger <trenn@suse.de>
Cc: x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, horms@verge.net.au,
yinghai@kernel.org, vgoyal@redhat.com
Subject: Re: [PATCH 1/2] x86 e820: Check for exactmap appearance when parsing first memmap option
Date: Mon, 28 Jan 2013 17:09:27 -0800 [thread overview]
Message-ID: <51072147.9090306@zytor.com> (raw)
In-Reply-To: <1358868049-19884-2-git-send-email-trenn@suse.de>
On 01/22/2013 07:20 AM, Thomas Renninger wrote:
> From: Yinghai Lu <yinghai@kernel.org>
>
> memmap=exactmap will throw away all original, but also until then
> user defined (through other provided memmap= parameters) areas.
> That means all memmap= boot parameters passed before a memmap=exactmap
> parameter are not recognized.
> Without this fix:
> memmap=x@y memmap=exactmap memmap=i#k
> only i#k would get recognized.
>
> This is wrong, this fix will only throw away all original e820 areas once
> when memmap=exactmap is found in the whole boot command line and before
> any other memmap= option is parsed.
>
I don't understand why this is wrong. The kernel command line is always
parsed from left to right, and I don't see anything inherently
problematic with that with something like a big hammer like exactmap.
-hpa
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Thomas Renninger <trenn@suse.de>
Cc: yinghai@kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org,
kexec@lists.infradead.org, vgoyal@redhat.com, horms@verge.net.au
Subject: Re: [PATCH 1/2] x86 e820: Check for exactmap appearance when parsing first memmap option
Date: Mon, 28 Jan 2013 17:09:27 -0800 [thread overview]
Message-ID: <51072147.9090306@zytor.com> (raw)
In-Reply-To: <1358868049-19884-2-git-send-email-trenn@suse.de>
On 01/22/2013 07:20 AM, Thomas Renninger wrote:
> From: Yinghai Lu <yinghai@kernel.org>
>
> memmap=exactmap will throw away all original, but also until then
> user defined (through other provided memmap= parameters) areas.
> That means all memmap= boot parameters passed before a memmap=exactmap
> parameter are not recognized.
> Without this fix:
> memmap=x@y memmap=exactmap memmap=i#k
> only i#k would get recognized.
>
> This is wrong, this fix will only throw away all original e820 areas once
> when memmap=exactmap is found in the whole boot command line and before
> any other memmap= option is parsed.
>
I don't understand why this is wrong. The kernel command line is always
parsed from left to right, and I don't see anything inherently
problematic with that with something like a big hammer like exactmap.
-hpa
next prev parent reply other threads:[~2013-01-29 1:09 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 15:20 [PATCH 0/2] Only parse exactmap once, introduce memmap=resetusablemap Thomas Renninger
2013-01-22 15:20 ` Thomas Renninger
2013-01-22 15:20 ` [PATCH 1/2] x86 e820: Check for exactmap appearance when parsing first memmap option Thomas Renninger
2013-01-22 15:20 ` Thomas Renninger
2013-01-22 19:33 ` Yinghai Lu
2013-01-22 19:33 ` Yinghai Lu
2013-01-29 1:09 ` H. Peter Anvin [this message]
2013-01-29 1:09 ` H. Peter Anvin
2013-01-29 2:01 ` Yinghai Lu
2013-01-29 2:01 ` Yinghai Lu
2013-01-22 15:20 ` [PATCH 2/2] x86 e820: Introduce memmap=resetusablemap for kdump usage Thomas Renninger
2013-01-22 15:20 ` Thomas Renninger
2013-01-22 15:54 ` H. Peter Anvin
2013-01-22 15:54 ` H. Peter Anvin
2013-01-22 16:23 ` Thomas Renninger
2013-01-22 16:23 ` Thomas Renninger
2013-01-22 16:32 ` H. Peter Anvin
2013-01-22 16:32 ` H. Peter Anvin
2013-01-22 20:06 ` Yinghai Lu
2013-01-24 4:07 ` Yinghai Lu
2013-01-24 4:07 ` Yinghai Lu
2013-01-29 1:05 ` Thomas Renninger
2013-01-29 1:05 ` Thomas Renninger
2013-01-29 1:11 ` H. Peter Anvin
2013-01-29 1:11 ` H. Peter Anvin
2013-01-29 2:10 ` Yinghai Lu
2013-01-29 2:10 ` Yinghai Lu
2013-01-29 2:11 ` H. Peter Anvin
2013-01-29 2:11 ` H. Peter Anvin
2013-01-29 2:19 ` Yinghai Lu
2013-01-29 2:19 ` Yinghai Lu
2013-01-29 2:20 ` H. Peter Anvin
2013-01-29 2:20 ` H. Peter Anvin
2013-01-29 2:27 ` H. Peter Anvin
2013-01-29 2:27 ` H. Peter Anvin
2013-01-29 2:31 ` Yinghai Lu
2013-01-29 2:31 ` Yinghai Lu
2013-01-29 3:33 ` H. Peter Anvin
2013-01-29 3:33 ` H. Peter Anvin
2013-01-29 9:47 ` Thomas Renninger
2013-01-29 9:47 ` Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51072147.9090306@zytor.com \
--to=hpa@zytor.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trenn@suse.de \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.