[PATCH 1/2] iptables: Sync bbappend version with oe-core

[PATCH 1/2] iptables: Sync bbappend version with oe-core

[Mihai Prica]

Signed-off-by: Mihai Prica <mihai.prica@intel.com>
---
 recipes-extended/iptables/iptables_1.4.15.bbappend |    8 --------
 recipes-extended/iptables/iptables_1.4.17.bbappend |    8 ++++++++
 2 files changed, 8 insertions(+), 8 deletions(-)
 delete mode 100644 recipes-extended/iptables/iptables_1.4.15.bbappend
 create mode 100644 recipes-extended/iptables/iptables_1.4.17.bbappend

diff --git a/recipes-extended/iptables/iptables_1.4.15.bbappend b/recipes-extended/iptables/iptables_1.4.15.bbappend
deleted file mode 100644
index 52a4c4f..0000000
--- a/recipes-extended/iptables/iptables_1.4.15.bbappend
+++ /dev/null
@@ -1,8 +0,0 @@
-RRECOMMENDS_${PN} += "kernel-module-ip6-tables \
-                      kernel-module-ip6table-filter \
-                      kernel-module-xt-tcpudp \
-                      kernel-module-ipt-reject \
-                      kernel-module-iptable-mangle \
-                      kernel-module-xt-checksum \
-                      kernel-module-xt-state \
-                      "
diff --git a/recipes-extended/iptables/iptables_1.4.17.bbappend b/recipes-extended/iptables/iptables_1.4.17.bbappend
new file mode 100644
index 0000000..52a4c4f
--- /dev/null
+++ b/recipes-extended/iptables/iptables_1.4.17.bbappend
@@ -0,0 +1,8 @@
+RRECOMMENDS_${PN} += "kernel-module-ip6-tables \
+                      kernel-module-ip6table-filter \
+                      kernel-module-xt-tcpudp \
+                      kernel-module-ipt-reject \
+                      kernel-module-iptable-mangle \
+                      kernel-module-xt-checksum \
+                      kernel-module-xt-state \
+                      "
-- 
1.7.9.5

[PATCH 2/2] qemu: Enabled VGA output

[Mihai Prica]

Signed-off-by: Mihai Prica <mihai.prica@intel.com>
---
 recipes-devtools/qemu/qemu_1.3.0.bbappend |    3 +++
 1 file changed, 3 insertions(+)
 create mode 100644 recipes-devtools/qemu/qemu_1.3.0.bbappend

diff --git a/recipes-devtools/qemu/qemu_1.3.0.bbappend b/recipes-devtools/qemu/qemu_1.3.0.bbappend
new file mode 100644
index 0000000..2106825
--- /dev/null
+++ b/recipes-devtools/qemu/qemu_1.3.0.bbappend
@@ -0,0 +1,3 @@
+# Enables QEMU to display the VGA output
+DEPENDS_append = " libsdl"
+SDL = "--enable-sdl"
-- 
1.7.9.5

Re: [PATCH 2/2] qemu: Enabled VGA output

[David Nyström]

On 01/29/2013 02:01 PM, Mihai Prica wrote:
> Signed-off-by: Mihai Prica <mihai.prica@intel.com>
> ---
>   recipes-devtools/qemu/qemu_1.3.0.bbappend |    3 +++
>   1 file changed, 3 insertions(+)
>   create mode 100644 recipes-devtools/qemu/qemu_1.3.0.bbappend
>
> diff --git a/recipes-devtools/qemu/qemu_1.3.0.bbappend b/recipes-devtools/qemu/qemu_1.3.0.bbappend
> new file mode 100644
> index 0000000..2106825
> --- /dev/null
> +++ b/recipes-devtools/qemu/qemu_1.3.0.bbappend
> @@ -0,0 +1,3 @@
> +# Enables QEMU to display the VGA output
> +DEPENDS_append = " libsdl"
> +SDL = "--enable-sdl"
>

Should this really be in meta-virt, this seems a bit distro specific ?

Br,
David

Re: [PATCH 2/2] qemu: Enabled VGA output

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]

On Tue, Jan 29, 2013 at 8:38 AM, David Nyström <david.c.nystrom@gmail.com>wrote:

> On 01/29/2013 02:01 PM, Mihai Prica wrote:
>
>> Signed-off-by: Mihai Prica <mihai.prica@intel.com>
>> ---
>>   recipes-devtools/qemu/qemu_1.**3.0.bbappend |    3 +++
>>   1 file changed, 3 insertions(+)
>>   create mode 100644 recipes-devtools/qemu/qemu_1.**3.0.bbappend
>>
>> diff --git a/recipes-devtools/qemu/qemu_**1.3.0.bbappend
>> b/recipes-devtools/qemu/qemu_**1.3.0.bbappend
>> new file mode 100644
>> index 0000000..2106825
>> --- /dev/null
>> +++ b/recipes-devtools/qemu/qemu_**1.3.0.bbappend
>> @@ -0,0 +1,3 @@
>> +# Enables QEMU to display the VGA output
>> +DEPENDS_append = " libsdl"
>> +SDL = "--enable-sdl"
>>
>>
> Should this really be in meta-virt, this seems a bit distro specific ?
>

Can PACKAGECONFIG or a DISTRO_FEATURES help here ? SDL for qemu is
probably a bad example, but keeping everything that we think is important
for
out of box experience, or proper operation, contained within a layer is a
good
thing .. but leaving it conditional on a distro setting for those that
really don't
want it, seems to strike the right balance.

Cheers,

Bruce


>
> Br,
> David
>
> ______________________________**_________________
> meta-virtualization mailing list
> meta-virtualization@**yoctoproject.org<meta-virtualization@yoctoproject.org>
> https://lists.yoctoproject.**org/listinfo/meta-**virtualization<https://lists.yoctoproject.org/listinfo/meta-virtualization>
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 2658 bytes --]

Re: [PATCH 2/2] qemu: Enabled VGA output

[David Nyström]

On Tue 29 Jan 2013 02:54:49 PM CET, Bruce Ashfield wrote:
> On Tue, Jan 29, 2013 at 8:38 AM, David Nyström <david.c.nystrom@gmail.com>wrote:
>
>> On 01/29/2013 02:01 PM, Mihai Prica wrote:
>>
>>> Signed-off-by: Mihai Prica <mihai.prica@intel.com>
>>> ---
>>>    recipes-devtools/qemu/qemu_1.**3.0.bbappend |    3 +++
>>>    1 file changed, 3 insertions(+)
>>>    create mode 100644 recipes-devtools/qemu/qemu_1.**3.0.bbappend
>>>
>>> diff --git a/recipes-devtools/qemu/qemu_**1.3.0.bbappend
>>> b/recipes-devtools/qemu/qemu_**1.3.0.bbappend
>>> new file mode 100644
>>> index 0000000..2106825
>>> --- /dev/null
>>> +++ b/recipes-devtools/qemu/qemu_**1.3.0.bbappend
>>> @@ -0,0 +1,3 @@
>>> +# Enables QEMU to display the VGA output
>>> +DEPENDS_append = " libsdl"
>>> +SDL = "--enable-sdl"
>>>
>>>
>> Should this really be in meta-virt, this seems a bit distro specific ?
>>
>
> Can PACKAGECONFIG or a DISTRO_FEATURES help here ? SDL for qemu is
> probably a bad example, but keeping everything that we think is important
> for
> out of box experience, or proper operation, contained within a layer is a
> good
> thing .. but leaving it conditional on a distro setting for those that
> really don't
> want it, seems to strike the right balance.
>
> Cheers,
>
> Bruce

Agree, but even in this case, this is something for oe-core to 
facilitate in the qemu recipe.
Don't get me wrong, I'm not militant about anything, but I would rather 
like to avoid bbappends when possible,
if oe-core won't accept a PACKAGECONFIG enabling sdl, then lets the 
merge it here.

Br,
David

Re: [PATCH 2/2] qemu: Enabled VGA output

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 2003 bytes --]

On Tue, Jan 29, 2013 at 9:11 AM, David Nyström <david.c.nystrom@gmail.com>wrote:

> On Tue 29 Jan 2013 02:54:49 PM CET, Bruce Ashfield wrote:
>
>> On Tue, Jan 29, 2013 at 8:38 AM, David Nyström <david.c.nystrom@gmail.com
>> >**wrote:
>>
>>  On 01/29/2013 02:01 PM, Mihai Prica wrote:
>>>
>>>  Signed-off-by: Mihai Prica <mihai.prica@intel.com>
>>>> ---
>>>>    recipes-devtools/qemu/qemu_1.****3.0.bbappend |    3 +++
>>>>
>>>>    1 file changed, 3 insertions(+)
>>>>    create mode 100644 recipes-devtools/qemu/qemu_1.****3.0.bbappend
>>>>
>>>> diff --git a/recipes-devtools/qemu/qemu_****1.3.0.bbappend
>>>> b/recipes-devtools/qemu/qemu_****1.3.0.bbappend
>>>>
>>>> new file mode 100644
>>>> index 0000000..2106825
>>>> --- /dev/null
>>>> +++ b/recipes-devtools/qemu/qemu_****1.3.0.bbappend
>>>>
>>>> @@ -0,0 +1,3 @@
>>>> +# Enables QEMU to display the VGA output
>>>> +DEPENDS_append = " libsdl"
>>>> +SDL = "--enable-sdl"
>>>>
>>>>
>>>>  Should this really be in meta-virt, this seems a bit distro specific ?
>>>
>>>
>> Can PACKAGECONFIG or a DISTRO_FEATURES help here ? SDL for qemu is
>> probably a bad example, but keeping everything that we think is important
>> for
>> out of box experience, or proper operation, contained within a layer is a
>> good
>> thing .. but leaving it conditional on a distro setting for those that
>> really don't
>> want it, seems to strike the right balance.
>>
>> Cheers,
>>
>> Bruce
>>
>
> Agree, but even in this case, this is something for oe-core to facilitate
> in the qemu recipe.
> Don't get me wrong, I'm not militant about anything, but I would rather
> like to avoid bbappends when possible,
> if oe-core won't accept a PACKAGECONFIG enabling sdl, then lets the merge
> it here.
>

Agreed, one less bbappend is a good thing, and we have a good fallback
position.

Bruce


>
> Br,
> David
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 3267 bytes --]

Re: [PATCH 1/2] iptables: Sync bbappend version with oe-core

[David Nyström]

On 01/29/2013 02:01 PM, Mihai Prica wrote:
> Signed-off-by: Mihai Prica <mihai.prica@intel.com>
> ---
>   recipes-extended/iptables/iptables_1.4.15.bbappend |    8 --------
>   recipes-extended/iptables/iptables_1.4.17.bbappend |    8 ++++++++
>   2 files changed, 8 insertions(+), 8 deletions(-)
>   delete mode 100644 recipes-extended/iptables/iptables_1.4.15.bbappend
>   create mode 100644 recipes-extended/iptables/iptables_1.4.17.bbappend
>
> diff --git a/recipes-extended/iptables/iptables_1.4.15.bbappend b/recipes-extended/iptables/iptables_1.4.15.bbappend
> deleted file mode 100644
> index 52a4c4f..0000000
> --- a/recipes-extended/iptables/iptables_1.4.15.bbappend
> +++ /dev/null
> @@ -1,8 +0,0 @@
> -RRECOMMENDS_${PN} += "kernel-module-ip6-tables \
> -                      kernel-module-ip6table-filter \
> -                      kernel-module-xt-tcpudp \
> -                      kernel-module-ipt-reject \
> -                      kernel-module-iptable-mangle \
> -                      kernel-module-xt-checksum \
> -                      kernel-module-xt-state \
> -                      "
> diff --git a/recipes-extended/iptables/iptables_1.4.17.bbappend b/recipes-extended/iptables/iptables_1.4.17.bbappend
> new file mode 100644
> index 0000000..52a4c4f
> --- /dev/null
> +++ b/recipes-extended/iptables/iptables_1.4.17.bbappend
> @@ -0,0 +1,8 @@
> +RRECOMMENDS_${PN} += "kernel-module-ip6-tables \
> +                      kernel-module-ip6table-filter \
> +                      kernel-module-xt-tcpudp \
> +                      kernel-module-ipt-reject \
> +                      kernel-module-iptable-mangle \
> +                      kernel-module-xt-checksum \
> +                      kernel-module-xt-state \
> +                      "
>
Merged to master,
Thanks.

//DD

Re: [PATCH 2/2] qemu: Enabled VGA output

[Prica, Mihai]

> -----Original Message-----
> From: David Nyström [mailto:david.c.nystrom@gmail.com]
> Sent: Tuesday, January 29, 2013 4:12 PM
> To: Bruce Ashfield
> Cc: Prica, Mihai; meta-virtualization@yoctoproject.org
> Subject: Re: [meta-virtualization] [PATCH 2/2] qemu: Enabled VGA output
> 
> On Tue 29 Jan 2013 02:54:49 PM CET, Bruce Ashfield wrote:
> > On Tue, Jan 29, 2013 at 8:38 AM, David Nyström
> <david.c.nystrom@gmail.com>wrote:
> >
> >> On 01/29/2013 02:01 PM, Mihai Prica wrote:
> >>
> >>> Signed-off-by: Mihai Prica <mihai.prica@intel.com>
> >>> ---
> >>>    recipes-devtools/qemu/qemu_1.**3.0.bbappend |    3 +++
> >>>    1 file changed, 3 insertions(+)
> >>>    create mode 100644 recipes-devtools/qemu/qemu_1.**3.0.bbappend
> >>>
> >>> diff --git a/recipes-devtools/qemu/qemu_**1.3.0.bbappend
> >>> b/recipes-devtools/qemu/qemu_**1.3.0.bbappend
> >>> new file mode 100644
> >>> index 0000000..2106825
> >>> --- /dev/null
> >>> +++ b/recipes-devtools/qemu/qemu_**1.3.0.bbappend
> >>> @@ -0,0 +1,3 @@
> >>> +# Enables QEMU to display the VGA output DEPENDS_append = " libsdl"
> >>> +SDL = "--enable-sdl"
> >>>
> >>>
> >> Should this really be in meta-virt, this seems a bit distro specific ?
> >>
> >
> > Can PACKAGECONFIG or a DISTRO_FEATURES help here ? SDL for qemu is
> > probably a bad example, but keeping everything that we think is
> > important for out of box experience, or proper operation, contained
> > within a layer is a good thing .. but leaving it conditional on a
> > distro setting for those that really don't want it, seems to strike
> > the right balance.
> >
> > Cheers,
> >
> > Bruce
> 
> Agree, but even in this case, this is something for oe-core to facilitate in the
> qemu recipe.
> Don't get me wrong, I'm not militant about anything, but I would rather like to
> avoid bbappends when possible, if oe-core won't accept a PACKAGECONFIG
> enabling sdl, then lets the merge it here.

Yes, you're right, that’s the right way to go.
I'll tweak the patch with PACKAGECONFIG or DISTRO_FEATURES and see if this can be merged to oe-core and keep you updated.

Thanks,
Mihai

> 
> Br,
> David