Re: [PATCH]: Add GRUB_DISABLE_SUBMENU option

[Prarit Bhargava <prarit@redhat.com>]

>>
>> /usr/sbin/grub2-reboot 'Advanced options for openSUSE 12.2>openSUSE 12.2, with
>> Linux 3.4.6-2.10-desktop (recovery mode)'
>>
> 
> That's what good command line completion is for. Really :)

Heh :)  Fair enough :)

> 
> How is user going to know which number to type? Open grub.cfg and count?

This is what I used to do in grub1 ... I wrote a nice little script that dumped
the contents of grub config and enumerated the entries so that I could select
which one I wanted.

FWIW, I could do *exactly* the same thing with grub2, but I'm wondering if there
is a "better" way so that the kernel debugging users of grub2 could all benefit.

> Actually I have patch to disable submenu somewhere around as well. So I
> can well understand your feelings, I just think this is unrelated to
> grub-reboot.

You're right, and I'm not saying it is :)  I like to provide a decent use-case
scenario with a patch so people who read it later understand _why_ I've made a
change.

> 
>> Alternatively, would you object to me to adding some additional functionality to
>> grub2-reboot that would grep grub.cfg and display a menu of entries so that
>> 'grub2-reboot #number' would work with submenus?
>>
> 
> I think something like "grub-reboot --select" would be interesting,
> yes. But it is not for me to decide :)

I've talked with a few other kernel engineers, and they like the idea of just
adding GRUB_DISABLE_SUBMENU="true" to /etc/default/grub ... IMO it still seems
like the easiest approach.

Beyond the grub-reboot stuff, do you have any objections to the patch going in?

Thanks for your input (and the info!) Andrey.  That was really helpful :)

P.