Re: [PATCH] document GRUB_DISABLE_SUBMENU

From: Barry Jackson <zen25000@zen.co.uk>
To: grub-devel@gnu.org
Subject: Re: [PATCH] document GRUB_DISABLE_SUBMENU
Date: Sun, 10 Nov 2013 13:59:45 +0000	[thread overview]
Message-ID: <527F9151.6000906@zen.co.uk> (raw)
In-Reply-To: <527F8BBC.4050203@gmail.com>

On 10/11/13 13:35, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 10.11.2013 14:20, Andrey Borzenkov wrote:
>> В Mon, 04 Nov 2013 17:09:15 +0100
>> Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
>>
>>> On 04.11.2013 15:27, Andrey Borzenkov wrote:
>>>> В Mon, 04 Nov 2013 14:15:40 +0100
>>>> Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
>>>>> Could you add that toggling this requires changing default/GRUB_DEFAULT
>>>>> and saved default?
>>>>>
>>>>>
>>>>
>>>> Like this?
>>>>
>>> I think it should be "will" not "may". And also explicit mention of
>>> default, fallback, GRUB_DEFAULT and grub-reboot/grub-set-default with
>>> links would be helpful
>>
>>
>> Default won't need to be changed if it already refers to top-level menu
>> entry by ID or title (which does not change). Below is the best I could
>> come up with without making it exceedingly large.
>>
> Thank you. Go ahead.
>> From: Andrey Borzenkov <arvidjaar@gmail.com>
>> To: grub-devel@gnu.org
>> Subject: [PATCH] document GRUB_DISABLE_SUBMENU
>>
>> Signed-off-by: Andrey Borzenkov <arvidjaar@gmail.com>
>>
>> ---
>>   docs/grub.texi | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/docs/grub.texi b/docs/grub.texi
>> index ead8fbd..58e04e2 100644
>> --- a/docs/grub.texi
>> +++ b/docs/grub.texi
>> @@ -1450,6 +1450,18 @@ Normally, @command{grub-mkconfig} will try to use the external
>>   systems installed on the same system and generate appropriate menu entries
>>   for them.  Set this option to @samp{true} to disable this.
>>
>> +@item GRUB_DISABLE_SUBMENU
>> +Normally, @command{grub-mkconfig} will generate top level menu entry for
>> +the kernel with highest version number and put all other found kernels
>> +or alternative menu entries for recovery mode in submenu. For entries returned
>> +by @command{os-prober} first entry will be put on top level and all others
>> +in submenu. If this option is set to @samp{y}, flat menu with all entries
>> +on top level will be generated instead. Changing this option will require
>> +changing existing values of @samp{GRUB_DEFAULT}, @samp{fallback} (@pxref{fallback})
>> +and @samp{default} (@pxref{default}) environment variables as well as saved
>> +default entry using @command{grub-set-default} and value used with
>> +@command{grub-reboot}.
>> +
>>   @item GRUB_ENABLE_CRYPTODISK
>>   If set to @samp{y}, @command{grub-mkconfig} and @command{grub-install} will
>>   check for encrypted disks and generate additional commands needed to access
>>
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> https://lists.gnu.org/mailman/listinfo/grub-devel
>>
>
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>

Is it not inconsistent to use  y/n for GRUB_DISABLE_SUBMENU when all 
other variables accept true/false ?