From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: architected timers: allow dt based discovery using clocksource_of_init
Date: Wed, 30 Jan 2013 10:49:54 -0700 [thread overview]
Message-ID: <51095D42.1020701@wwwdotorg.org> (raw)
In-Reply-To: <20130130171930.GA23801@e106331-lin.cambridge.arm.com>
On 01/30/2013 10:19 AM, Mark Rutland wrote:
> Thomas,
>
> On Tue, Jan 22, 2013 at 11:04:56AM +0000, Mark Rutland wrote:
>> On Mon, Jan 21, 2013 at 06:30:47PM +0000, Thomas Abraham wrote:
>>> Hi Stephen,
>>>
>>> On 21 January 2013 09:21, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>>> On 01/20/2013 06:22 PM, Thomas Abraham wrote:
>>>>> Add an entry in __clksrc_of_table so that ARMv7 architected timer is
>>>>> discoverable using call to clocksource_of_init.
>>>>
>>>>> diff --git a/arch/arm/kernel/arch_timer.c b/arch/arm/kernel/arch_timer.c
>>>>
>>>>> +#ifdef CONFIG_CLKSRC_OF
>>>>> +CLOCKSOURCE_OF_DECLARE(armv7_timer, "arm,armv7-timer", arch_timer_of_register)
>>>>> +#endif
>>>>
>>>> I wonder if we shouldn't enhance include/linux/clocksource.h to define
>>>> CLOCKSOURCE_OF_DECLARE even when !CONFIG_CLKSRC_OF; that way, drivers
>>>> wouldn't need that ifdef.
>>>
>>> Yes, it will be helpful to have a !CONFIG_CLKSRC_OF version of
>>> CLOCKSOURCE_OF_DECLARE. And can CONFIG_CLKSRC_OF be enabled by default
>>> for all ARM platforms?
>>>
>>> Thanks,
>>> Thomas.
>>
>> Thomas,
>>
>> Once the above is worked out, could you send me the updated patch with a
>> pointer to whichever {branch,patch}(es) I need for CLKSRC_OF?
>
> Is there any news on this? I'd like to be able to push out a branch ready for
> merging soon.
I just sent a patch for this.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "swarren@nvidia.com" <swarren@nvidia.com>,
"johnstul@us.ibm.com" <johnstul@us.ibm.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
Thomas Abraham <thomas.abraham@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: architected timers: allow dt based discovery using clocksource_of_init
Date: Wed, 30 Jan 2013 10:49:54 -0700 [thread overview]
Message-ID: <51095D42.1020701@wwwdotorg.org> (raw)
In-Reply-To: <20130130171930.GA23801@e106331-lin.cambridge.arm.com>
On 01/30/2013 10:19 AM, Mark Rutland wrote:
> Thomas,
>
> On Tue, Jan 22, 2013 at 11:04:56AM +0000, Mark Rutland wrote:
>> On Mon, Jan 21, 2013 at 06:30:47PM +0000, Thomas Abraham wrote:
>>> Hi Stephen,
>>>
>>> On 21 January 2013 09:21, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>>> On 01/20/2013 06:22 PM, Thomas Abraham wrote:
>>>>> Add an entry in __clksrc_of_table so that ARMv7 architected timer is
>>>>> discoverable using call to clocksource_of_init.
>>>>
>>>>> diff --git a/arch/arm/kernel/arch_timer.c b/arch/arm/kernel/arch_timer.c
>>>>
>>>>> +#ifdef CONFIG_CLKSRC_OF
>>>>> +CLOCKSOURCE_OF_DECLARE(armv7_timer, "arm,armv7-timer", arch_timer_of_register)
>>>>> +#endif
>>>>
>>>> I wonder if we shouldn't enhance include/linux/clocksource.h to define
>>>> CLOCKSOURCE_OF_DECLARE even when !CONFIG_CLKSRC_OF; that way, drivers
>>>> wouldn't need that ifdef.
>>>
>>> Yes, it will be helpful to have a !CONFIG_CLKSRC_OF version of
>>> CLOCKSOURCE_OF_DECLARE. And can CONFIG_CLKSRC_OF be enabled by default
>>> for all ARM platforms?
>>>
>>> Thanks,
>>> Thomas.
>>
>> Thomas,
>>
>> Once the above is worked out, could you send me the updated patch with a
>> pointer to whichever {branch,patch}(es) I need for CLKSRC_OF?
>
> Is there any news on this? I'd like to be able to push out a branch ready for
> merging soon.
I just sent a patch for this.
next prev parent reply other threads:[~2013-01-30 17:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 1:22 [PATCH] ARM: architected timers: allow dt based discovery using clocksource_of_init Thomas Abraham
2013-01-21 1:22 ` Thomas Abraham
2013-01-21 12:13 ` Mark Rutland
2013-01-21 12:13 ` Mark Rutland
2013-01-21 18:19 ` Thomas Abraham
2013-01-21 18:19 ` Thomas Abraham
2013-01-21 17:21 ` Stephen Warren
2013-01-21 17:21 ` Stephen Warren
2013-01-21 18:25 ` Marc Zyngier
2013-01-21 18:25 ` Marc Zyngier
2013-01-21 18:30 ` Thomas Abraham
2013-01-21 18:30 ` Thomas Abraham
2013-01-22 11:04 ` Mark Rutland
2013-01-22 11:04 ` Mark Rutland
2013-01-30 17:19 ` Mark Rutland
2013-01-30 17:19 ` Mark Rutland
2013-01-30 17:49 ` Stephen Warren [this message]
2013-01-30 17:49 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51095D42.1020701@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.