From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Dave Hansen <dave@linux.vnet.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] rip out x86_32 NUMA remapping code
Date: Thu, 31 Jan 2013 13:59:07 -0800 [thread overview]
Message-ID: <510AE92B.8020605@zytor.com> (raw)
In-Reply-To: <CAE9FiQVn6_QZi3fNQ-JHYiR-7jeDJ5hT0SyT_+zVvfOj=PzF3w@mail.gmail.com>
On 01/31/2013 01:55 PM, Yinghai Lu wrote:
> On Thu, Jan 31, 2013 at 1:51 PM, H. Peter Anvin <hpa@zytor.com> wrote:
>> I get a build failure on i386 allyesconfig with this patch:
>>
>> arch/x86/power/built-in.o: In function `swsusp_arch_resume':
>> (.text+0x14e4): undefined reference to `resume_map_numa_kva'
>>
>> It looks trivial to fix up; I assume resume_map_numa_kva() just goes
>> away like it does in the non-NUMA case, but it would be nice if you
>> could confirm that.
>
> the patches does not seem to complete.
>
> at least, it does not remove
>
> arch/x86/mm/numa.c: nd = alloc_remap(nid, nd_size);
>
... which will just return NULL because alloc_remap turns into an inline
just returning NULL. So the compiled code is correct, but the source
code is needlessly messy.
-hpa
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Dave Hansen <dave@linux.vnet.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] rip out x86_32 NUMA remapping code
Date: Thu, 31 Jan 2013 13:59:07 -0800 [thread overview]
Message-ID: <510AE92B.8020605@zytor.com> (raw)
In-Reply-To: <CAE9FiQVn6_QZi3fNQ-JHYiR-7jeDJ5hT0SyT_+zVvfOj=PzF3w@mail.gmail.com>
On 01/31/2013 01:55 PM, Yinghai Lu wrote:
> On Thu, Jan 31, 2013 at 1:51 PM, H. Peter Anvin <hpa@zytor.com> wrote:
>> I get a build failure on i386 allyesconfig with this patch:
>>
>> arch/x86/power/built-in.o: In function `swsusp_arch_resume':
>> (.text+0x14e4): undefined reference to `resume_map_numa_kva'
>>
>> It looks trivial to fix up; I assume resume_map_numa_kva() just goes
>> away like it does in the non-NUMA case, but it would be nice if you
>> could confirm that.
>
> the patches does not seem to complete.
>
> at least, it does not remove
>
> arch/x86/mm/numa.c: nd = alloc_remap(nid, nd_size);
>
... which will just return NULL because alloc_remap turns into an inline
just returning NULL. So the compiled code is correct, but the source
code is needlessly messy.
-hpa
next prev parent reply other threads:[~2013-01-31 21:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 0:56 [RFC][PATCH] rip out x86_32 NUMA remapping code Dave Hansen
2013-01-31 0:56 ` Dave Hansen
2013-01-31 21:24 ` H. Peter Anvin
2013-01-31 21:24 ` H. Peter Anvin
2013-01-31 21:51 ` H. Peter Anvin
2013-01-31 21:51 ` H. Peter Anvin
2013-01-31 21:55 ` Yinghai Lu
2013-01-31 21:55 ` Yinghai Lu
2013-01-31 21:59 ` H. Peter Anvin [this message]
2013-01-31 21:59 ` H. Peter Anvin
2013-01-31 22:01 ` Yinghai Lu
2013-01-31 22:01 ` Yinghai Lu
2013-01-31 22:03 ` H. Peter Anvin
2013-01-31 22:03 ` H. Peter Anvin
2013-01-31 22:09 ` Dave Hansen
2013-01-31 22:09 ` Dave Hansen
2013-01-31 22:12 ` H. Peter Anvin
2013-01-31 22:12 ` H. Peter Anvin
2013-01-31 22:41 ` [tip:x86/mm] x86-32, mm: Remove reference to alloc_remap() tip-bot for H. Peter Anvin
2013-01-31 22:39 ` [tip:x86/mm] x86-32, mm: Rip out x86_32 NUMA remapping code tip-bot for Dave Hansen
2013-01-31 22:40 ` [tip:x86/mm] x86-32, mm: Remove reference to resume_map_numa_kva( ) tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510AE92B.8020605@zytor.com \
--to=hpa@zytor.com \
--cc=dave@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.