* [PATCH] hfp_hf_bluez5: Remove error handling for g_io_channel_unix_new()
@ 2013-01-31 18:30 Vinicius Costa Gomes
2013-01-31 22:00 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: Vinicius Costa Gomes @ 2013-01-31 18:30 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
Apart from g_io_channel_unix_new() not setting errno, it never
returns an NULL pointer on error, because in practice it only
calls g_new().
---
plugins/hfp_hf_bluez5.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c
index 8cac945..ff4dbad 100644
--- a/plugins/hfp_hf_bluez5.c
+++ b/plugins/hfp_hf_bluez5.c
@@ -137,11 +137,6 @@ static int service_level_connection(struct ofono_modem *modem,
GAtChat *chat;
io = g_io_channel_unix_new(fd);
- if (io == NULL) {
- ofono_error("Service level connection failed: %s (%d)",
- strerror(errno), errno);
- return -EIO;
- }
syntax = g_at_syntax_new_gsm_permissive();
chat = g_at_chat_new(io, syntax);
--
1.8.1.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hfp_hf_bluez5: Remove error handling for g_io_channel_unix_new()
2013-01-31 18:30 [PATCH] hfp_hf_bluez5: Remove error handling for g_io_channel_unix_new() Vinicius Costa Gomes
@ 2013-01-31 22:00 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2013-01-31 22:00 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 360 bytes --]
Hi Vinicius,
On 01/31/2013 12:30 PM, Vinicius Costa Gomes wrote:
> Apart from g_io_channel_unix_new() not setting errno, it never
> returns an NULL pointer on error, because in practice it only
> calls g_new().
> ---
> plugins/hfp_hf_bluez5.c | 5 -----
> 1 file changed, 5 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-31 22:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-31 18:30 [PATCH] hfp_hf_bluez5: Remove error handling for g_io_channel_unix_new() Vinicius Costa Gomes
2013-01-31 22:00 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.